decomp: finish plant-boss and crates (#1012)

* stuck: `crates` has issues setting bitfield with `r0`

* decomp: finish `plant-boss` except for 1 function

* decomp: finish `crates`

* address feedback

scripts/check-gsrc-file.py

@@ -15,6 +15,7 @@ method_split_pattern = re.compile('t9-\d+\s\(method-of-object')
 function_split_pattern = re.compile('\(t9-\d+\)')
 missing_res_tag_pattern = re.compile('(sv-\d{2,} int)')
 decompiler_error_pattern = re.compile(';; ERROR')
+missing_state_arg = re.compile('\s\(-> arg3 param \d\)\s')
 
 for file in files:
   src_path = ""
@@ -53,6 +54,12 @@ for file in files:
         print("decompiler_error - {}:{}".format(file_path, lineno + 1))
         throw_error = True
         continue
+      # todo - not good enough, ignore if there is only whitespace on the leftof the match
+      # missing_state_arg_match = missing_state_arg.search(line)
+      # if missing_state_arg_match:
+      #   print("missing_state_arg - {}:{}".format(file_path, lineno + 1))
+      #   throw_error = True
+      #   continue
 
 if throw_error:
   print("found potential problems!")

scripts/update-goal-src.py

@@ -32,7 +32,8 @@ files_with_modifications = [
   "logic-target",
   "default-menu",
   "collide-shape",
-  "cam-states"
+  "cam-states",
+  "plant-boss"
 ]
 
 for file in files: