mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-07-09 06:53:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

improve debugger disasm, :sym-name and fix Windows builds (#959)

Browse Source 
* improve debugger disasm, `:sym-name` and fix Windows builds

* >:(

* use this inline constexpr thing??

* fine use strings then

* please.... please work...

* fix windows debugger oopsie

* display rip as goal addr as well

* [debugger] attempt to backtrace even if landed on some garbage memory

* Update CMakePresets.json
This commit is contained in:
ManDude
2021-11-13 03:00:41 +00:00
committed by GitHub
parent 08d3294fcd
commit ff50cf2552
9 changed files with 133 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goalc/compiler/compilation/Debug.cpp
+7 -9
View File
@@ -338,9 +338,6 @@ Val* Compiler::compile_disasm(const goos::Object& form, const goos::Object& rest
":disasm used on over 1 MB of memory, this probably isn't what you meant to do."));
}
std::vector<u8> mem;
mem.resize(size);
if (addr < EE_MAIN_MEM_LOW_PROTECT || (addr + size) > EE_MAIN_MEM_SIZE) {
throw_compiler_error(form,
":disasm memory out of range. Wanted to print 0x{:x} to 0x{:x}, but valid "
@@ -348,11 +345,8 @@ Val* Compiler::compile_disasm(const goos::Object& form, const goos::Object& rest
addr, addr + size, EE_MAIN_MEM_LOW_PROTECT, EE_MAIN_MEM_SIZE);
}
m_debugger.read_memory(mem.data(), size, addr);
fmt::print("{}\n", m_debugger.get_info_about_addr(addr));
fmt::print("{}\n",
disassemble_x86(mem.data(), mem.size(), m_debugger.get_x86_base_addr() + addr));
fmt::print("{}\n", m_debugger.disassemble_x86_with_symbols(size, addr));
return get_none();
}
@@ -403,8 +397,12 @@ Val* Compiler::compile_d_sym_name(const goos::Object& form, const goos::Object&
"the target must be halted.");
}
fmt::print("symbol name for symbol {:X}h is {}\n", ofs,
m_debugger.get_symbol_name_from_offset(ofs));
auto sym_name = m_debugger.get_symbol_name_from_offset(ofs);
if (sym_name) {
fmt::print("symbol name for symbol {:X}h is {}\n", ofs, sym_name);
} else {
fmt::print("symbol {:X}h is not loaded or is invalid\n", ofs);
}
return get_none();
}