mirror of
https://github.com/open-goal/jak-project
synced 2026-08-02 00:34:13 -04:00
improve decomp of state handlers and art groups (#3014)
- state handlers that are not inlined lambdas have smarter type checking, getting rid of 99.9% of the casts emitted (they were not useful) - art groups were not being properly linked to their "master" groups. - `max` in `ja` in Jak 2 was not being detected. Another huge PR...
This commit is contained in:
@@ -111,8 +111,8 @@ bool convert_to_expressions(
|
||||
|
||||
// the return value of this function is not an exact match
|
||||
// we cast it to avoid complicated issues with polymorphism (e.g. methods)
|
||||
// we don't run this if we find a (return statement because we do not handle
|
||||
// type checking on those at the moment.
|
||||
// we don't run this if we find a (return statement for unknown reasons
|
||||
// TODO : remove this and check?
|
||||
if (!found_early_return && f.type.last_arg() != return_type) {
|
||||
needs_cast = true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user