mirror of
https://github.com/open-goal/jak-project
synced 2026-09-10 20:29:51 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
59 lines
2.4 KiB
Plaintext
Vendored
Generated
59 lines
2.4 KiB
Plaintext
Vendored
Generated
/* File: GNV$CONFTEST.C_FIRST
|
|
*
|
|
* Copyright (C) John Malmberg
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
|
|
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*
|
|
* SPDX-License-Identifier: ISC
|
|
*
|
|
*/
|
|
|
|
/* This is needed for Configure tests to get the correct exit status */
|
|
void __posix_exit(int __status);
|
|
#define exit(__p1) __posix_exit(__p1)
|
|
|
|
/* Fake pass the test to find a standard ldap routine that we know is */
|
|
/* present on VMS, but with the wrong case for the symbol */
|
|
char ldap_url_parse(void) {return 0;}
|
|
|
|
/* These are to pass the test that does not use headers */
|
|
/* Because configure does an #undef which keeps us from using #define */
|
|
/* char CRYPTO_add_lock(void) {return 0;} */
|
|
char SSL_connect(void) {return 0;}
|
|
char ENGINE_init(void) {return 0;}
|
|
char RAND_status(void) {return 0;}
|
|
/* char RAND_screen(void) {return 0;} In headers, but not present */
|
|
char CRYPTO_cleanup_all_ex_data(void) {return 0;}
|
|
char SSL_get_shutdown(void) {return 0;}
|
|
char ENGINE_load_builtin_engines(void) {return 0;}
|
|
|
|
/* And these are to pass the test that uses headers. */
|
|
/* Because the HP OpenSSL transfer vectors are currently in Upper case only */
|
|
#pragma message disable macroredef
|
|
#define CRYPTO_add_lock CRYPTO_ADD_LOCK
|
|
#define SSL_connect SSL_CONNECT
|
|
#define ENGINE_init ENGINE_INIT
|
|
#define RAND_status RAND_STATUS
|
|
/* #define RAND_screen RAND_SCREEN */
|
|
#define CRYPTO_cleanup_all_ex_data CRYPTO_CLEANUP_ALL_EX_DATA
|
|
#define SSL_get_shutdown SSL_GET_SHUTDOWN
|
|
#define ENGINE_load_builtin_engines ENGINE_LOAD_BUILTIN_ENGINES
|
|
|
|
/* Can not use the #define macro to fix the case on CRYPTO_lock because */
|
|
/* there is a macro CRYPTO_LOCK that is a number */
|
|
|
|
/* After all the work to get configure to pass the CRYPTO_LOCK tests,
|
|
* it turns out that VMS does not have the CRYPTO_LOCK symbol in the
|
|
* transfer vector, even though it is in the header file.
|
|
*/
|