mirror of
https://github.com/open-goal/jak-project
synced 2026-09-12 20:56:09 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
226 lines
9.6 KiB
C
Vendored
Generated
226 lines
9.6 KiB
C
Vendored
Generated
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "unitcheck.h"
|
|
|
|
#ifdef CURL_HAVE_DIAG
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Wformat"
|
|
#endif
|
|
|
|
static CURLcode test_unit1398(const char *arg)
|
|
{
|
|
UNITTEST_BEGIN_SIMPLE
|
|
|
|
int rc;
|
|
char buf[3] = { 'b', 'u', 'g' };
|
|
static const char *str = "bug";
|
|
int width = 3;
|
|
char output[130];
|
|
|
|
/* #define curl_msnprintf snprintf */
|
|
|
|
/* negative precision is treated as if omitted */
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*s", -1, str);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "bug"), "wrong output");
|
|
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*s", -1, "0123456789");
|
|
fail_unless(rc == 10, "return code should be 10");
|
|
fail_unless(!strcmp(output, "0123456789"), "wrong output");
|
|
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*s", 0, "0123456789");
|
|
fail_unless(rc == 0, "return code should be 0");
|
|
fail_unless(!strcmp(output, ""), "wrong output");
|
|
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*s", -2, str);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "bug"), "wrong output");
|
|
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*d", -3, 10000);
|
|
fail_unless(rc == 5, "return code should be 5");
|
|
fail_unless(!strcmp(output, "10000"), "wrong output");
|
|
|
|
rc = curl_msnprintf(output, sizeof(output), "%.*d", 0, 1234567);
|
|
fail_unless(rc == 7, "return code should be 0");
|
|
fail_unless(!strcmp(output, "1234567"), "wrong output");
|
|
|
|
/* without a trailing zero */
|
|
rc = curl_msnprintf(output, 4, "%.*s", width, buf);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "bug"), "wrong output");
|
|
|
|
/* with a trailing zero */
|
|
rc = curl_msnprintf(output, 4, "%.*s", width, str);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "bug"), "wrong output");
|
|
|
|
width = 2;
|
|
/* one byte less */
|
|
rc = curl_msnprintf(output, 4, "%.*s", width, buf);
|
|
fail_unless(rc == 2, "return code should be 2");
|
|
fail_unless(!strcmp(output, "bu"), "wrong output");
|
|
|
|
/* string with larger precision */
|
|
rc = curl_msnprintf(output, 8, "%.8s", str);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "bug"), "wrong output");
|
|
|
|
/* longer string with precision */
|
|
rc = curl_msnprintf(output, 8, "%.3s", "0123456789");
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "012"), "wrong output");
|
|
|
|
/* negative width */
|
|
rc = curl_msnprintf(output, 8, "%-8s", str);
|
|
fail_unless(rc == 7, "return code should be 7");
|
|
fail_unless(!strcmp(output, "bug "), "wrong output");
|
|
|
|
/* larger width that string length */
|
|
rc = curl_msnprintf(output, 8, "%8s", str);
|
|
fail_unless(rc == 7, "return code should be 7");
|
|
fail_unless(!strcmp(output, " bu"), "wrong output");
|
|
|
|
/* output a number in a limited output */
|
|
rc = curl_msnprintf(output, 4, "%d", 10240);
|
|
fail_unless(rc == 3, "return code should be 3");
|
|
fail_unless(!strcmp(output, "102"), "wrong output");
|
|
|
|
/* padded strings */
|
|
rc = curl_msnprintf(output, 16, "%8s%8s", str, str);
|
|
fail_unless(rc == 15, "return code should be 15");
|
|
fail_unless(!strcmp(output, " bug bu"), "wrong output");
|
|
|
|
/* padded numbers */
|
|
rc = curl_msnprintf(output, 16, "%8d%8d", 1234, 5678);
|
|
fail_unless(rc == 15, "return code should be 15");
|
|
fail_unless(!strcmp(output, " 1234 567"), "wrong output");
|
|
|
|
#if defined(__clang__) && \
|
|
(__clang_major__ > 3 || (__clang_major__ == 3 && __clang_minor__ >= 1))
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wformat-non-iso"
|
|
#endif
|
|
/* double precision */
|
|
rc = curl_msnprintf(output, 24, "%2$.*1$.99d", 3, 5678);
|
|
fail_unless(rc == 0, "return code should be 0");
|
|
#if defined(__clang__) && \
|
|
(__clang_major__ > 3 || (__clang_major__ == 3 && __clang_minor__ >= 1))
|
|
#pragma clang diagnostic pop
|
|
#endif
|
|
|
|
/* 129 input % flags */
|
|
rc = curl_msnprintf(output, 130,
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 10 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 20 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 30 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 40 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 50 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 60 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 70 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 80 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 90 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 100 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 110 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 120 */
|
|
"%s%s%s%s%s%s%s%s%s", /* 129 */
|
|
|
|
"a", "", "", "", "", "", "", "", "", "", /* 10 */
|
|
"b", "", "", "", "", "", "", "", "", "", /* 20 */
|
|
"c", "", "", "", "", "", "", "", "", "", /* 30 */
|
|
"d", "", "", "", "", "", "", "", "", "", /* 40 */
|
|
"e", "", "", "", "", "", "", "", "", "", /* 50 */
|
|
"f", "", "", "", "", "", "", "", "", "", /* 60 */
|
|
"g", "", "", "", "", "", "", "", "", "", /* 70 */
|
|
"h", "", "", "", "", "", "", "", "", "", /* 80 */
|
|
"i", "", "", "", "", "", "", "", "", "", /* 90 */
|
|
"j", "", "", "", "", "", "", "", "", "", /* 100 */
|
|
"k", "", "", "", "", "", "", "", "", "", /* 110 */
|
|
"l", "", "", "", "", "", "", "", "", "", /* 120 */
|
|
"m", "", "", "", "", "", "", "", "" /* 129 */
|
|
);
|
|
fail_unless(rc == 0, "return code should be 0");
|
|
|
|
/* 128 input % flags */
|
|
rc = curl_msnprintf(output, 130,
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 10 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 20 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 30 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 40 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 50 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 60 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 70 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 80 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 90 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 100 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 110 */
|
|
"%s%s%s%s%s%s%s%s%s%s" /* 120 */
|
|
"%s%s%s%s%s%s%s%s", /* 128 */
|
|
|
|
"a", "", "", "", "", "", "", "", "", "", /* 10 */
|
|
"b", "", "", "", "", "", "", "", "", "", /* 20 */
|
|
"c", "", "", "", "", "", "", "", "", "", /* 30 */
|
|
"d", "", "", "", "", "", "", "", "", "", /* 40 */
|
|
"e", "", "", "", "", "", "", "", "", "", /* 50 */
|
|
"f", "", "", "", "", "", "", "", "", "", /* 60 */
|
|
"g", "", "", "", "", "", "", "", "", "", /* 70 */
|
|
"h", "", "", "", "", "", "", "", "", "", /* 80 */
|
|
"i", "", "", "", "", "", "", "", "", "", /* 90 */
|
|
"j", "", "", "", "", "", "", "", "", "", /* 100 */
|
|
"k", "", "", "", "", "", "", "", "", "", /* 110 */
|
|
"l", "", "", "", "", "", "", "", "", "", /* 120 */
|
|
"m", "", "", "", "", "", "", "" /* 128 */
|
|
);
|
|
fail_unless(rc == 13, "return code should be 13");
|
|
|
|
/* 129 output segments */
|
|
rc = curl_msnprintf(output, 130,
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 20 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 40 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 60 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 80 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 100 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 120 */
|
|
"%%%%%%%%%%%%%%%%%%" /* 129 */
|
|
);
|
|
fail_unless(rc == 0, "return code should be 0");
|
|
|
|
/* 128 output segments */
|
|
rc = curl_msnprintf(output, 129,
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 20 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 40 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 60 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 80 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 100 */
|
|
"%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%" /* 120 */
|
|
"%%%%%%%%%%%%%%%%" /* 128 */
|
|
);
|
|
fail_unless(rc == 128, "return code should be 128");
|
|
|
|
UNITTEST_END_SIMPLE
|
|
}
|
|
|
|
#ifdef CURL_HAVE_DIAG
|
|
#pragma GCC diagnostic pop
|
|
#endif
|