mirror of
https://github.com/open-goal/jak-project
synced 2026-09-12 20:56:09 -04:00
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
165 lines
5.5 KiB
C
Vendored
Generated
165 lines
5.5 KiB
C
Vendored
Generated
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "unitcheck.h"
|
|
#include "urldata.h"
|
|
#include "curl_trc.h"
|
|
|
|
/*
|
|
* This test hardcodes the knowledge of the buffer size which is internal to
|
|
* Curl_infof(). If that buffer is changed in size, this tests needs to be
|
|
* updated to still be valid.
|
|
*/
|
|
|
|
static char input[4096];
|
|
static char output[4096];
|
|
|
|
/*
|
|
* This debugf callback dumps the string into the static buffer
|
|
* for the unit test to inspect. Since we know that we are only dealing with
|
|
* text we can afford the luxury of skipping the type check here.
|
|
*/
|
|
static int debugf_cb(CURL *handle, curl_infotype type, char *buf, size_t size,
|
|
void *userptr)
|
|
{
|
|
(void)handle;
|
|
(void)type;
|
|
(void)userptr;
|
|
|
|
memset(output, '\0', sizeof(output));
|
|
memcpy(output, buf, size);
|
|
return 0;
|
|
}
|
|
|
|
static CURLcode t1652_setup(struct Curl_easy **easy)
|
|
{
|
|
CURLcode result = CURLE_OK;
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
*easy = curl_easy_init();
|
|
if(!*easy) {
|
|
curl_global_cleanup();
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
curl_easy_setopt(*easy, CURLOPT_DEBUGFUNCTION, debugf_cb);
|
|
curl_easy_setopt(*easy, CURLOPT_VERBOSE, 1L);
|
|
return result;
|
|
}
|
|
|
|
static void t1652_stop(struct Curl_easy *easy)
|
|
{
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
static int verify(const char *info, const char *two)
|
|
{
|
|
/* the 'info' one has a newline appended */
|
|
const char *nl = strchr(info, '\n');
|
|
if(!nl)
|
|
return 1; /* nope */
|
|
return strncmp(info, two, nl - info);
|
|
}
|
|
|
|
static CURLcode test_unit1652(const char *arg)
|
|
{
|
|
struct Curl_easy *easy;
|
|
|
|
UNITTEST_BEGIN(t1652_setup(&easy))
|
|
|
|
#if defined(CURL_HAVE_DIAG) && !defined(__clang__)
|
|
#pragma GCC diagnostic push
|
|
#pragma GCC diagnostic ignored "-Wformat" /* for GCC v5 to v8 */
|
|
#pragma GCC diagnostic ignored "-Wformat-zero-length"
|
|
#if __GNUC__ >= 7
|
|
#pragma GCC diagnostic ignored "-Wformat-overflow"
|
|
#endif
|
|
#endif
|
|
|
|
/* Injecting a simple short string via a format */
|
|
curl_msnprintf(input, sizeof(input), "Simple Test");
|
|
Curl_infof(easy, "%s", input);
|
|
fail_unless(verify(output, input) == 0, "Simple string test");
|
|
|
|
/* Injecting a few different variables with a format */
|
|
Curl_infof(easy, "%s %d testing %ld", input, 42, 43L);
|
|
fail_unless(verify(output, "Simple Test 42 testing 43\n") == 0,
|
|
"Format string");
|
|
|
|
/* Variations of empty strings */
|
|
Curl_infof(easy, "");
|
|
fail_unless(strlen(output) == 1, "Empty string");
|
|
Curl_infof(easy, "%s", (char *)NULL);
|
|
fail_unless(verify(output, "(nil)") == 0, "Passing NULL as string");
|
|
|
|
/* Note: libcurl's tracebuffer hold 2048 bytes, so the max strlen() we
|
|
* get out of it is 2047, since we need a \0 at the end.
|
|
* Curl_infof() in addition adds a \n at the end, making the effective
|
|
* output 2046 characters.
|
|
* Any input that long or longer is truncated, ending in '...\n'.
|
|
*/
|
|
|
|
/* A string long enough to not be truncated */
|
|
memset(input, '\0', sizeof(input));
|
|
memset(input, 'A', 2045);
|
|
Curl_infof(easy, "%s", input);
|
|
curl_mfprintf(stderr, "output len %zu: %s", strlen(output), output);
|
|
/* output is input + \n */
|
|
fail_unless(strlen(output) == 2046, "No truncation of infof input");
|
|
fail_unless(verify(output, input) == 0, "No truncation of infof input");
|
|
fail_unless(output[sizeof(output) - 1] == '\0',
|
|
"No truncation of infof input");
|
|
|
|
/* Over the limit without newline for truncation via '...' */
|
|
memset(input + 2045, 'A', 4);
|
|
Curl_infof(easy, "%s", input);
|
|
curl_mfprintf(stderr, "output len %zu: %s", strlen(output), output);
|
|
fail_unless(strlen(output) == 2047, "Truncation of infof input 1");
|
|
fail_unless(output[sizeof(output) - 1] == '\0',
|
|
"Truncation of infof input 1");
|
|
|
|
/* Over the limit with newline for truncation via '...' */
|
|
memset(input + 2045, 'A', 4);
|
|
memset(input + 2045 + 4, '\n', 1);
|
|
Curl_infof(easy, "%s", input);
|
|
curl_mfprintf(stderr, "output len %zu: %s", strlen(output), output);
|
|
fail_unless(strlen(output) == 2047, "Truncation of infof input 2");
|
|
fail_unless(output[sizeof(output) - 1] == '\0',
|
|
"Truncation of infof input 2");
|
|
|
|
/* Way over the limit for truncation via '...' */
|
|
memset(input, '\0', sizeof(input));
|
|
memset(input, 'A', sizeof(input) - 1);
|
|
Curl_infof(easy, "%s", input);
|
|
curl_mfprintf(stderr, "output len %zu: %s", strlen(output), output);
|
|
fail_unless(strlen(output) == 2047, "Truncation of infof input 3");
|
|
fail_unless(output[sizeof(output) - 1] == '\0',
|
|
"Truncation of infof input 3");
|
|
|
|
#if defined(CURL_HAVE_DIAG) && !defined(__clang__)
|
|
#pragma GCC diagnostic pop
|
|
#endif
|
|
|
|
UNITTEST_END(t1652_stop(easy))
|
|
}
|