mirror of
https://github.com/open-goal/jak-project
synced 2026-10-20 18:28:45 -04:00
Luminar Light
ed028a4e8a
Some months ago I noticed that I wasn't seeing hint subtitles in TPL anymore. Specifically, I was seeing the speaker names, but not the subtitles themselves. I looked into it briefly back then and failed to find anything, so I assumed it was something wrong with my setup somehow. I have returned to the issue, and managed to fix it. Now I consistently see all subtitles, as I should. I always had the subtitles in the other games working fine, and after my fix I still see them. Before: <img width="1920" height="1080" alt="2026-10-10T16-10-59" src="https://github.com/user-attachments/assets/63a417fb-2f37-4950-a0ba-b9f28b02cae0" /> After: <img width="1920" height="1080" alt="2026-10-10T16-58-55" src="https://github.com/user-attachments/assets/4e58b34b-a253-458b-8be0-877c73767c3b" /> The fix was to provide default values in the subtitle metadata structs. I remember that c++ fields/structs can end up having garbage data if you don't provide values yourself, and this is probably also influenced by the build config and maybe the PC itself. Anyway, with these changes, it should always be good now regardless of who or what builds the project (I usually use the Release msvc build config because Release clang has a history of failing me). Maybe it is worth mentioning that I always play with the setting that forces speaker name to appear at all times. Not sure if relevant. I have also discovered that the reload-subtitles feature of Jak 1 was not working anymore, so I have made some adjustments and now it is working fine. While my solution fixed my issue, it is possible that it is not the right way. The c++ language is not a language I am very experienced with, so if my solution is unprofessional, please let me know and tell me how I should approach it instead. But I am certain that the issue is with field initialization somehow, and this is one way to fix that. EDIT: Worth mentioning that I properly see all subtitles in current latest OpenGOAL (launcher v2.11.2, tooling v0.3.8), which further reinforces the idea that it is some fields that get unpredictable values, influenced by the build config or build device. My issue is only when I build the project myself. And it may impact other people, or it may become an issue for official OpenGOAL too in the future.