mirror of
https://github.com/open-goal/jak-project
synced 2026-09-07 03:30:01 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
333 lines
9.2 KiB
CMake
Vendored
Generated
333 lines
9.2 KiB
CMake
Vendored
Generated
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
# Based on CI runs for Cygwin/MSYS2, Linux, macOS/iOS, DragonFly BSD, FreeBSD, MidnightBSD, NetBSD, OpenBSD
|
|
if(NOT UNIX)
|
|
message(FATAL_ERROR "This file should be included on Unix platforms only")
|
|
endif()
|
|
|
|
if(APPLE OR
|
|
CYGWIN)
|
|
set(HAVE_ACCEPT4 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_ACCEPT4 1)
|
|
endif()
|
|
set(HAVE_ALARM 1)
|
|
if(ANDROID)
|
|
set(HAVE_ARC4RANDOM 1)
|
|
else()
|
|
set(HAVE_ARC4RANDOM 0)
|
|
endif()
|
|
set(HAVE_ARPA_INET_H 1)
|
|
set(HAVE_ATOMIC 1)
|
|
set(HAVE_BASENAME 1)
|
|
set(HAVE_BOOL_T 1)
|
|
if(NOT APPLE)
|
|
set(HAVE_CLOCK_GETTIME_MONOTONIC 1)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
set(HAVE_CLOCK_GETTIME_MONOTONIC_RAW 1)
|
|
else()
|
|
set(HAVE_CLOCK_GETTIME_MONOTONIC_RAW 0)
|
|
endif()
|
|
endif()
|
|
set(HAVE_CLOSESOCKET 0)
|
|
set(HAVE_DECL_FSEEKO 1)
|
|
set(HAVE_DIRENT_H 1)
|
|
if(APPLE OR
|
|
CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_EVENTFD 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
|
|
set(HAVE_EVENTFD 1)
|
|
endif()
|
|
if(ANDROID AND ANDROID_PLATFORM_LEVEL GREATER_EQUAL 34)
|
|
set(HAVE_MEMSET_EXPLICIT 1)
|
|
endif()
|
|
if((APPLE AND CMAKE_OSX_DEPLOYMENT_TARGET VERSION_GREATER_EQUAL 10.9) OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR # v6+
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR # v11.2+
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD") # v1.3+
|
|
set(HAVE_MEMSET_S 1)
|
|
elseif(NOT APPLE)
|
|
set(HAVE_MEMSET_S 0)
|
|
endif()
|
|
set(HAVE_FCNTL 1)
|
|
set(HAVE_FCNTL_H 1)
|
|
set(HAVE_FCNTL_O_NONBLOCK 1)
|
|
set(HAVE_FILE_OFFSET_BITS 1)
|
|
set(HAVE_FNMATCH 1)
|
|
set(HAVE_FREEADDRINFO 1)
|
|
set(HAVE_FSEEKO 1)
|
|
if(APPLE)
|
|
set(HAVE_FSETXATTR 1)
|
|
set(HAVE_FSETXATTR_5 0)
|
|
set(HAVE_FSETXATTR_6 1)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_FSETXATTR 0)
|
|
set(HAVE_FSETXATTR_5 0)
|
|
set(HAVE_FSETXATTR_6 0)
|
|
elseif(CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
|
|
set(HAVE_FSETXATTR 1)
|
|
set(HAVE_FSETXATTR_5 1)
|
|
set(HAVE_FSETXATTR_6 0)
|
|
endif()
|
|
set(HAVE_GETADDRINFO 1)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_GETADDRINFO_THREADSAFE 0)
|
|
elseif(CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
|
|
set(HAVE_GETADDRINFO_THREADSAFE 1)
|
|
endif()
|
|
set(HAVE_GETEUID 1)
|
|
if(APPLE OR
|
|
CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_GETHOSTBYNAME_R 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD")
|
|
set(HAVE_GETHOSTBYNAME_R 1)
|
|
endif()
|
|
set(HAVE_GETHOSTBYNAME_R_3 0)
|
|
set(HAVE_GETHOSTBYNAME_R_3_REENTRANT 0)
|
|
set(HAVE_GETHOSTBYNAME_R_5 0)
|
|
set(HAVE_GETHOSTBYNAME_R_5_REENTRANT 0)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD")
|
|
set(HAVE_GETHOSTBYNAME_R_6 1)
|
|
set(HAVE_GETHOSTBYNAME_R_6_REENTRANT 1)
|
|
else()
|
|
set(HAVE_GETHOSTBYNAME_R_6 0)
|
|
set(HAVE_GETHOSTBYNAME_R_6_REENTRANT 0)
|
|
endif()
|
|
set(HAVE_GETHOSTNAME 1)
|
|
if(NOT ANDROID OR ANDROID_PLATFORM_LEVEL GREATER_EQUAL 24)
|
|
set(HAVE_GETIFADDRS 1)
|
|
else()
|
|
set(HAVE_GETIFADDRS 0)
|
|
endif()
|
|
if(APPLE OR
|
|
CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_GETPASS_R 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
|
|
set(HAVE_GETPASS_R 1)
|
|
endif()
|
|
set(HAVE_GETPEERNAME 1)
|
|
set(HAVE_GETPPID 1)
|
|
set(HAVE_GETPWUID 1)
|
|
set(HAVE_GETPWUID_R 1)
|
|
set(HAVE_GETRLIMIT 1)
|
|
set(HAVE_GETSOCKNAME 1)
|
|
set(HAVE_GETTIMEOFDAY 1)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
# Depends on C library.
|
|
else()
|
|
set(HAVE_GLIBC_STRERROR_R 0)
|
|
endif()
|
|
set(HAVE_GMTIME_R 1)
|
|
set(HAVE_IFADDRS_H 1)
|
|
set(HAVE_IF_NAMETOINDEX 1)
|
|
set(HAVE_INET_NTOP 1)
|
|
set(HAVE_INET_PTON 1)
|
|
set(HAVE_IOCTLSOCKET 0)
|
|
set(HAVE_IOCTLSOCKET_CAMEL 0)
|
|
set(HAVE_IOCTLSOCKET_CAMEL_FIONBIO 0)
|
|
set(HAVE_IOCTLSOCKET_FIONBIO 0)
|
|
set(HAVE_IOCTL_FIONBIO 1)
|
|
set(HAVE_IOCTL_SIOCGIFADDR 1)
|
|
if(CYGWIN)
|
|
set(HAVE_IO_H 1)
|
|
else()
|
|
set(HAVE_IO_H 0)
|
|
endif()
|
|
set(HAVE_LIBGEN_H 1)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
# Requires Linux kernel userspace headers. Expected with glibc. May be missing by default with MUSL.
|
|
else()
|
|
set(HAVE_LINUX_TCP_H 0)
|
|
endif()
|
|
set(HAVE_LOCALE_H 1)
|
|
set(HAVE_LOCALTIME_R 1)
|
|
if(APPLE)
|
|
set(HAVE_MACH_ABSOLUTE_TIME 1)
|
|
endif()
|
|
if(APPLE OR
|
|
CYGWIN)
|
|
set(HAVE_MEMRCHR 0)
|
|
else()
|
|
set(HAVE_MEMRCHR 1)
|
|
endif()
|
|
set(HAVE_NETDB_H 1)
|
|
if(ANDROID)
|
|
set(HAVE_NETINET_IN6_H 1)
|
|
else()
|
|
set(HAVE_NETINET_IN6_H 0)
|
|
endif()
|
|
set(HAVE_NETINET_IN_H 1)
|
|
set(HAVE_NETINET_TCP_H 1)
|
|
set(HAVE_NETINET_UDP_H 1)
|
|
set(HAVE_NET_IF_H 1)
|
|
set(HAVE_OPENDIR 1)
|
|
set(HAVE_PIPE 1)
|
|
if(APPLE OR
|
|
CYGWIN)
|
|
set(HAVE_PIPE2 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
BSD OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "SunOS")
|
|
set(HAVE_PIPE2 1)
|
|
endif()
|
|
set(HAVE_POLL 1)
|
|
set(HAVE_POLL_H 1)
|
|
if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
# Depends on C library.
|
|
else()
|
|
set(HAVE_POSIX_STRERROR_R 1)
|
|
endif()
|
|
set(HAVE_PWD_H 1)
|
|
set(HAVE_REALPATH 1)
|
|
set(HAVE_RECV 1)
|
|
set(HAVE_SA_FAMILY_T 1)
|
|
set(HAVE_SCHED_YIELD 1)
|
|
set(HAVE_SELECT 1)
|
|
set(HAVE_SEND 1)
|
|
if(APPLE OR
|
|
CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD")
|
|
set(HAVE_SENDMMSG 0)
|
|
else()
|
|
set(HAVE_SENDMMSG 1)
|
|
endif()
|
|
set(HAVE_SENDMSG 1)
|
|
set(HAVE_SETLOCALE 1)
|
|
set(HAVE_SETRLIMIT 1)
|
|
set(HAVE_SETSOCKOPT_SO_NONBLOCK 0)
|
|
set(HAVE_SIGACTION 1)
|
|
set(HAVE_SIGINTERRUPT 1)
|
|
set(HAVE_SIGNAL 1)
|
|
set(HAVE_SIGSETJMP 1)
|
|
set(HAVE_SOCKADDR_IN6_SIN6_ADDR 1)
|
|
set(HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID 1)
|
|
set(HAVE_SOCKET 1)
|
|
set(HAVE_SOCKETPAIR 1)
|
|
set(HAVE_STDATOMIC_H 1)
|
|
set(HAVE_STDBOOL_H 1)
|
|
set(HAVE_STDDEF_H 1) # detected by CMake internally in check_type_size()
|
|
set(HAVE_STDINT_H 1) # detected by CMake internally in check_type_size()
|
|
set(HAVE_STRCASECMP 1)
|
|
set(HAVE_STRCMPI 0)
|
|
set(HAVE_STRERROR_R 1)
|
|
set(HAVE_STRICMP 0)
|
|
set(HAVE_STRINGS_H 1)
|
|
if(_CURL_OLD_LINUX)
|
|
set(HAVE_STROPTS_H 1)
|
|
else()
|
|
set(HAVE_STROPTS_H 0) # glibc 2.30 or newer. https://sourceware.org/legacy-ml/libc-alpha/2019-08/msg00029.html
|
|
endif()
|
|
set(HAVE_STRUCT_SOCKADDR_STORAGE 1)
|
|
set(HAVE_STRUCT_TIMEVAL 1)
|
|
if(ANDROID OR CMAKE_SYSTEM_NAME STREQUAL "iOS")
|
|
set(HAVE_SUSECONDS_T 1)
|
|
endif()
|
|
if(APPLE OR
|
|
CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "DragonFlyBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "OpenBSD")
|
|
set(HAVE_SYS_EVENTFD_H 0)
|
|
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "FreeBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "MidnightBSD" OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "NetBSD")
|
|
set(HAVE_SYS_EVENTFD_H 1)
|
|
endif()
|
|
if(CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
set(HAVE_SYS_FILIO_H 0)
|
|
else()
|
|
set(HAVE_SYS_FILIO_H 1)
|
|
endif()
|
|
set(HAVE_SYS_IOCTL_H 1)
|
|
set(HAVE_SYS_PARAM_H 1)
|
|
set(HAVE_SYS_POLL_H 1)
|
|
set(HAVE_SYS_RESOURCE_H 1)
|
|
set(HAVE_SYS_SELECT_H 1)
|
|
if(CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
set(HAVE_SYS_SOCKIO_H 0)
|
|
else()
|
|
set(HAVE_SYS_SOCKIO_H 1)
|
|
endif()
|
|
set(HAVE_SYS_TYPES_H 1)
|
|
set(HAVE_SYS_UN_H 1)
|
|
if(CYGWIN)
|
|
set(HAVE_SYS_UTIME_H 1)
|
|
else()
|
|
set(HAVE_SYS_UTIME_H 0)
|
|
endif()
|
|
set(HAVE_TERMIOS_H 1)
|
|
if(CYGWIN OR
|
|
CMAKE_SYSTEM_NAME STREQUAL "Linux")
|
|
set(HAVE_TERMIO_H 1)
|
|
else()
|
|
set(HAVE_TERMIO_H 0)
|
|
endif()
|
|
set(HAVE_TIME_T_UNSIGNED 0)
|
|
set(HAVE_UNISTD_H 1)
|
|
set(HAVE_UTIME 1)
|
|
set(HAVE_UTIMES 1)
|
|
set(HAVE_UTIME_H 1)
|
|
set(HAVE_WRITABLE_ARGV 1)
|
|
set(STDC_HEADERS 1)
|
|
set(USE_UNIX_SOCKETS 1)
|