Files
Alexander J. Semenuk 5d5e35fb9b fix: Windows toolchain compatibility (curl 8.21 re-vendor, endless reconfigure loop) (#4355)
## Problem

Windows builds break with a current local toolchain (Scoop LLVM 22.1.8,
CMake 4.4.0, VS 2026), in two independent ways:

1. The build stops at curl's deliberate guard: `#error "no non-blocking
method was found/used/set"` in `third-party/curl/lib/nonblock.c`.
2. From the second configure onward, `cmake --build` re-runs CMake in an
endless loop (observed 42 consecutive reconfigure cycles in a single
build). Likely the same mechanism behind the "endlessly building" VS
2026 note in `docs/setup/dev/vs.md`.

## Root cause

1. `third-party/curl/CMake/CurlTests.c` passes `int *` to
`ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes
`-Wincompatible-pointer-types` to a hard error in C, so the
`HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and
`curl_config.h` never defines it. Upstream CI does not see this because
the windows-2022 runner image ships an older LLVM. GCC 14 promotes the
same warning to a hard error, which is very likely the `CurlTests.c.obj`
failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl
hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0
(curl/curl#13578).
2. The root CMakeLists copies the build tree's `compile_commands.json`
into `<src>/build/` for clangd using `configure_file()`, which registers
its input as a configure dependency. CMake rewrites
`compile_commands.json` late in every generation, after
`CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same
Ninja regen rule), so once the dependency is registered the rule is
deterministically dirty and every `ninja` invocation re-runs CMake. A
pristine first configure is safe (the file does not exist yet, so the
`if(EXISTS ...)` guard skips the copy), which is why the loop looks
machine- or IDE-specific.

## Fix

1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag
(previously `curl-8_3_0`), which carries the upstream probe fix plus two
years of upstream development; `vendor.yaml` updated to match.
Adjustments the version jump forced:
- curl 8.15 removed the native macOS Secure Transport backend
(`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like
Linux. The two macOS workflows install Homebrew `openssl@3` and export
`OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same
two lines.
- `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10;
pinned OFF to keep the previous no-compression behavior and avoid
silently linking whatever the CI images happen to have.
- curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked
into discord-rpc's identically named option and broke configure at a
nonexistent `examples/send-presence` directory; pinned OFF ahead of the
third-party subdirectories.

The diff is dominated by the mechanical tag-tree swap under
`third-party/curl` (linguist-vendored, collapsed in review). The
hand-written changes are `CMakeLists.txt`, the two macOS workflows,
`docs/setup/system/macos.md`, and `vendor.yaml`.
2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy
with no configure dependency registered. (`file(COPY_FILE ...
ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21,
above the declared `cmake_minimum_required(VERSION 3.10)`.)

## Test plan

- [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache
seeding) completes and logs `Enabled SSL backends: Schannel`; the
FIONBIO probe passes without the previous `#error`
- [x] Full Windows Release build from scratch in the branch worktree
(all 1422 targets)
- [x] goalc-test suite: 1509 passed, 0 failed
- [x] Second consecutive configure with `compile_commands.json` present:
the regen rule in `build.ninja` has no `compile_commands.json` input;
`<src>/build/compile_commands.json` is still refreshed for clangd
- [x] Repeated `ninja` invocations after a full build no longer re-run
CMake
- [x] macOS Intel and ARM CI green (first exercise of the OpenSSL
backend switch)

---

I work off a self-hosted forge, so this GitHub account is quiet; the
configure logs and ninja dirty-node traces from the investigation are
available if anyone wants the raw data.

(AI-assisted)
2026-07-27 19:19:18 -04:00

4.9 KiB
Vendored
Generated

curldown

A markdown-like syntax for libcurl man pages.

Purpose

A text format for writing libcurl documentation in the shape of man pages.

Make it easier for users to contribute and write documentation. A format that is easier on the eye in its source format.

Make it harder to do syntactical mistakes.

Use a format that allows creating man pages that end up looking exactly like the man pages did when we wrote them in nroff format.

Take advantage of the fact that people these days are accustomed to markdown by using a markdown-like syntax.

This allows us to fix issues in the nroff format easier since now we generate them. For example: escaping minus to prevent them from being turned into Unicode by man.

Generate nroff output that looks (next to) identical to the previous files, so that the look, existing test cases, HTML conversions, existing infrastructure etc remain mostly intact.

Contains meta-data in a structured way to allow better output (for example the see also information) and general awareness of what the file is about.

File extension

Since curldown looks similar to markdown, we use .md extensions on the files.

Conversion

Convert from curldown to nroff with cd2nroff. Generates nroff man pages.

Convert from nroff to curldown with nroff2cd. This is only meant to be used for the initial conversion to curldown and should ideally never be needed again.

Convert, check or clean up an existing curldown to nicer, better, cleaner curldown with cd2cd.

Mass-convert all curldown files to nroff in specified directories with cdall:

cdall [dir1] [dir2] [dir3] ..

Known issues

The cd2nroff tool does not yet handle italics or bold where the start and the end markers are used on separate lines.

The nroff2cd tool generates code style quotes for all .fi sections since the nroff format does not carry a distinction.

Format

Each curldown starts with a header with meta-data:

---
c: Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
SPDX-License-Identifier: curl
Title: CURLOPT_AWS_SIGV4
Section: 3
Source: libcurl
Protocol:
  - HTTP
See-also:
  - CURLOPT_HEADEROPT (3)
  - CURLOPT_HTTPAUTH (3)
TLS-backend:
  - [name]
Added-in: [version or "n/a"]
---

All curldown files must have all the headers present and at least one See-also: entry specified.

If the man page is for section 3 (library related). The Protocol list must contain at least one protocol, which can be * if the option is virtually for everything. If * is used, it must be the only listed protocol. Recognized protocols are either URL schemes (in uppercase), TLS or TCP.

If the Protocol list contains TLS, then there must also be a TLS-backend list, specifying All or a list of what TLS backends that work with this option. The available TLS backends are:

  • GnuTLS
  • mbedTLS
  • OpenSSL (also covers AmiSSL, AWS-LC, BoringSSL, LibreSSL and quictls)
  • rustls
  • Schannel
  • wolfSSL
  • All: all TLS backends

Following the header in the file, is the manual page using markdown-like syntax:

    # NAME
    a page - this is a page describing something

    # SYNOPSIS
    ~~~c
    #include <curl/curl.h>

    CURLcode curl_easy_setopt(CURL *handle, CURLOPT_AWS_SIGV4, char *param);
    ~~~

Quoted source code should start with ~~~c and end with ~~~ while regular quotes can start with ~~~ or be indented with 4 spaces.

Headers at top-level # get converted to .SH.

nroff2cd supports the ## next level header which gets converted to .IP.

Write bold words or phrases within ** like:

This is a **bold** word.

Write italics like:

This is *italics*.

Due to how man pages do not support backticks especially formatted, such occurrences in the source are instead using italics in the generated output:

This `word` appears in italics.

When generating the nroff output, the tooling removes superfluous newlines, meaning they can be used freely in the source file to make the text more readable.

To make sure curldown documents render correctly as markdown, all literal occurrences of < or > need to be escaped by a leading backslash.

Generating contents

# %PROTOCOLS% - inserts a PROTOCOLS section based on the metadata provided in the header.

# %AVAILABILITY% - inserts an AVAILABILITY section based on the metadata provided in the header.

Symbols

All mentioned curl symbols that have their own man pages, like curl_easy_perform(3) are automatically rendered using italics in the output without having to enclose it with asterisks. This helps ensuring that they get converted to links properly later in the HTML version on the website, as converted with roffit. This makes the curldown text easier to read even when mentioning many curl symbols.

This auto-linking works for patterns matching (lib|)curl[^ ]*(3).