Files
Alexander J. Semenuk 5d5e35fb9b fix: Windows toolchain compatibility (curl 8.21 re-vendor, endless reconfigure loop) (#4355)
## Problem

Windows builds break with a current local toolchain (Scoop LLVM 22.1.8,
CMake 4.4.0, VS 2026), in two independent ways:

1. The build stops at curl's deliberate guard: `#error "no non-blocking
method was found/used/set"` in `third-party/curl/lib/nonblock.c`.
2. From the second configure onward, `cmake --build` re-runs CMake in an
endless loop (observed 42 consecutive reconfigure cycles in a single
build). Likely the same mechanism behind the "endlessly building" VS
2026 note in `docs/setup/dev/vs.md`.

## Root cause

1. `third-party/curl/CMake/CurlTests.c` passes `int *` to
`ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes
`-Wincompatible-pointer-types` to a hard error in C, so the
`HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and
`curl_config.h` never defines it. Upstream CI does not see this because
the windows-2022 runner image ships an older LLVM. GCC 14 promotes the
same warning to a hard error, which is very likely the `CurlTests.c.obj`
failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl
hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0
(curl/curl#13578).
2. The root CMakeLists copies the build tree's `compile_commands.json`
into `<src>/build/` for clangd using `configure_file()`, which registers
its input as a configure dependency. CMake rewrites
`compile_commands.json` late in every generation, after
`CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same
Ninja regen rule), so once the dependency is registered the rule is
deterministically dirty and every `ninja` invocation re-runs CMake. A
pristine first configure is safe (the file does not exist yet, so the
`if(EXISTS ...)` guard skips the copy), which is why the loop looks
machine- or IDE-specific.

## Fix

1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag
(previously `curl-8_3_0`), which carries the upstream probe fix plus two
years of upstream development; `vendor.yaml` updated to match.
Adjustments the version jump forced:
- curl 8.15 removed the native macOS Secure Transport backend
(`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like
Linux. The two macOS workflows install Homebrew `openssl@3` and export
`OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same
two lines.
- `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10;
pinned OFF to keep the previous no-compression behavior and avoid
silently linking whatever the CI images happen to have.
- curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked
into discord-rpc's identically named option and broke configure at a
nonexistent `examples/send-presence` directory; pinned OFF ahead of the
third-party subdirectories.

The diff is dominated by the mechanical tag-tree swap under
`third-party/curl` (linguist-vendored, collapsed in review). The
hand-written changes are `CMakeLists.txt`, the two macOS workflows,
`docs/setup/system/macos.md`, and `vendor.yaml`.
2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy
with no configure dependency registered. (`file(COPY_FILE ...
ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21,
above the declared `cmake_minimum_required(VERSION 3.10)`.)

## Test plan

- [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache
seeding) completes and logs `Enabled SSL backends: Schannel`; the
FIONBIO probe passes without the previous `#error`
- [x] Full Windows Release build from scratch in the branch worktree
(all 1422 targets)
- [x] goalc-test suite: 1509 passed, 0 failed
- [x] Second consecutive configure with `compile_commands.json` present:
the regen rule in `build.ninja` has no `compile_commands.json` input;
`<src>/build/compile_commands.json` is still refreshed for clangd
- [x] Repeated `ninja` invocations after a full build no longer re-run
CMake
- [x] macOS Intel and ARM CI green (first exercise of the OpenSSL
backend switch)

---

I work off a self-hosted forge, so this GitHub account is quiet; the
configure logs and ninja dirty-node traces from the investigation are
available if anyone wants the raw data.

(AI-assisted)
2026-07-27 19:19:18 -04:00

5.4 KiB
Vendored
Generated

c, SPDX-License-Identifier, Title, Section, Source, See-also, Protocol, Added-in
c SPDX-License-Identifier Title Section Source See-also Protocol Added-in
Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al. curl CURLOPT_FOLLOWLOCATION 3 libcurl
CURLINFO_REDIRECT_COUNT (3)
CURLINFO_REDIRECT_URL (3)
CURLOPT_POSTREDIR (3)
CURLOPT_PROTOCOLS_STR (3)
CURLOPT_REDIR_PROTOCOLS_STR (3)
CURLOPT_UNRESTRICTED_AUTH (3)
HTTP
7.1

NAME

CURLOPT_FOLLOWLOCATION - follow HTTP 3xx redirects

SYNOPSIS

#include <curl/curl.h>

CURLcode curl_easy_setopt(CURL *handle, CURLOPT_FOLLOWLOCATION, long mode);

DESCRIPTION

This option tells the library to follow Location: header redirects that an HTTP server sends in a 30x response. The Location: header can specify a relative or an absolute URL to follow. The long parameter mode instructs how libcurl should act on subsequent requests.

mode only had a single value (1L) for a long time that enables redirect following. Since 8.13.0, two additional modes are also supported. See below.

When following redirects, libcurl issues another request for the new URL and follows subsequent new Location: redirects all the way until no more such headers are returned or the maximum limit is reached. CURLOPT_MAXREDIRS(3) is used to limit the number of redirects libcurl follows.

libcurl restricts what protocols it automatically follow redirects to. The accepted target protocols are set with CURLOPT_REDIR_PROTOCOLS_STR(3). By default libcurl allows HTTP, HTTPS, FTP and FTPS on redirects.

When following a redirect, the specific 30x response code also dictates which request method libcurl uses in the subsequent request: For 301, 302 and 303 responses libcurl switches method from POST to GET unless CURLOPT_POSTREDIR(3) instructs libcurl otherwise. All other redirect response codes make libcurl use the same method again.

When libcurl switches method to GET, it then uses that method without sending any request body. If it does not change the method, it sends the subsequent request the same way as the previous one; including the request body if one was provided.

For users who think the existing location following is too naive, too simple or lacking features, it is easy to instead implement your own redirect follow logic with the use of curl_easy_getinfo(3)'s CURLINFO_REDIRECT_URL(3) option instead of using CURLOPT_FOLLOWLOCATION(3).

By default, libcurl only sends Authorization: or explicitly set Cookie: headers to the initial host given in the original URL, to avoid leaking username + password to other sites. CURLOPT_UNRESTRICTED_AUTH(3) is provided to change that behavior.

Due to the way HTTP works, almost any header can be made to contain data a client may not want to pass on to other servers than the initially intended host and for all other headers than the two mentioned above, there is no protection from this happening when libcurl is told to follow redirects.

Pick one of the following modes:

CURLFOLLOW_ALL (1)

Before 8.13.0 this bit had no name and 1L was the value to enable this option. This makes a set custom method be used in all HTTP requests, even after redirects.

CURLFOLLOW_OBEYCODE (2)

When there is a custom request method set with CURLOPT_CUSTOMREQUEST(3), that set method replaces what libcurl would otherwise use. If a 301/302/303 response code is returned to signal a redirect, the method is changed from POST to GET. For 307/308, the custom method remains set and used.

Note that only POST (or a custom post) is changed to GET on 301/302, its not change PUT etc - and therefore also not when libcurl issues a custom PUT. A 303 response makes it switch to GET independently of the original method (except for HEAD).

To control for which of the 301/302/303 status codes libcurl should not switch back to GET for when doing a custom POST (a POST transfer using a modified method), and instead keep the custom method, use CURLOPT_POSTREDIR(3).

If you prefer a custom POST method to be reset to exactly the method POST, use CURLFOLLOW_FIRSTONLY instead.

CURLFOLLOW_FIRSTONLY (3)

When there is a custom request method set with CURLOPT_CUSTOMREQUEST(3), that set method replaces what libcurl would otherwise use in the first outgoing request only. The second request is then done according to the redirect response code.

If you prefer your custom method to remain in use after a 307/308 redirect, use CURLFOLLOW_OBEYCODE instead.

NOTE

Since libcurl changes method or not based on the specific HTTP response code, setting CURLOPT_CUSTOMREQUEST(3) while following redirects may change what libcurl would otherwise do and if not that carefully may even make it misbehave since CURLOPT_CUSTOMREQUEST(3) overrides the method libcurl would otherwise select internally.

Setting the CURLFOLLOW_OBEYCODE bit makes libcurl not use the custom set method after redirects for 301, 302 and 303 responses. Unless the CURLOPT_POSTREDIR(3) bits are set for those status codes.

DEFAULT

0, disabled

%PROTOCOLS%

EXAMPLE

int main(void)
{
  CURL *curl = curl_easy_init();
  if(curl) {
    CURLcode result;
    curl_easy_setopt(curl, CURLOPT_URL, "https://example.com");

    /* example.com is redirected, so we tell libcurl to follow redirection */
    curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);

    result = curl_easy_perform(curl);
    curl_easy_cleanup(curl);
  }
}

%AVAILABILITY%

RETURN VALUE

curl_easy_setopt(3) returns a CURLcode indicating success or error.

CURLE_OK (0) means everything was OK, non-zero means an error occurred, see libcurl-errors(3).