mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-08-28 00:41:58 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
master
jak-project/third-party/curl/projects/vms/curlmsg.sdl
T
Alexander J. Semenuk 5d5e35fb9b fix: Windows toolchain compatibility (curl 8.21 re-vendor, endless reconfigure loop) (#4355) 
## Problem

Windows builds break with a current local toolchain (Scoop LLVM 22.1.8,
CMake 4.4.0, VS 2026), in two independent ways:

1. The build stops at curl's deliberate guard: `#error "no non-blocking
method was found/used/set"` in `third-party/curl/lib/nonblock.c`.
2. From the second configure onward, `cmake --build` re-runs CMake in an
endless loop (observed 42 consecutive reconfigure cycles in a single
build). Likely the same mechanism behind the "endlessly building" VS
2026 note in `docs/setup/dev/vs.md`.

## Root cause

1. `third-party/curl/CMake/CurlTests.c` passes `int *` to
`ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes
`-Wincompatible-pointer-types` to a hard error in C, so the
`HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and
`curl_config.h` never defines it. Upstream CI does not see this because
the windows-2022 runner image ships an older LLVM. GCC 14 promotes the
same warning to a hard error, which is very likely the `CurlTests.c.obj`
failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl
hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0
(curl/curl#13578).
2. The root CMakeLists copies the build tree's `compile_commands.json`
into `<src>/build/` for clangd using `configure_file()`, which registers
its input as a configure dependency. CMake rewrites
`compile_commands.json` late in every generation, after
`CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same
Ninja regen rule), so once the dependency is registered the rule is
deterministically dirty and every `ninja` invocation re-runs CMake. A
pristine first configure is safe (the file does not exist yet, so the
`if(EXISTS ...)` guard skips the copy), which is why the loop looks
machine- or IDE-specific.

## Fix

1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag
(previously `curl-8_3_0`), which carries the upstream probe fix plus two
years of upstream development; `vendor.yaml` updated to match.
Adjustments the version jump forced:
- curl 8.15 removed the native macOS Secure Transport backend
(`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like
Linux. The two macOS workflows install Homebrew `openssl@3` and export
`OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same
two lines.
- `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10;
pinned OFF to keep the previous no-compression behavior and avoid
silently linking whatever the CI images happen to have.
- curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked
into discord-rpc's identically named option and broke configure at a
nonexistent `examples/send-presence` directory; pinned OFF ahead of the
third-party subdirectories.

The diff is dominated by the mechanical tag-tree swap under
`third-party/curl` (linguist-vendored, collapsed in review). The
hand-written changes are `CMakeLists.txt`, the two macOS workflows,
`docs/setup/system/macos.md`, and `vendor.yaml`.
2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy
with no configure dependency registered. (`file(COPY_FILE ...
ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21,
above the declared `cmake_minimum_required(VERSION 3.10)`.)

## Test plan

- [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache
seeding) completes and logs `Enabled SSL backends: Schannel`; the
FIONBIO probe passes without the previous `#error`
- [x] Full Windows Release build from scratch in the branch worktree
(all 1422 targets)
- [x] goalc-test suite: 1509 passed, 0 failed
- [x] Second consecutive configure with `compile_commands.json` present:
the regen rule in `build.ninja` has no `compile_commands.json` input;
`<src>/build/compile_commands.json` is still refreshed for clangd
- [x] Repeated `ninja` invocations after a full build no longer re-run
CMake
- [x] macOS Intel and ARM CI green (first exercise of the OpenSSL
backend switch)

---

I work off a self-hosted forge, so this GitHub account is quiet; the
configure logs and ninja dirty-node traces from the investigation are
available if anyone wants the raw data.

(AI-assisted)
2026-07-27 19:19:18 -04:00

117 lines
6.8 KiB
Plaintext
Vendored
Generated
Raw Permalink Blame History

MODULE $CURDEF;
/*
/* This SDL File Generated by VAX-11 Message V04-00 on 3-SEP-2008 13:33:54.09
/*
/* $ID: CURLMSG.MSG,V 1.7 2008-05-30 23:51:09 CURLVMS EXP $
/*
/* THESE VMS ERROR CODES ARE GENERATED BY TAKING APART THE CURL.H
/* FILE AND PUTTING ALL THE CURLE_* ENUM STUFF INTO THIS FILE,
/* CURLMSG.MSG. AN .SDL FILE IS CREATED FROM THIS FILE WITH
/* MESSAGE/SDL. THE .H FILE IS CREATED USING THE FREEWARE SDL TOOL
/* AGAINST THE .SDL FILE WITH SDL/ALPHA/LANG=CC COMMAND.
/*
/* WITH THE EXCEPTION OF CURLE_OK, ALL OF THE MESSAGES ARE AT
/* THE ERROR SEVERITY LEVEL. WITH THE EXCEPTION OF
/* PEER_FAILED_VERIF, WHICH IS A SHORTENED FORM OF
/* PEER_FAILED_VERIFICATION, THESE ARE THE SAME NAMES AS THE
/* CURLE_ ONES IN INCLUDE/CURL.H. THE MESSAGE UTILITY MANUAL STATES
/* "THE COMBINED LENGTH OF THE PREFIX AND THE MESSAGE SYMBOL NAME CANNOT
/* EXCEED 31 CHARACTERS." WITH A PREFIX OF FIVE THAT LEAVES US WITH 26
/* FOR THE MESSAGE NAME.
/*
/* IF YOU UPDATE THIS FILE ALSO UPDATE CURLMSG_VMS.H SO THAT THEY ARE IN SYNC
/*
CONSTANT
"FACILITY" EQUALS 3841 PREFIX "CURL" TAG ""
,"OK" EQUALS %X0F018009 PREFIX "CURL" TAG ""
,"UNSUPPORTED_PROTOCOL" EQUALS %X0F018012 PREFIX "CURL" TAG ""
,"FAILED_INIT" EQUALS %X0F01801A PREFIX "CURL" TAG ""
,"URL_MALFORMAT" EQUALS %X0F018022 PREFIX "CURL" TAG ""
,"OBSOLETE4" EQUALS %X0F01802A PREFIX "CURL" TAG ""
,"COULDNT_RESOLVE_PROXY" EQUALS %X0F018032 PREFIX "CURL" TAG ""
,"COULDNT_RESOLVE_HOST" EQUALS %X0F01803A PREFIX "CURL" TAG ""
,"COULDNT_CONNECT" EQUALS %X0F018042 PREFIX "CURL" TAG ""
,"WEIRD_SERVER_REPLY" EQUALS %X0F01804A PREFIX "CURL" TAG ""
,"FTP_WEIRD_SERVER_REPLY" EQUALS %X0F01804A PREFIX "CURL" TAG ""
,"FTP_ACCESS_DENIED" EQUALS %X0F018052 PREFIX "CURL" TAG ""
,"OBSOLETE10" EQUALS %X0F01805A PREFIX "CURL" TAG ""
,"FTP_WEIRD_PASS_REPLY" EQUALS %X0F018062 PREFIX "CURL" TAG ""
,"OBSOLETE12" EQUALS %X0F01806A PREFIX "CURL" TAG ""
,"FTP_WEIRD_PASV_REPLY" EQUALS %X0F018072 PREFIX "CURL" TAG ""
,"FTP_WEIRD_227_FORMAT" EQUALS %X0F01807A PREFIX "CURL" TAG ""
,"FTP_CANT_GET_HOST" EQUALS %X0F018082 PREFIX "CURL" TAG ""
,"OBSOLETE16" EQUALS %X0F01808A PREFIX "CURL" TAG ""
,"FTP_COULDNT_SET_TYPE" EQUALS %X0F018092 PREFIX "CURL" TAG ""
,"PARTIAL_FILE" EQUALS %X0F01809A PREFIX "CURL" TAG ""
,"FTP_COULDNT_RETR_FILE" EQUALS %X0F0180A2 PREFIX "CURL" TAG ""
,"OBSOLETE20" EQUALS %X0F0180AA PREFIX "CURL" TAG ""
,"QUOTE_ERROR" EQUALS %X0F0180B2 PREFIX "CURL" TAG ""
,"HTTP_RETURNED_ERROR" EQUALS %X0F0180BA PREFIX "CURL" TAG ""
,"WRITE_ERROR" EQUALS %X0F0180C2 PREFIX "CURL" TAG ""
,"OBSOLETE24" EQUALS %X0F0180CA PREFIX "CURL" TAG ""
,"UPLOAD_FAILED" EQUALS %X0F0180D2 PREFIX "CURL" TAG ""
,"READ_ERROR" EQUALS %X0F0180DA PREFIX "CURL" TAG ""
,"OUT_OF_MEMORY" EQUALS %X0F0180E2 PREFIX "CURL" TAG ""
,"OPERATION_TIMEOUTED" EQUALS %X0F0180EA PREFIX "CURL" TAG ""
,"OBSOLETE29" EQUALS %X0F0180F2 PREFIX "CURL" TAG ""
,"FTP_PORT_FAILED" EQUALS %X0F0180FA PREFIX "CURL" TAG ""
,"FTP_COULDNT_USE_REST" EQUALS %X0F018102 PREFIX "CURL" TAG ""
,"OBSOLETE32" EQUALS %X0F01810A PREFIX "CURL" TAG ""
,"RANGE_ERROR" EQUALS %X0F018112 PREFIX "CURL" TAG ""
,"HTTP_POST_ERROR" EQUALS %X0F01811A PREFIX "CURL" TAG ""
,"SSL_CONNECT_ERROR" EQUALS %X0F018122 PREFIX "CURL" TAG ""
,"BAD_DOWNLOAD_RESUME" EQUALS %X0F01812A PREFIX "CURL" TAG ""
,"FILE_COULDNT_READ_FILE" EQUALS %X0F018132 PREFIX "CURL" TAG ""
,"LDAP_CANNOT_BIND" EQUALS %X0F01813A PREFIX "CURL" TAG ""
,"LDAP_SEARCH_FAILED" EQUALS %X0F018142 PREFIX "CURL" TAG ""
,"OBSOLETE40" EQUALS %X0F01814A PREFIX "CURL" TAG ""
,"FUNCTION_NOT_FOUND" EQUALS %X0F018152 PREFIX "CURL" TAG ""
,"ABORTED_BY_CALLBACK" EQUALS %X0F01815A PREFIX "CURL" TAG ""
,"BAD_FUNCTION_ARGUMENT" EQUALS %X0F018162 PREFIX "CURL" TAG ""
,"OBSOLETE44" EQUALS %X0F01816A PREFIX "CURL" TAG ""
,"INTERFACE_FAILED" EQUALS %X0F018172 PREFIX "CURL" TAG ""
,"OBSOLETE46" EQUALS %X0F01817A PREFIX "CURL" TAG ""
,"TOO_MANY_REDIRECTS" EQUALS %X0F018182 PREFIX "CURL" TAG ""
,"UNKNOWN_TELNET_OPTION" EQUALS %X0F01818A PREFIX "CURL" TAG ""
,"TELNET_OPTION_SYNTAX" EQUALS %X0F018192 PREFIX "CURL" TAG ""
,"OBSOLETE50" EQUALS %X0F01819A PREFIX "CURL" TAG ""
,"PEER_FAILED_VERIF" EQUALS %X0F0181A2 PREFIX "CURL" TAG ""
,"GOT_NOTHING" EQUALS %X0F0181AA PREFIX "CURL" TAG ""
,"SSL_ENGINE_NOTFOUND" EQUALS %X0F0181B2 PREFIX "CURL" TAG ""
,"SSL_ENGINE_SETFAILED" EQUALS %X0F0181BA PREFIX "CURL" TAG ""
,"SEND_ERROR" EQUALS %X0F0181C2 PREFIX "CURL" TAG ""
,"RECV_ERROR" EQUALS %X0F0181CA PREFIX "CURL" TAG ""
,"OBSOLETE57" EQUALS %X0F0181D2 PREFIX "CURL" TAG ""
,"SSL_CERTPROBLEM" EQUALS %X0F0181DA PREFIX "CURL" TAG ""
,"SSL_CIPHER" EQUALS %X0F0181E2 PREFIX "CURL" TAG ""
,"SSL_CACERT" EQUALS %X0F0181EA PREFIX "CURL" TAG ""
,"BAD_CONTENT_ENCODING" EQUALS %X0F0181F2 PREFIX "CURL" TAG ""
,"LDAP_INVALID_URL" EQUALS %X0F0181FA PREFIX "CURL" TAG ""
,"FILESIZE_EXCEEDED" EQUALS %X0F018202 PREFIX "CURL" TAG ""
,"USE_SSL_FAILED" EQUALS %X0F01820A PREFIX "CURL" TAG ""
,"SEND_FAIL_REWIND" EQUALS %X0F018212 PREFIX "CURL" TAG ""
,"SSL_ENGINE_INITFAILED" EQUALS %X0F01821A PREFIX "CURL" TAG ""
,"LOGIN_DENIED" EQUALS %X0F018222 PREFIX "CURL" TAG ""
,"TFTP_NOTFOUND" EQUALS %X0F01822A PREFIX "CURL" TAG ""
,"TFTP_PERM" EQUALS %X0F018232 PREFIX "CURL" TAG ""
,"REMOTE_DISK_FULL" EQUALS %X0F01823A PREFIX "CURL" TAG ""
,"TFTP_ILLEGAL" EQUALS %X0F018242 PREFIX "CURL" TAG ""
,"TFTP_UNKNOWNID" EQUALS %X0F01824A PREFIX "CURL" TAG ""
,"REMOTE_FILE_EXISTS" EQUALS %X0F018252 PREFIX "CURL" TAG ""
,"TFTP_NOSUCHUSER" EQUALS %X0F01825A PREFIX "CURL" TAG ""
,"CONV_FAILED" EQUALS %X0F018262 PREFIX "CURL" TAG ""
,"CONV_REQD" EQUALS %X0F01826A PREFIX "CURL" TAG ""
,"SSL_CACERT_BADFILE" EQUALS %X0F018272 PREFIX "CURL" TAG ""
,"REMOTE_FILE_NOT_FOUND" EQUALS %X0F01827A PREFIX "CURL" TAG ""
,"SSH" EQUALS %X0F018282 PREFIX "CURL" TAG ""
,"SSL_SHUTDOWN_FAILED" EQUALS %X0F01828A PREFIX "CURL" TAG ""
,"AGAIN" EQUALS %X0F018292 PREFIX "CURL" TAG ""
,"SSL_CRL_BADFILE" EQUALS %X0F01829A PREFIX "CURL" TAG ""
,"SSL_ISSUER_ERROR" EQUALS %X0F0182A2 PREFIX "CURL" TAG ""
,"CURL_LAST" EQUALS %X0F0182AA PREFIX "CURL" TAG ""
;
END_MODULE;
Reference in New Issue View Git Blame Copy Permalink