mirror of
https://github.com/open-goal/jak-project
synced 2026-09-02 18:12:50 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
130 lines
3.9 KiB
C
Vendored
Generated
130 lines
3.9 KiB
C
Vendored
Generated
#ifndef HEADER_CURLMSG_VMS_H
|
|
#define HEADER_CURLMSG_VMS_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
/* */
|
|
/* CURLMSG_VMS.H */
|
|
/* */
|
|
/* This defines the necessary bits to change CURLE_* error codes to VMS */
|
|
/* style error codes. CURLMSG.H is built from CURLMSG.SDL which is built */
|
|
/* from CURLMSG.MSG. The vms_cond array is used to return VMS errors by */
|
|
/* putting the VMS error codes into the array offset based on CURLE_* code. */
|
|
/* */
|
|
/* If you update CURLMSG.MSG make sure to update this file to match. */
|
|
/* */
|
|
|
|
#include "curlmsg.h"
|
|
|
|
static const long vms_cond[] =
|
|
{
|
|
CURL_OK,
|
|
CURL_UNSUPPORTED_PROTOCOL,
|
|
CURL_FAILED_INIT,
|
|
CURL_URL_MALFORMAT,
|
|
CURL_OBSOLETE4,
|
|
CURL_COULDNT_RESOLVE_PROXY,
|
|
CURL_COULDNT_RESOLVE_HOST,
|
|
CURL_COULDNT_CONNECT,
|
|
CURL_WEIRD_SERVER_REPLY,
|
|
CURL_FTP_ACCESS_DENIED,
|
|
CURL_OBSOLETE10,
|
|
CURL_FTP_WEIRD_PASS_REPLY,
|
|
CURL_OBSOLETE12,
|
|
CURL_FTP_WEIRD_PASV_REPLY,
|
|
CURL_FTP_WEIRD_227_FORMAT,
|
|
CURL_FTP_CANT_GET_HOST,
|
|
CURL_OBSOLETE16,
|
|
CURL_FTP_COULDNT_SET_TYPE,
|
|
CURL_PARTIAL_FILE,
|
|
CURL_FTP_COULDNT_RETR_FILE,
|
|
CURL_OBSOLETE20,
|
|
CURL_QUOTE_ERROR,
|
|
CURL_HTTP_RETURNED_ERROR,
|
|
CURL_WRITE_ERROR,
|
|
CURL_OBSOLETE24,
|
|
CURL_UPLOAD_FAILED,
|
|
CURL_READ_ERROR,
|
|
CURL_OUT_OF_MEMORY,
|
|
CURL_OPERATION_TIMEOUTED,
|
|
CURL_OBSOLETE29,
|
|
CURL_FTP_PORT_FAILED,
|
|
CURL_FTP_COULDNT_USE_REST,
|
|
CURL_OBSOLETE32,
|
|
CURL_RANGE_ERROR,
|
|
CURL_HTTP_POST_ERROR,
|
|
CURL_SSL_CONNECT_ERROR,
|
|
CURL_BAD_DOWNLOAD_RESUME,
|
|
CURL_FILE_COULDNT_READ_FILE,
|
|
CURL_LDAP_CANNOT_BIND,
|
|
CURL_LDAP_SEARCH_FAILED,
|
|
CURL_OBSOLETE40,
|
|
CURL_FUNCTION_NOT_FOUND,
|
|
CURL_ABORTED_BY_CALLBACK,
|
|
CURL_BAD_FUNCTION_ARGUMENT,
|
|
CURL_OBSOLETE44,
|
|
CURL_INTERFACE_FAILED,
|
|
CURL_OBSOLETE46,
|
|
CURL_TOO_MANY_REDIRECTS,
|
|
CURL_UNKNOWN_TELNET_OPTION,
|
|
CURL_TELNET_OPTION_SYNTAX,
|
|
CURL_OBSOLETE50,
|
|
CURL_PEER_FAILED_VERIF,
|
|
CURL_GOT_NOTHING,
|
|
CURL_SSL_ENGINE_NOTFOUND,
|
|
CURL_SSL_ENGINE_SETFAILED,
|
|
CURL_SEND_ERROR,
|
|
CURL_RECV_ERROR,
|
|
CURL_OBSOLETE57,
|
|
CURL_SSL_CERTPROBLEM,
|
|
CURL_SSL_CIPHER,
|
|
CURL_SSL_CACERT,
|
|
CURL_BAD_CONTENT_ENCODING,
|
|
CURL_LDAP_INVALID_URL,
|
|
CURL_FILESIZE_EXCEEDED,
|
|
CURL_USE_SSL_FAILED,
|
|
CURL_SEND_FAIL_REWIND,
|
|
CURL_SSL_ENGINE_INITFAILED,
|
|
CURL_LOGIN_DENIED,
|
|
CURL_TFTP_NOTFOUND,
|
|
CURL_TFTP_PERM,
|
|
CURL_REMOTE_DISK_FULL,
|
|
CURL_TFTP_ILLEGAL,
|
|
CURL_TFTP_UNKNOWNID,
|
|
CURL_REMOTE_FILE_EXISTS,
|
|
CURL_TFTP_NOSUCHUSER,
|
|
CURL_CONV_FAILED,
|
|
CURL_CONV_REQD,
|
|
CURL_SSL_CACERT_BADFILE,
|
|
CURL_REMOTE_FILE_NOT_FOUND,
|
|
CURL_SSH,
|
|
CURL_SSL_SHUTDOWN_FAILED,
|
|
CURL_AGAIN,
|
|
CURLE_SSL_CRL_BADFILE,
|
|
CURLE_SSL_ISSUER_ERROR,
|
|
CURL_CURL_LAST
|
|
};
|
|
|
|
#endif /* HEADER_CURLMSG_VMS_H */
|