mirror of
https://github.com/open-goal/jak-project
synced 2026-08-27 00:23:50 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
86 lines
3.4 KiB
C
Vendored
Generated
86 lines
3.4 KiB
C
Vendored
Generated
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "unitcheck.h"
|
|
#include "urldata.h"
|
|
|
|
static void checksize(const char *name, size_t size, size_t allowed)
|
|
{
|
|
if(size > allowed) {
|
|
curl_mfprintf(stderr, "BAD: struct %s is %zu bytes, "
|
|
"allowed to be %zu: %zu bytes too big\n",
|
|
name, size, allowed, size - allowed);
|
|
unitfail++;
|
|
}
|
|
else {
|
|
curl_mprintf("FINE: struct %s is %zu bytes, "
|
|
"allowed %zu (margin: %zu bytes)\n",
|
|
name, size, allowed, allowed - size);
|
|
}
|
|
}
|
|
|
|
/* the maximum sizes we allow specific structs to grow to */
|
|
#define MAX_CURL_EASY 5370
|
|
#define MAX_CONNECTDATA 1300
|
|
#define MAX_CURL_MULTI 850
|
|
#define MAX_CURL_HTTPPOST 112
|
|
#define MAX_CURL_SLIST 16
|
|
#define MAX_CURL_KHKEY 24
|
|
#define MAX_CURL_HSTSENTRY 40
|
|
#define MAX_CURL_INDEX 16
|
|
#define MAX_CURL_MIME 96
|
|
#define MAX_CURL_MIMEPART 440
|
|
#define MAX_CURL_CERTINFO 16
|
|
#define MAX_CURL_TLSSESSIONINFO 16
|
|
#define MAX_CURL_BLOB 24
|
|
#define MAX_CURLMSG 24
|
|
#define MAX_CURL_HEADER 48
|
|
|
|
static CURLcode test_unit3214(const char *arg)
|
|
{
|
|
UNITTEST_BEGIN_SIMPLE
|
|
|
|
checksize("Curl_easy", sizeof(struct Curl_easy), MAX_CURL_EASY);
|
|
checksize("connectdata", sizeof(struct connectdata), MAX_CONNECTDATA);
|
|
checksize("Curl_multi", sizeof(struct Curl_multi), MAX_CURL_MULTI);
|
|
|
|
/* public structs MUST NOT change (unless controlled), but exact sizes
|
|
depend on architecture */
|
|
checksize("curl_httppost", sizeof(struct curl_httppost), MAX_CURL_HTTPPOST);
|
|
checksize("curl_slist", sizeof(struct curl_slist), MAX_CURL_SLIST);
|
|
checksize("curl_khkey", sizeof(struct curl_khkey), MAX_CURL_KHKEY);
|
|
checksize("curl_hstsentry", sizeof(struct curl_hstsentry),
|
|
MAX_CURL_HSTSENTRY);
|
|
checksize("curl_index", sizeof(struct curl_index), MAX_CURL_INDEX);
|
|
checksize("curl_mime", sizeof(struct curl_mime), MAX_CURL_MIME);
|
|
checksize("curl_mimepart", sizeof(struct curl_mimepart), MAX_CURL_MIMEPART);
|
|
checksize("curl_certinfo", sizeof(struct curl_certinfo), MAX_CURL_CERTINFO);
|
|
checksize("curl_tlssessioninfo", sizeof(struct curl_tlssessioninfo),
|
|
MAX_CURL_TLSSESSIONINFO);
|
|
checksize("curl_blob", sizeof(struct curl_blob), MAX_CURL_BLOB);
|
|
checksize("CURLMsg", sizeof(struct CURLMsg), MAX_CURLMSG);
|
|
checksize("curl_header", sizeof(struct curl_header), MAX_CURL_HEADER);
|
|
|
|
UNITTEST_END_SIMPLE
|
|
}
|