mirror of
https://github.com/open-goal/jak-project
synced 2026-05-30 00:47:20 -04:00
Tyler Wilding
c162c66118
This PR does two main things: 1. Work through the main low-hanging fruit issues in the formatter keeping it from feeling mature and usable 2. Iterate and prove that point by formatting all of the Jak 1 code base. **This has removed around 100K lines in total.** - The decompiler will now format it's results for jak 1 to keep things from drifting back to where they were. This is controlled by a new config flag `format_code`. How am I confident this hasn't broken anything?: - I compiled the entire project and stored it's `out/jak1/obj` files separately - I then recompiled the project after formatting and wrote a script that md5's each file and compares it (`compare-compilation-outputs.py` - The results (eventually) were the same:  > This proves that the only difference before and after is non-critical whitespace for all code/macros that is actually in use. I'm still aware of improvements that could be made to the formatter, as well as general optimization of it's performance. But in general these are for rare or non-critical situations in my opinion and I'll work through them before doing Jak 2. The vast majority looks great and is working properly at this point. Those known issues are the following if you are curious: 
57 lines
1.5 KiB
Common Lisp
57 lines
1.5 KiB
Common Lisp
;;-*-Lisp-*-
|
|
(in-package goal)
|
|
(bundles "ENGINE.CGO" "GAME.CGO")
|
|
(require "engine/ps2/rpc-h.gc")
|
|
|
|
;; see game/overlord/ramdisk.cpp
|
|
;; unlike most other loads, ramdisk actually uses the response buffer of the RPC
|
|
;; to send the data.
|
|
|
|
(defconstant RAMDISK_RPC_FILL_FNO (the uint 1))
|
|
|
|
;; DECOMP BEGINS
|
|
|
|
;; command to load something into the OVERLORD RAMDISK from the DVD
|
|
;; use with fno = 1
|
|
(deftype ramdisk-rpc-fill (structure)
|
|
((rsvd1 int32)
|
|
(ee-id int32)
|
|
(rsvd2 int32 2)
|
|
(filename uint128)))
|
|
|
|
;; get data in ramdisk on EE.
|
|
(deftype ramdisk-rpc-load (structure)
|
|
((rsvd int32)
|
|
(ee-id int32)
|
|
(offset uint32)
|
|
(length uint32)))
|
|
|
|
;; load file directly to EE.
|
|
;; this seems very similar to some functionality in STR.
|
|
(deftype ramdisk-rpc-load-to-ee (structure)
|
|
((rsvd int32)
|
|
(addr int32)
|
|
(offset int32)
|
|
(length int32)
|
|
(filename uint128)))
|
|
|
|
;; allocate the ramdisk RPC buffer
|
|
(define *ramdisk-rpc* (new 'global 'rpc-buffer-pair (the-as uint 32) (the-as uint 1) RPC-RAMDISK))
|
|
|
|
(define *current-ramdisk-id* 0)
|
|
|
|
(defun ramdisk-load ((file-id int) (offset uint) (length uint) (buffer pointer))
|
|
"Helper to grab load from ramdisk to ee"
|
|
(let ((cmd (the-as ramdisk-rpc-load (add-element *ramdisk-rpc*))))
|
|
(set! (-> cmd offset) offset)
|
|
(set! (-> cmd ee-id) file-id)
|
|
(set! (-> cmd length) length))
|
|
(call *ramdisk-rpc* (the-as uint 0) buffer length)
|
|
0)
|
|
|
|
(defun ramdisk-sync ()
|
|
"Wait for ramdisk RPC to complete."
|
|
(sync *ramdisk-rpc* #t)
|
|
0
|
|
(none))
|