mirror of
https://github.com/open-goal/jak-project
synced 2026-05-28 00:16:20 -04:00
Tyler Wilding
c162c66118
This PR does two main things: 1. Work through the main low-hanging fruit issues in the formatter keeping it from feeling mature and usable 2. Iterate and prove that point by formatting all of the Jak 1 code base. **This has removed around 100K lines in total.** - The decompiler will now format it's results for jak 1 to keep things from drifting back to where they were. This is controlled by a new config flag `format_code`. How am I confident this hasn't broken anything?: - I compiled the entire project and stored it's `out/jak1/obj` files separately - I then recompiled the project after formatting and wrote a script that md5's each file and compares it (`compare-compilation-outputs.py` - The results (eventually) were the same:  > This proves that the only difference before and after is non-critical whitespace for all code/macros that is actually in use. I'm still aware of improvements that could be made to the formatter, as well as general optimization of it's performance. But in general these are for rare or non-critical situations in my opinion and I'll work through them before doing Jak 2. The vast majority looks great and is working properly at this point. Those known issues are the following if you are curious: 
50 lines
1.9 KiB
Common Lisp
50 lines
1.9 KiB
Common Lisp
;;-*-Lisp-*-
|
|
(in-package goal)
|
|
(bundles "ENGINE.CGO" "GAME.CGO")
|
|
(require "engine/debug/assert-h.gc")
|
|
(define *run-time-assert-enable* #t)
|
|
|
|
;; TODO macros
|
|
|
|
(defun __assert ((expr symbol) (msg string))
|
|
"Assert that expr is truthy, print assert information otherwise"
|
|
(when (not expr)
|
|
(format #t "(ASSERT ~S) FAILED in " msg)
|
|
(print-pos *__private-assert-info*))
|
|
0)
|
|
|
|
(defun __assert-min-max-range-float ((expr float) (minimum float) (maximum float) (msg-expr string) (msg-min string) (msg-max string))
|
|
"Assert that float expr is a larger value than minimum and smaller than maximum, print assert information otherwise"
|
|
(when (or (< expr minimum) (< maximum expr))
|
|
(format #t
|
|
"(ASSERT_MIN_MAX_RANGE_FLOAT ~S ~S ~S) FAILED (values ~F ~F ~F) in "
|
|
msg-expr
|
|
msg-min
|
|
msg-max
|
|
expr
|
|
minimum
|
|
maximum)
|
|
(print-pos *__private-assert-info*))
|
|
0)
|
|
|
|
(defun __assert-min-max-range-int ((expr int) (minimum int) (maximum int) (msg-expr string) (msg-min string) (msg-max string))
|
|
"Assert that integer expr is a larger value than minimum and smaller than maximum, print assert information otherwise"
|
|
(when (or (< expr minimum) (< maximum expr))
|
|
(format #t
|
|
"(ASSERT_MIN_MAX_RANGE_INT ~S ~S ~S) FAILED (values ~D ~D ~D) in "
|
|
msg-expr
|
|
msg-min
|
|
msg-max
|
|
expr
|
|
minimum
|
|
maximum)
|
|
(print-pos *__private-assert-info*))
|
|
0)
|
|
|
|
(defun __assert-zero-lim-range-int ((expr int) (maximum int) (msg-expr string) (msg-max string))
|
|
"Assert that integer expr is a larger value than zero and smaller than maximum, print assert information otherwise"
|
|
(when (or (< expr 0) (>= expr max))
|
|
(format #t "(ASSERT_ZERO_LIM_RANGE_INT ~S ~S) FAILED (values ~D ~D) in " msg-expr msg-max expr maximum)
|
|
(print-pos *__private-assert-info*))
|
|
0)
|