mirror of
https://github.com/open-goal/jak-project
synced 2026-08-08 02:31:30 -04:00
Tyler Wilding
c162c66118
This PR does two main things: 1. Work through the main low-hanging fruit issues in the formatter keeping it from feeling mature and usable 2. Iterate and prove that point by formatting all of the Jak 1 code base. **This has removed around 100K lines in total.** - The decompiler will now format it's results for jak 1 to keep things from drifting back to where they were. This is controlled by a new config flag `format_code`. How am I confident this hasn't broken anything?: - I compiled the entire project and stored it's `out/jak1/obj` files separately - I then recompiled the project after formatting and wrote a script that md5's each file and compares it (`compare-compilation-outputs.py` - The results (eventually) were the same:  > This proves that the only difference before and after is non-critical whitespace for all code/macros that is actually in use. I'm still aware of improvements that could be made to the formatter, as well as general optimization of it's performance. But in general these are for rare or non-critical situations in my opinion and I'll work through them before doing Jak 2. The vast majority looks great and is working properly at this point. Those known issues are the following if you are curious: 
30 lines
873 B
Common Lisp
30 lines
873 B
Common Lisp
;;-*-Lisp-*-
|
|
(in-package goal)
|
|
(bundles "ENGINE.CGO" "GAME.CGO")
|
|
(require "kernel-defs.gc")
|
|
(defconstant MAX_CURVE_CONTROL_POINTS 256)
|
|
|
|
(defun-extern quaternion-from-two-vectors-max-angle! quaternion vector vector float quaternion)
|
|
|
|
;; DECOMP BEGINS
|
|
|
|
;; A 3 dimensional polynomial spline with arbitrarily placed knot points
|
|
;; It's used for camera paths and similar and can be generated by offline tools.
|
|
(deftype curve (structure)
|
|
((cverts (inline-array vector))
|
|
(num-cverts int32)
|
|
(knots (pointer float))
|
|
(num-knots int32)
|
|
(length float)))
|
|
|
|
;; unused plane type that would likely trigger some action on crossing.
|
|
(deftype border-plane (basic)
|
|
((name symbol)
|
|
(action basic)
|
|
(slot int8)
|
|
(trans vector :inline)
|
|
(normal vector :inline))
|
|
(:methods
|
|
(debug-draw! (_type_) none)
|
|
(point-past-plane? (_type_ vector) symbol)))
|