mirror of
https://github.com/open-goal/jak-project
synced 2026-08-06 18:03:30 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
154 lines
2.7 KiB
Plaintext
Vendored
Generated
154 lines
2.7 KiB
Plaintext
Vendored
Generated
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
# common variable types + structs
|
|
# callback typedefs
|
|
# public functions names
|
|
# some man page names
|
|
curl_fileinfo
|
|
curl_forms
|
|
curl_hstsentry
|
|
curl_httppost
|
|
curl_index
|
|
curl_khkey
|
|
curl_pushheaders
|
|
curl_waitfd
|
|
CURLcode
|
|
CURLformoption
|
|
CURLHcode
|
|
CURLMcode
|
|
CURLMsg
|
|
CURLSHcode
|
|
CURLUcode
|
|
curl_calloc_callback
|
|
curl_chunk_bgn_callback
|
|
curl_chunk_end_callback
|
|
curl_conv_callback
|
|
curl_debug_callback
|
|
curl_fnmatch_callback
|
|
curl_formget_callback
|
|
curl_free_callback
|
|
curl_hstsread_callback
|
|
curl_hstswrite_callback
|
|
curl_ioctl_callback
|
|
curl_malloc_callback
|
|
curl_multi_timer_callback
|
|
curl_opensocket_callback
|
|
curl_prereq_callback
|
|
curl_progress_callback
|
|
curl_push_callback
|
|
curl_read_callback
|
|
curl_realloc_callback
|
|
curl_resolver_start_callback
|
|
curl_seek_callback
|
|
curl_socket_callback
|
|
curl_sockopt_callback
|
|
curl_ssl_ctx_callback
|
|
curl_strdup_callback
|
|
curl_trailer_callback
|
|
curl_write_callback
|
|
curl_xferinfo_callback
|
|
curl_strequal
|
|
curl_strnequal
|
|
curl_mime_init
|
|
curl_mime_free
|
|
curl_mime_addpart
|
|
curl_mime_name
|
|
curl_mime_filename
|
|
curl_mime_type
|
|
curl_mime_encoder
|
|
curl_mime_data
|
|
curl_mime_filedata
|
|
curl_mime_data_cb
|
|
curl_mime_subparts
|
|
curl_mime_headers
|
|
curl_formadd
|
|
curl_formget
|
|
curl_formfree
|
|
curl_getdate
|
|
curl_getenv
|
|
curl_version
|
|
curl_easy_escape
|
|
curl_escape
|
|
curl_easy_unescape
|
|
curl_unescape
|
|
curl_free
|
|
curl_global_init
|
|
curl_global_init_mem
|
|
curl_global_cleanup
|
|
curl_global_trace
|
|
curl_global_sslset
|
|
curl_slist_append
|
|
curl_slist_free_all
|
|
curl_getdate
|
|
curl_share_init
|
|
curl_share_setopt
|
|
curl_share_cleanup
|
|
curl_version_info
|
|
curl_easy_strerror
|
|
curl_share_strerror
|
|
curl_easy_pause
|
|
curl_easy_ssls_import
|
|
curl_easy_ssls_export
|
|
curl_easy_init
|
|
curl_easy_setopt
|
|
curl_easy_perform
|
|
curl_easy_cleanup
|
|
curl_easy_getinfo
|
|
curl_easy_duphandle
|
|
curl_easy_reset
|
|
curl_easy_recv
|
|
curl_easy_send
|
|
curl_easy_upkeep
|
|
curl_easy_header
|
|
curl_easy_nextheader
|
|
curl_mprintf
|
|
curl_mfprintf
|
|
curl_msprintf
|
|
curl_msnprintf
|
|
curl_mvprintf
|
|
curl_mvfprintf
|
|
curl_mvsprintf
|
|
curl_mvsnprintf
|
|
curl_maprintf
|
|
curl_mvaprintf
|
|
curl_multi_init
|
|
curl_multi_add_handle
|
|
curl_multi_remove_handle
|
|
curl_multi_fdset
|
|
curl_multi_waitfds
|
|
curl_multi_wait
|
|
curl_multi_poll
|
|
curl_multi_wakeup
|
|
curl_multi_perform
|
|
curl_multi_cleanup
|
|
curl_multi_info_read
|
|
curl_multi_strerror
|
|
curl_multi_socket
|
|
curl_multi_socket_action
|
|
curl_multi_socket_all
|
|
curl_multi_timeout
|
|
curl_multi_setopt
|
|
curl_multi_assign
|
|
curl_multi_get_handles
|
|
curl_multi_get_offt
|
|
curl_multi_notify_disable
|
|
curl_multi_notify_enable
|
|
curl_pushheader_bynum
|
|
curl_pushheader_byname
|
|
curl_easy_option_by_name
|
|
curl_easy_option_by_id
|
|
curl_easy_option_next
|
|
curl_url
|
|
curl_url_cleanup
|
|
curl_url_dup
|
|
curl_url_get
|
|
curl_url_set
|
|
curl_url_strerror
|
|
curl_ws_recv
|
|
curl_ws_send
|
|
curl_ws_meta
|
|
libcurl-env
|
|
libcurl-ws
|