mirror of
https://github.com/open-goal/jak-project
synced 2026-08-08 18:44:15 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
157 lines
6.1 KiB
Makefile
Vendored
Generated
157 lines
6.1 KiB
Makefile
Vendored
Generated
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
|
|
AUTOMAKE_OPTIONS = foreign no-dependencies
|
|
|
|
if BUILD_DOCS
|
|
# if we disable man page building, ignore these
|
|
MK_CA_DOCS = mk-ca-bundle.1
|
|
CURLCONF_DOCS = curl-config.1
|
|
man_MANS = curl-config.1 wcurl.1
|
|
endif
|
|
|
|
CURLPAGES = curl-config.md mk-ca-bundle.md wcurl.md runtests.md testcurl.md
|
|
|
|
SUBDIRS = . cmdline-opts libcurl
|
|
DIST_SUBDIRS = $(SUBDIRS) examples
|
|
|
|
if BUILD_DOCS
|
|
CLEANFILES = $(MK_CA_DOCS) $(man_MANS)
|
|
endif
|
|
|
|
TESTDOCS = \
|
|
tests/FILEFORMAT.md \
|
|
tests/HTTP.md \
|
|
tests/TEST-SUITE.md
|
|
|
|
INTERNALDOCS = \
|
|
internals/BUFQ.md \
|
|
internals/BUFREF.md \
|
|
internals/CHECKSRC.md \
|
|
internals/CLIENT-READERS.md \
|
|
internals/CLIENT-WRITERS.md \
|
|
internals/CODE_STYLE.md \
|
|
internals/CONNECTION-FILTERS.md \
|
|
internals/CREDENTIALS.md \
|
|
internals/CURLX.md \
|
|
internals/DYNBUF.md \
|
|
internals/HASH.md \
|
|
internals/LLIST.md \
|
|
internals/MID.md \
|
|
internals/MQTT.md \
|
|
internals/MULTI-EV.md \
|
|
internals/NEW-PROTOCOL.md \
|
|
internals/PEERS.md \
|
|
internals/PORTING.md \
|
|
internals/RATELIMITS.md \
|
|
internals/README.md \
|
|
internals/SCORECARD.md \
|
|
internals/SPLAY.md \
|
|
internals/STRPARSE.md \
|
|
internals/THRDPOOL-AND-QUEUE.md \
|
|
internals/TIME-KEEPING.md \
|
|
internals/TLS-SESSIONS.md \
|
|
internals/UINT_SETS.md \
|
|
internals/WEBSOCKET.md
|
|
|
|
EXTRA_DIST = \
|
|
$(CURLPAGES) \
|
|
$(INTERNALDOCS) \
|
|
$(TESTDOCS) \
|
|
ALTSVC.md \
|
|
BINDINGS.md \
|
|
BUG-BOUNTY.md \
|
|
BUGS.md \
|
|
CIPHERS.md \
|
|
CIPHERS-TLS12.md \
|
|
CMakeLists.txt \
|
|
CODE_OF_CONDUCT.md \
|
|
CODE_REVIEW.md \
|
|
CONTRIBUTE.md \
|
|
CURL-DISABLE.md \
|
|
CURLDOWN.md \
|
|
DEPRECATE.md \
|
|
DISTROS.md \
|
|
EARLY-RELEASE.md \
|
|
ECH.md \
|
|
EXPERIMENTAL.md \
|
|
FAQ.md \
|
|
FEATURES.md \
|
|
GOVERNANCE.md \
|
|
HELP-US.md \
|
|
HISTORY.md \
|
|
HSTS.md \
|
|
HTTP-COOKIES.md \
|
|
HTTP3.md \
|
|
HTTPSRR.md \
|
|
INFRASTRUCTURE.md \
|
|
INSTALL \
|
|
INSTALL-CMAKE.md \
|
|
INSTALL.md \
|
|
INTERNALS.md \
|
|
IPFS.md \
|
|
KNOWN_BUGS.md \
|
|
KNOWN_RISKS.md \
|
|
MAIL-ETIQUETTE.md \
|
|
MANUAL.md \
|
|
options-in-versions \
|
|
README.md \
|
|
RELEASE-PROCEDURE.md \
|
|
RUSTLS.md \
|
|
ROADMAP.md \
|
|
SECURITY-ADVISORY.md \
|
|
SPONSORS.md \
|
|
SSL-PROBLEMS.md \
|
|
SSLCERTS.md \
|
|
THANKS \
|
|
TODO.md \
|
|
TheArtOfHttpScripting.md \
|
|
URL-SYNTAX.md \
|
|
VERIFY.md \
|
|
VERSIONS.md \
|
|
VULN-DISCLOSURE-POLICY.md
|
|
|
|
CD2NROFF = $(top_srcdir)/scripts/cd2nroff $< >$@
|
|
|
|
CD2 = $(CD2_$(V))
|
|
CD2_0 = @echo " RENDER " $@;
|
|
CD2_1 =
|
|
CD2_ = $(CD2_0)
|
|
|
|
SUFFIXES = .1 .md
|
|
|
|
all: $(MK_CA_DOCS) $(CURLCONF_DOCS)
|
|
|
|
.md.1:
|
|
$(CD2)$(CD2NROFF)
|
|
|
|
curl-config.1: curl-config.md
|
|
|
|
mk-ca-bundle.1: mk-ca-bundle.md
|
|
|
|
wcurl.1: wcurl.md
|
|
|
|
distclean:
|
|
rm -f $(CLEANFILES)
|