mirror of
https://github.com/open-goal/jak-project
synced 2026-08-07 02:06:59 -04:00
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
150 lines
4.2 KiB
C
Vendored
Generated
150 lines
4.2 KiB
C
Vendored
Generated
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
/* <DESC>
|
|
* Import and export cookies with COOKIELIST.
|
|
* </DESC>
|
|
*/
|
|
#ifdef _MSC_VER
|
|
#ifndef _CRT_SECURE_NO_WARNINGS
|
|
#define _CRT_SECURE_NO_WARNINGS /* for _snprintf() */
|
|
#endif
|
|
#endif
|
|
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <stdlib.h>
|
|
#include <time.h>
|
|
|
|
#include <curl/curl.h>
|
|
|
|
#if defined(_MSC_VER) && (_MSC_VER < 1900)
|
|
#define snprintf _snprintf
|
|
#endif
|
|
|
|
static int print_cookies(CURL *curl)
|
|
{
|
|
CURLcode result;
|
|
struct curl_slist *cookies;
|
|
struct curl_slist *nc;
|
|
int i;
|
|
|
|
printf("Cookies, curl knows:\n");
|
|
result = curl_easy_getinfo(curl, CURLINFO_COOKIELIST, &cookies);
|
|
if(result != CURLE_OK) {
|
|
fprintf(stderr, "curl curl_easy_getinfo failed: %s\n",
|
|
curl_easy_strerror(result));
|
|
return 1;
|
|
}
|
|
nc = cookies;
|
|
i = 1;
|
|
while(nc) {
|
|
printf("[%d]: %s\n", i, nc->data);
|
|
nc = nc->next;
|
|
i++;
|
|
}
|
|
if(i == 1) {
|
|
printf("(none)\n");
|
|
}
|
|
curl_slist_free_all(cookies);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
CURL *curl;
|
|
CURLcode result;
|
|
|
|
result = curl_global_init(CURL_GLOBAL_ALL);
|
|
if(result != CURLE_OK)
|
|
return (int)result;
|
|
|
|
curl = curl_easy_init();
|
|
if(curl) {
|
|
char nline[512];
|
|
|
|
curl_easy_setopt(curl, CURLOPT_URL, "https://www.example.com/");
|
|
curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
curl_easy_setopt(curl, CURLOPT_COOKIEFILE, ""); /* start cookie engine */
|
|
result = curl_easy_perform(curl);
|
|
if(result != CURLE_OK) {
|
|
fprintf(stderr, "curl perform failed: %s\n", curl_easy_strerror(result));
|
|
return 1;
|
|
}
|
|
|
|
print_cookies(curl);
|
|
|
|
printf("Erasing curl's knowledge of cookies!\n");
|
|
curl_easy_setopt(curl, CURLOPT_COOKIELIST, "ALL");
|
|
|
|
print_cookies(curl);
|
|
|
|
printf("-----------------------------------------------\n"
|
|
"Setting a cookie \"PREF\" via cookie interface:\n");
|
|
/* Netscape format cookie */
|
|
snprintf(nline, sizeof(nline), "%s\t%s\t%s\t%s\t%.0f\t%s\t%s",
|
|
".example.com", "TRUE", "/", "FALSE",
|
|
difftime(time(NULL) + 31337, (time_t)0),
|
|
"PREF", "hello example, I like you!");
|
|
result = curl_easy_setopt(curl, CURLOPT_COOKIELIST, nline);
|
|
if(result != CURLE_OK) {
|
|
fprintf(stderr, "curl curl_easy_setopt failed: %s\n",
|
|
curl_easy_strerror(result));
|
|
return 1;
|
|
}
|
|
|
|
/* HTTP-header style cookie. If you use the Set-Cookie format and do not
|
|
specify a domain then the cookie is sent for any domain and is not
|
|
modified, likely not what you intended. For more information refer to
|
|
the CURLOPT_COOKIELIST documentation.
|
|
*/
|
|
snprintf(nline, sizeof(nline),
|
|
"Set-Cookie: OLD_PREF=3d141414bf4209321; "
|
|
"expires=Sun, 17-Jan-2038 19:14:07 GMT; path=/; domain=.example.com");
|
|
result = curl_easy_setopt(curl, CURLOPT_COOKIELIST, nline);
|
|
if(result != CURLE_OK) {
|
|
fprintf(stderr, "curl curl_easy_setopt failed: %s\n",
|
|
curl_easy_strerror(result));
|
|
return 1;
|
|
}
|
|
|
|
print_cookies(curl);
|
|
|
|
result = curl_easy_perform(curl);
|
|
if(result != CURLE_OK) {
|
|
fprintf(stderr, "curl perform failed: %s\n", curl_easy_strerror(result));
|
|
return 1;
|
|
}
|
|
|
|
curl_easy_cleanup(curl);
|
|
}
|
|
else {
|
|
fprintf(stderr, "curl init failed!\n");
|
|
return 1;
|
|
}
|
|
|
|
curl_global_cleanup();
|
|
return 0;
|
|
}
|