mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 14:24:45 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
169 lines
4.0 KiB
Makefile
Vendored
Generated
169 lines
4.0 KiB
Makefile
Vendored
Generated
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
# Shared between CMakeLists.txt and Makefile.am
|
|
|
|
# Using the backslash as line continuation character might be problematic with
|
|
# some make flavors. If we ever want to change this in a portable manner then
|
|
# we should consider this idea :
|
|
# CSRC1 = file1.c file2.c file3.c
|
|
# CSRC2 = file4.c file5.c file6.c
|
|
# CSOURCES = $(CSRC1) $(CSRC2)
|
|
|
|
# libcurl has sources that provide functions named curlx_* that are not part of
|
|
# the official API, but we reuse the code here to avoid duplication.
|
|
CURLX_CFILES = \
|
|
../lib/curlx/base64.c \
|
|
../lib/curlx/basename.c \
|
|
../lib/curlx/dynbuf.c \
|
|
../lib/curlx/fopen.c \
|
|
../lib/curlx/multibyte.c \
|
|
../lib/curlx/nonblock.c \
|
|
../lib/curlx/strcopy.c \
|
|
../lib/curlx/strdup.c \
|
|
../lib/curlx/strerr.c \
|
|
../lib/curlx/strparse.c \
|
|
../lib/curlx/timediff.c \
|
|
../lib/curlx/timeval.c \
|
|
../lib/curlx/version_win32.c \
|
|
../lib/curlx/wait.c \
|
|
../lib/curlx/warnless.c \
|
|
../lib/curlx/winapi.c
|
|
|
|
CURLX_HFILES = \
|
|
../lib/curl_setup.h \
|
|
../lib/curlx/base64.h \
|
|
../lib/curlx/basename.h \
|
|
../lib/curlx/dynbuf.h \
|
|
../lib/curlx/fopen.h \
|
|
../lib/curlx/multibyte.h \
|
|
../lib/curlx/nonblock.h \
|
|
../lib/curlx/strcopy.h \
|
|
../lib/curlx/strdup.h \
|
|
../lib/curlx/strerr.h \
|
|
../lib/curlx/strparse.h \
|
|
../lib/curlx/timediff.h \
|
|
../lib/curlx/timeval.h \
|
|
../lib/curlx/version_win32.h \
|
|
../lib/curlx/wait.h \
|
|
../lib/curlx/warnless.h \
|
|
../lib/curlx/winapi.h
|
|
|
|
TOOLX_CFILES = \
|
|
toolx/tool_time.c
|
|
|
|
TOOLX_HFILES = \
|
|
toolx/tool_time.h
|
|
|
|
CURL_CFILES = \
|
|
config2setopts.c \
|
|
slist_wc.c \
|
|
terminal.c \
|
|
tool_cb_dbg.c \
|
|
tool_cb_hdr.c \
|
|
tool_cb_prg.c \
|
|
tool_cb_rea.c \
|
|
tool_cb_see.c \
|
|
tool_cb_soc.c \
|
|
tool_cb_wrt.c \
|
|
tool_cfgable.c \
|
|
tool_dirhie.c \
|
|
tool_doswin.c \
|
|
tool_easysrc.c \
|
|
tool_filetime.c \
|
|
tool_findfile.c \
|
|
tool_formparse.c \
|
|
tool_getparam.c \
|
|
tool_getpass.c \
|
|
tool_help.c \
|
|
tool_helpers.c \
|
|
tool_ipfs.c \
|
|
tool_libinfo.c \
|
|
tool_listhelp.c \
|
|
tool_main.c \
|
|
tool_msgs.c \
|
|
tool_operate.c \
|
|
tool_operhlp.c \
|
|
tool_paramhlp.c \
|
|
tool_parsecfg.c \
|
|
tool_progress.c \
|
|
tool_setopt.c \
|
|
tool_ssls.c \
|
|
tool_stderr.c \
|
|
tool_urlglob.c \
|
|
tool_util.c \
|
|
tool_vms.c \
|
|
tool_writeout.c \
|
|
tool_writeout_json.c \
|
|
tool_xattr.c \
|
|
var.c \
|
|
$(TOOLX_CFILES)
|
|
|
|
CURL_HFILES = \
|
|
config2setopts.h \
|
|
slist_wc.h \
|
|
terminal.h \
|
|
tool_cb_dbg.h \
|
|
tool_cb_hdr.h \
|
|
tool_cb_prg.h \
|
|
tool_cb_rea.h \
|
|
tool_cb_see.h \
|
|
tool_cb_soc.h \
|
|
tool_cb_wrt.h \
|
|
tool_cfgable.h \
|
|
tool_dirhie.h \
|
|
tool_doswin.h \
|
|
tool_easysrc.h \
|
|
tool_filetime.h \
|
|
tool_findfile.h \
|
|
tool_formparse.h \
|
|
tool_getparam.h \
|
|
tool_getpass.h \
|
|
tool_help.h \
|
|
tool_helpers.h \
|
|
tool_ipfs.h \
|
|
tool_libinfo.h \
|
|
tool_main.h \
|
|
tool_msgs.h \
|
|
tool_operate.h \
|
|
tool_operhlp.h \
|
|
tool_paramhlp.h \
|
|
tool_parsecfg.h \
|
|
tool_progress.h \
|
|
tool_sdecls.h \
|
|
tool_setopt.h \
|
|
tool_setup.h \
|
|
tool_ssls.h \
|
|
tool_stderr.h \
|
|
tool_urlglob.h \
|
|
tool_util.h \
|
|
tool_version.h \
|
|
tool_vms.h \
|
|
tool_writeout.h \
|
|
tool_writeout_json.h \
|
|
tool_xattr.h \
|
|
var.h \
|
|
$(TOOLX_HFILES)
|
|
|
|
CURL_RCFILES = curl.rc
|