mirror of
https://github.com/open-goal/jak-project
synced 2026-08-19 06:02:15 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
432 lines
23 KiB
Python
Vendored
Generated
432 lines
23 KiB
Python
Vendored
Generated
#!/usr/bin/env python3
|
|
# -*- coding: utf-8 -*-
|
|
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
#
|
|
import filecmp
|
|
import logging
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
import pytest
|
|
from testenv import CurlClient, Env, ExecResult
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
|
|
class TestProxy:
|
|
|
|
@pytest.fixture(autouse=True, scope='class')
|
|
def _class_scope(self, env, httpd, nghttpx_fwd):
|
|
push_dir = os.path.join(httpd.docs_dir, 'push')
|
|
if not os.path.exists(push_dir):
|
|
os.makedirs(push_dir)
|
|
if env.have_nghttpx():
|
|
nghttpx_fwd.start_if_needed()
|
|
env.make_data_file(indir=env.gen_dir, fname="data-100k", fsize=100 * 1024)
|
|
env.make_data_file(indir=env.gen_dir, fname="data-10m", fsize=10 * 1024 * 1024)
|
|
indir = httpd.docs_dir
|
|
env.make_data_file(indir=indir, fname="data-100k", fsize=100 * 1024)
|
|
env.make_data_file(indir=indir, fname="data-1m", fsize=1024 * 1024)
|
|
|
|
def get_tunnel_proto_used(self, r: ExecResult):
|
|
for line in r.trace_lines:
|
|
m = re.match(r'.* CONNECT: \'(\S+)\' negotiated$', line)
|
|
if m:
|
|
return m.group(1)
|
|
assert False, f'tunnel protocol not found in:\n{"".join(r.trace_lines)}'
|
|
|
|
# download via http: proxy (no tunnel)
|
|
def test_10_01_proxy_http(self, env: Env, httpd):
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=curl.get_proxy_args(proxys=False))
|
|
r.check_response(count=1, http_status=200)
|
|
|
|
# download via https: proxy (no tunnel)
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('HTTPS-proxy'),
|
|
reason='curl lacks HTTPS-proxy support')
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
def test_10_02_proxys_down(self, env: Env, httpd, proto):
|
|
if proto == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(proto=proto)
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=1, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
|
|
# upload via https: with proto (no tunnel)
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("fname, fcount, with_alpn", [
|
|
['data.json', 5, False],
|
|
['data.json', 5, True],
|
|
['data-100k', 5, True],
|
|
['data-1m', 2, True]
|
|
])
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(),
|
|
reason="no nghttpx available")
|
|
def test_10_02_proxys_up(self, env: Env, httpd, nghttpx, proto,
|
|
fname, fcount, with_alpn):
|
|
if proto == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
count = fcount
|
|
srcfile = os.path.join(httpd.docs_dir, fname)
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/curltest/echo?id=[0-{count-1}]'
|
|
xargs = curl.get_proxy_args(proto=proto)
|
|
if not with_alpn:
|
|
xargs.append('--no-alpn')
|
|
r = curl.http_upload(urls=[url], data=f'@{srcfile}', alpn_proto=proto,
|
|
extra_args=xargs)
|
|
r.check_response(count=count, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
with open(srcfile) as fi:
|
|
indata = fi.readlines()
|
|
for i in range(count):
|
|
with open(curl.response_file(i)) as fr:
|
|
respdata = fr.readlines()
|
|
assert respdata == indata
|
|
|
|
# download http: via http: proxytunnel
|
|
def test_10_03_proxytunnel_http(self, env: Env, httpd, nghttpx_fwd):
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(proxys=False, tunnel=True)
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=1, http_status=200)
|
|
|
|
# download http: via https: proxytunnel
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('HTTPS-proxy'),
|
|
reason='curl lacks HTTPS-proxy support')
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
def test_10_04_proxy_https(self, env: Env, httpd, nghttpx_fwd):
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(tunnel=True)
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=1, http_status=200)
|
|
|
|
# download https: with proto via http: proxytunnel
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
def test_10_05_proxytunnel_http(self, env: Env, httpd, nghttpx_fwd, proto):
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/data.json'
|
|
xargs = curl.get_proxy_args(proxys=False, tunnel=True)
|
|
r = curl.http_download(urls=[url], alpn_proto=proto, with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=1, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
|
|
# download https: with proto via https: proxytunnel
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('HTTPS-proxy'),
|
|
reason='curl lacks HTTPS-proxy support')
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_06_proxytunnel_https(self, env: Env, httpd, nghttpx_fwd, proto, tunnel):
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/data.json?[0-0]'
|
|
xargs = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r = curl.http_download(urls=[url], alpn_proto=proto, with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=1, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
assert self.get_tunnel_proto_used(r) == tunnel
|
|
srcfile = os.path.join(httpd.docs_dir, 'data.json')
|
|
dfile = curl.download_file(0)
|
|
assert filecmp.cmp(srcfile, dfile, shallow=False)
|
|
|
|
# download many https: with proto via https: proxytunnel
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("fname, fcount", [
|
|
['data.json', 100],
|
|
['data-100k', 20],
|
|
['data-1m', 5]
|
|
])
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
def test_10_07_pts_down_small(self, env: Env, httpd, nghttpx_fwd, proto,
|
|
tunnel, fname, fcount):
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
if env.curl_uses_lib('mbedtls') and \
|
|
sys.platform.startswith('darwin') and env.ci_run:
|
|
pytest.skip('mbedtls 3.6.3 fails this test on macOS CI runners')
|
|
count = fcount
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/{fname}?[0-{count-1}]'
|
|
xargs = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r = curl.http_download(urls=[url], alpn_proto=proto, with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=count, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
assert self.get_tunnel_proto_used(r) == tunnel
|
|
srcfile = os.path.join(httpd.docs_dir, fname)
|
|
for i in range(count):
|
|
dfile = curl.download_file(i)
|
|
assert filecmp.cmp(srcfile, dfile, shallow=False)
|
|
assert r.total_connects == 1, r.dump_logs()
|
|
|
|
# upload many https: with proto via https: proxytunnel
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.parametrize("fname, fcount", [
|
|
['data.json', 50],
|
|
['data-100k', 20],
|
|
['data-1m', 5]
|
|
])
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
def test_10_08_upload_seq_large(self, env: Env, httpd, nghttpx, proto,
|
|
tunnel, fname, fcount):
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
if env.curl_uses_lib('mbedtls') and \
|
|
sys.platform.startswith('darwin') and env.ci_run:
|
|
pytest.skip('mbedtls 3.6.3 fails this test on macOS CI runners')
|
|
count = fcount
|
|
srcfile = os.path.join(httpd.docs_dir, fname)
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/curltest/echo?id=[0-{count-1}]'
|
|
xargs = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r = curl.http_upload(urls=[url], data=f'@{srcfile}', alpn_proto=proto,
|
|
extra_args=xargs)
|
|
assert self.get_tunnel_proto_used(r) == tunnel
|
|
r.check_response(count=count, http_status=200)
|
|
assert r.total_connects == 1, r.dump_logs()
|
|
with open(srcfile) as fi:
|
|
indata = fi.readlines()
|
|
for i in range(count):
|
|
with open(curl.response_file(i)) as fr:
|
|
respdata = fr.readlines()
|
|
assert respdata == indata, f'response {i} differs'
|
|
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_09_reuse_server(self, env: Env, httpd, nghttpx_fwd, tunnel):
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url1 = f'https://localhost:{env.https_port}/data.json'
|
|
url2 = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r = curl.http_download(urls=[url1, url2], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_response(count=2, http_status=200)
|
|
assert self.get_tunnel_proto_used(r) == tunnel
|
|
if tunnel == 'h2':
|
|
# TODO: we would like to reuse the first connection for the
|
|
# second URL, but this is currently not possible
|
|
# assert r.total_connects == 1
|
|
assert r.total_connects == 2
|
|
else:
|
|
assert r.total_connects == 2
|
|
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_10_reuse_proxy(self, env: Env, httpd, nghttpx_fwd, tunnel):
|
|
# URL twice via https: proxy separated with '--next', will reuse
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
if env.curl_uses_lib('mbedtls') and \
|
|
sys.platform.startswith('darwin') and env.ci_run:
|
|
pytest.skip('mbedtls 3.6.3 fails this test on macOS CI runners')
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/data.json'
|
|
proxy_args = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r1 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=proxy_args)
|
|
r1.check_response(count=1, http_status=200)
|
|
assert self.get_tunnel_proto_used(r1) == tunnel
|
|
# get the args, duplicate separated with '--next'
|
|
x2_args = r1.args[1:]
|
|
x2_args.append('--next')
|
|
x2_args.extend(proxy_args)
|
|
r2 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=x2_args)
|
|
r2.check_response(count=2, http_status=200)
|
|
assert r2.total_connects == 1
|
|
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_uses_lib('openssl'), reason="tls13-ciphers not supported")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_11_noreuse_proxy_https(self, env: Env, httpd, nghttpx_fwd, tunnel):
|
|
# different --proxy-tls13-ciphers, no reuse of connection for https:
|
|
curl = CurlClient(env=env)
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
url = f'https://localhost:{env.https_port}/data.json'
|
|
proxy_args = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r1 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=proxy_args)
|
|
r1.check_response(count=1, http_status=200)
|
|
assert self.get_tunnel_proto_used(r1) == tunnel
|
|
# get the args, duplicate separated with '--next'
|
|
x2_args = r1.args[1:]
|
|
x2_args.append('--next')
|
|
x2_args.extend(proxy_args)
|
|
x2_args.extend(['--proxy-tls13-ciphers', 'TLS_AES_256_GCM_SHA384'])
|
|
r2 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=x2_args)
|
|
r2.check_response(count=2, http_status=200)
|
|
assert r2.total_connects == 2
|
|
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_uses_lib('openssl'), reason="tls13-ciphers not supported")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_12_noreuse_proxy_http(self, env: Env, httpd, nghttpx_fwd, tunnel):
|
|
# different --proxy-tls13-ciphers, no reuse of connection for http:
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
proxy_args = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r1 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=proxy_args)
|
|
r1.check_response(count=1, http_status=200)
|
|
assert self.get_tunnel_proto_used(r1) == tunnel
|
|
# get the args, duplicate separated with '--next'
|
|
x2_args = r1.args[1:]
|
|
x2_args.append('--next')
|
|
x2_args.extend(proxy_args)
|
|
x2_args.extend(['--proxy-tls13-ciphers', 'TLS_AES_256_GCM_SHA384'])
|
|
r2 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=x2_args)
|
|
r2.check_response(count=2, http_status=200)
|
|
assert r2.total_connects == 2
|
|
|
|
@pytest.mark.skipif(condition=not Env.have_ssl_curl(), reason="curl without SSL")
|
|
@pytest.mark.parametrize("tunnel", Env.http_h1_h2_protos())
|
|
@pytest.mark.skipif(condition=not Env.have_nghttpx(), reason="no nghttpx available")
|
|
@pytest.mark.skipif(condition=not Env.curl_uses_lib('openssl'), reason="tls13-ciphers not supported")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_debug(), reason="needs curl debug")
|
|
@pytest.mark.skipif(condition=not Env.curl_is_verbose(), reason="needs curl verbose strings")
|
|
def test_10_13_noreuse_https(self, env: Env, httpd, nghttpx_fwd, tunnel):
|
|
# different --tls13-ciphers on https: same proxy config
|
|
if tunnel == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url = f'https://localhost:{env.https_port}/data.json'
|
|
proxy_args = curl.get_proxy_args(tunnel=True, proto=tunnel)
|
|
r1 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=proxy_args)
|
|
r1.check_response(count=1, http_status=200)
|
|
assert self.get_tunnel_proto_used(r1) == tunnel
|
|
# get the args, duplicate separated with '--next'
|
|
x2_args = r1.args[1:]
|
|
x2_args.append('--next')
|
|
x2_args.extend(proxy_args)
|
|
x2_args.extend(['--tls13-ciphers', 'TLS_AES_256_GCM_SHA384'])
|
|
r2 = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=x2_args)
|
|
r2.check_response(count=2, http_status=200)
|
|
assert r2.total_connects == 2
|
|
|
|
# download via https: proxy (no tunnel) using IP address
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('HTTPS-proxy'),
|
|
reason='curl lacks HTTPS-proxy support')
|
|
@pytest.mark.parametrize("proto", Env.http_h1_h2_protos())
|
|
def test_10_14_proxys_ip_addr(self, env: Env, httpd, proto):
|
|
if proto == 'h2' and not env.curl_uses_lib('nghttp2'):
|
|
pytest.skip('only supported with nghttp2')
|
|
curl = CurlClient(env=env)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(proto=proto, use_ip=True)
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
if env.curl_uses_lib('mbedtls') and \
|
|
not env.curl_lib_version_at_least('mbedtls', '3.5.0'):
|
|
r.check_exit_code(60) # CURLE_PEER_FAILED_VERIFICATION
|
|
else:
|
|
r.check_response(count=1, http_status=200,
|
|
protocol='HTTP/2' if proto == 'h2' else 'HTTP/1.1')
|
|
|
|
# download via http: ipv4 proxy (no tunnel) using IP address, IPv6 only
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('IPv6'),
|
|
reason='no ipv6 support')
|
|
def test_10_15_proxy_ip_addr(self, env: Env, httpd):
|
|
proto = 'http/1.1'
|
|
curl = CurlClient(env=env, force_resolv=False)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(proto=proto, use_ip=True, proxys=False)
|
|
xargs.append('-6')
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_exit_code(0)
|
|
r.check_response(count=1, http_status=200, protocol='HTTP/1.1')
|
|
|
|
# download via http: ipv6 proxy (no tunnel) using IP address, IPv4 only
|
|
@pytest.mark.skipif(condition=not Env.curl_has_feature('IPv6'),
|
|
reason='no ipv6 support')
|
|
def test_10_16_proxy_ip_addr(self, env: Env, httpd):
|
|
proto = 'http/1.1'
|
|
curl = CurlClient(env=env, force_resolv=False)
|
|
url = f'http://localhost:{env.http_port}/data.json'
|
|
xargs = curl.get_proxy_args(proto=proto, use_ipv6=True, proxys=False)
|
|
xargs.append('-4')
|
|
r = curl.http_download(urls=[url], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=xargs)
|
|
r.check_exit_code(0)
|
|
r.check_response(count=1, http_status=200, protocol='HTTP/1.1')
|
|
|
|
# download via http: proxy (no tunnel), check connection reuse
|
|
def test_10_17_proxy_http(self, env: Env, httpd):
|
|
curl = CurlClient(env=env)
|
|
url1 = f'http://localhost:{env.http_port}/data.json'
|
|
url2 = f'http://127.0.0.1:{env.http_port}/data.json'
|
|
r = curl.http_download(urls=[url1, url2], alpn_proto='http/1.1', with_stats=True,
|
|
extra_args=curl.get_proxy_args(proxys=False))
|
|
r.check_response(count=2, http_status=200)
|
|
assert r.total_connects == 1, r.dump_logs()
|