mirror of
https://github.com/open-goal/jak-project
synced 2026-08-21 14:54:53 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
131 lines
3.4 KiB
Makefile
Vendored
Generated
131 lines
3.4 KiB
Makefile
Vendored
Generated
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
# Shared between CMakeLists.txt and Makefile.am
|
|
|
|
man_MANS = \
|
|
curl_easy_cleanup.3 \
|
|
curl_easy_duphandle.3 \
|
|
curl_easy_escape.3 \
|
|
curl_easy_getinfo.3 \
|
|
curl_easy_header.3 \
|
|
curl_easy_init.3 \
|
|
curl_easy_nextheader.3 \
|
|
curl_easy_option_by_id.3 \
|
|
curl_easy_option_by_name.3 \
|
|
curl_easy_option_next.3 \
|
|
curl_easy_pause.3 \
|
|
curl_easy_perform.3 \
|
|
curl_easy_recv.3 \
|
|
curl_easy_reset.3 \
|
|
curl_easy_send.3 \
|
|
curl_easy_setopt.3 \
|
|
curl_easy_ssls_export.3 \
|
|
curl_easy_ssls_import.3 \
|
|
curl_easy_strerror.3 \
|
|
curl_easy_unescape.3 \
|
|
curl_easy_upkeep.3 \
|
|
curl_escape.3 \
|
|
curl_formadd.3 \
|
|
curl_formfree.3 \
|
|
curl_formget.3 \
|
|
curl_free.3 \
|
|
curl_getdate.3 \
|
|
curl_getenv.3 \
|
|
curl_global_cleanup.3 \
|
|
curl_global_init.3 \
|
|
curl_global_init_mem.3 \
|
|
curl_global_sslset.3 \
|
|
curl_global_trace.3 \
|
|
curl_mime_addpart.3 \
|
|
curl_mime_data.3 \
|
|
curl_mime_data_cb.3 \
|
|
curl_mime_encoder.3 \
|
|
curl_mime_filedata.3 \
|
|
curl_mime_filename.3 \
|
|
curl_mime_free.3 \
|
|
curl_mime_headers.3 \
|
|
curl_mime_init.3 \
|
|
curl_mime_name.3 \
|
|
curl_mime_subparts.3 \
|
|
curl_mime_type.3 \
|
|
curl_mprintf.3 \
|
|
curl_multi_add_handle.3 \
|
|
curl_multi_assign.3 \
|
|
curl_multi_cleanup.3 \
|
|
curl_multi_fdset.3 \
|
|
curl_multi_get_handles.3 \
|
|
curl_multi_get_offt.3 \
|
|
curl_multi_info_read.3 \
|
|
curl_multi_init.3 \
|
|
curl_multi_notify_disable.3 \
|
|
curl_multi_notify_enable.3 \
|
|
curl_multi_perform.3 \
|
|
curl_multi_poll.3 \
|
|
curl_multi_remove_handle.3 \
|
|
curl_multi_setopt.3 \
|
|
curl_multi_socket.3 \
|
|
curl_multi_socket_action.3 \
|
|
curl_multi_socket_all.3 \
|
|
curl_multi_strerror.3 \
|
|
curl_multi_timeout.3 \
|
|
curl_multi_wait.3 \
|
|
curl_multi_waitfds.3 \
|
|
curl_multi_wakeup.3 \
|
|
curl_pushheader_byname.3 \
|
|
curl_pushheader_bynum.3 \
|
|
curl_share_cleanup.3 \
|
|
curl_share_init.3 \
|
|
curl_share_setopt.3 \
|
|
curl_share_strerror.3 \
|
|
curl_slist_append.3 \
|
|
curl_slist_free_all.3 \
|
|
curl_strequal.3 \
|
|
curl_strnequal.3 \
|
|
curl_unescape.3 \
|
|
curl_url.3 \
|
|
curl_url_cleanup.3 \
|
|
curl_url_dup.3 \
|
|
curl_url_get.3 \
|
|
curl_url_set.3 \
|
|
curl_url_strerror.3 \
|
|
curl_version.3 \
|
|
curl_version_info.3 \
|
|
curl_ws_meta.3 \
|
|
curl_ws_recv.3 \
|
|
curl_ws_send.3 \
|
|
curl_ws_start_frame.3 \
|
|
libcurl-easy.3 \
|
|
libcurl-env-dbg.3 \
|
|
libcurl-env.3 \
|
|
libcurl-errors.3 \
|
|
libcurl-multi.3 \
|
|
libcurl-security.3 \
|
|
libcurl-share.3 \
|
|
libcurl-symbols.3 \
|
|
libcurl-thread.3 \
|
|
libcurl-tutorial.3 \
|
|
libcurl-url.3 \
|
|
libcurl-ws.3 \
|
|
libcurl.3
|