mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 06:16:35 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
111 lines
4.5 KiB
C
Vendored
Generated
111 lines
4.5 KiB
C
Vendored
Generated
#ifndef HEADER_CURL_PEER_H
|
|
#define HEADER_CURL_PEER_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
struct Curl_scheme;
|
|
struct urlpieces;
|
|
|
|
/* if peer hostname starts with this, the peer is a unix domain socket
|
|
* path, e.g. the remainder after 'localhost'. */
|
|
#define CURL_PEER_UDS_PREFIX "localhost/"
|
|
|
|
struct Curl_peer {
|
|
const struct Curl_scheme *scheme; /* url scheme */
|
|
char *hostname; /* normalized hostname (IDN decoded when supported) */
|
|
char *zoneid; /* NULL or ipv6 zone identifier */
|
|
uint32_t refcount; /* created with 1, freed when dropping to 0 */
|
|
uint32_t scopeid; /* != 0, ipv6 scope to use */
|
|
uint16_t port;
|
|
BIT(unix_socket); /* hostname is a UDS path without the prefix */
|
|
BIT(abstract_uds); /* only TRUE when `unix_socket` also TRUE */
|
|
BIT(ipv6); /* hostname is an IPv6 address stripped of '[]' */
|
|
char user_hostname[1]; /* hostname supplied by user/url */
|
|
};
|
|
|
|
/* Create a new peer:
|
|
* - `peer->user_hostname` is the passed `hostname`
|
|
* - `peer->hostname` is the normalized `hostname` via
|
|
* + IDN conversion if it has non-ASCII characters
|
|
* + stripping of surrounding '[]' for URL formatted ipv6 addresses
|
|
* + the path alone in case of a unix domain socket, e.g. hostname
|
|
* starts with CURL_PEER_UDS_PREFIX and is longer
|
|
* Scans for IPv6 addresses even without surrounding '[]'.
|
|
* - `zoneid` ipv6 zone identifier or NULL
|
|
* - `scopeid` ipv6 scopeid of zoneid, when known.
|
|
*/
|
|
CURLcode Curl_peer_create(struct Curl_easy *data,
|
|
const struct Curl_scheme *scheme,
|
|
const char *hostname,
|
|
uint16_t port,
|
|
struct Curl_peer **ppeer);
|
|
|
|
#ifdef USE_UNIX_SOCKETS
|
|
CURLcode Curl_peer_uds_create(const struct Curl_scheme *scheme,
|
|
const char *path,
|
|
bool abstract_unix_socket,
|
|
struct Curl_peer **ppeer);
|
|
#endif
|
|
|
|
/* Unlink any peer in `*pdest`, assign src, increase src
|
|
* refcount when not NULL. */
|
|
void Curl_peer_link(struct Curl_peer **pdest, struct Curl_peer *src);
|
|
|
|
/* Drop a reference, peer may be passed as NULL */
|
|
void Curl_peer_unlink(struct Curl_peer **ppeer);
|
|
|
|
/* TRUE if both peers are NULL or have completely same properties. */
|
|
bool Curl_peer_equal(struct Curl_peer *p1, struct Curl_peer *p2);
|
|
|
|
/* TRUE if both peers are NULL or have same properties except the scheme. */
|
|
bool Curl_peer_same_destination(struct Curl_peer *p1, struct Curl_peer *p2);
|
|
|
|
CURLcode Curl_peer_from_url(CURLU *uh, struct Curl_easy *data,
|
|
uint16_t port_override,
|
|
uint32_t scopeid_override,
|
|
struct urlpieces *up,
|
|
struct Curl_peer **ppeer);
|
|
|
|
CURLcode Curl_peer_from_connect_to(struct Curl_easy *data,
|
|
const struct Curl_peer *dest,
|
|
const char *connect_to,
|
|
struct Curl_peer **ppeer);
|
|
|
|
#ifndef CURL_DISABLE_PROXY
|
|
|
|
CURLcode Curl_scheme_to_proxytype(struct Curl_easy *data,
|
|
const char *scheme,
|
|
uint8_t *proxytype,
|
|
const char *url);
|
|
|
|
CURLcode Curl_peer_from_proxy_url(CURLU *uh,
|
|
struct Curl_easy *data,
|
|
const char *url,
|
|
uint8_t proxytype,
|
|
struct Curl_peer **ppeer,
|
|
uint8_t *pproxytype);
|
|
#endif /* !CURL_DISABLE_PROXY */
|
|
|
|
#endif /* HEADER_CURL_PEER_H */
|