mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 06:16:35 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
97 lines
3.9 KiB
C
Vendored
Generated
97 lines
3.9 KiB
C
Vendored
Generated
#ifndef HEADER_CURL_UINT_TABLE_H
|
|
#define HEADER_CURL_UINT_TABLE_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curl_setup.h"
|
|
|
|
/* Destructor for a single table entry */
|
|
typedef void Curl_uint32_tbl_entry_dtor(uint32_t key, void *entry);
|
|
|
|
struct uint32_tbl {
|
|
void **rows; /* array of void* holding entries */
|
|
Curl_uint32_tbl_entry_dtor *entry_dtor;
|
|
uint32_t nrows; /* length of `rows` array */
|
|
uint32_t nentries; /* entries in table */
|
|
uint32_t last_key_added; /* UINT_MAX or last key added */
|
|
#ifdef DEBUGBUILD
|
|
int init;
|
|
#endif
|
|
};
|
|
|
|
/* Initialize the table with 0 capacity.
|
|
* The optional `entry_dtor` is called when a table entry is removed,
|
|
* Passing NULL means no action is taken on removal. */
|
|
void Curl_uint32_tbl_init(struct uint32_tbl *tbl,
|
|
Curl_uint32_tbl_entry_dtor *entry_dtor);
|
|
|
|
/* Resize the table to change capacity `nmax`. When `nmax` is reduced,
|
|
* all present entries with key equal or larger to `nmax` are removed. */
|
|
CURLcode Curl_uint32_tbl_resize(struct uint32_tbl *tbl, uint32_t nrows);
|
|
|
|
/* Destroy the table, freeing all entries. */
|
|
void Curl_uint32_tbl_destroy(struct uint32_tbl *tbl);
|
|
|
|
/* Get the table capacity. */
|
|
uint32_t Curl_uint32_tbl_capacity(struct uint32_tbl *tbl);
|
|
|
|
/* Get the number of entries in the table. */
|
|
uint32_t Curl_uint32_tbl_count(struct uint32_tbl *tbl);
|
|
|
|
/* Get the entry for key or NULL if not present */
|
|
void *Curl_uint32_tbl_get(struct uint32_tbl *tbl, uint32_t key);
|
|
|
|
/* Add a new entry to the table and assign it a free key.
|
|
* Returns FALSE if the table is full.
|
|
*
|
|
* Keys are assigned in a round-robin manner.
|
|
* No matter the capacity, UINT_MAX is never assigned. */
|
|
bool Curl_uint32_tbl_add(struct uint32_tbl *tbl, void *entry, uint32_t *pkey);
|
|
|
|
/* Remove the entry with `key`. */
|
|
void Curl_uint32_tbl_remove(struct uint32_tbl *tbl, uint32_t key);
|
|
|
|
/* Return TRUE if the table contains an tryn with that keys. */
|
|
bool Curl_uint32_tbl_contains(struct uint32_tbl *tbl, uint32_t key);
|
|
|
|
/* Get the first entry in the table (with the smallest `key`).
|
|
* Returns FALSE if the table is empty. */
|
|
bool Curl_uint32_tbl_first(struct uint32_tbl *tbl,
|
|
uint32_t *pkey, void **pentry);
|
|
|
|
/* Get the next key in the table, following `last_key` in natural order.
|
|
* Put another way, this is the smallest key greater than `last_key` in
|
|
* the table. `last_key` does not have to be present in the table.
|
|
*
|
|
* Returns FALSE when no such entry is in the table.
|
|
*
|
|
* This allows to iterate the table while being modified:
|
|
* - added keys higher than 'last_key' will be picked up by the iteration.
|
|
* - added keys lower than 'last_key' will not show up.
|
|
* - removed keys lower or equal to 'last_key' will not show up.
|
|
* - removed keys higher than 'last_key' will not be visited. */
|
|
bool Curl_uint32_tbl_next(struct uint32_tbl *tbl, uint32_t last_key,
|
|
uint32_t *pkey, void **pentry);
|
|
|
|
#endif /* HEADER_CURL_UINT_TABLE_H */
|