mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 06:16:35 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
136 lines
2.6 KiB
Plaintext
Vendored
Generated
136 lines
2.6 KiB
Plaintext
Vendored
Generated
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
# whitelisted uses of bad words (case insensitive) can be done in two ways,
|
|
# globally and per-file.
|
|
#
|
|
# ---[word]
|
|
# ---:[file]:[word]
|
|
#
|
|
back-end:backend
|
|
e-mail:email
|
|
run-time:runtime
|
|
set-up:setup
|
|
tool chain:toolchain
|
|
tool-chain:toolchain
|
|
well known:well-known
|
|
wild-card:wildcard
|
|
wild card:wildcard
|
|
threadsafe:thread-safe
|
|
thread safe:thread-safe
|
|
thread safety:thread-safety
|
|
thread unsafe:thread-unsafe
|
|
multi thread:multi-thread
|
|
nul terminate:null-terminate
|
|
null terminate:null-terminate
|
|
zero terminate:null-terminate
|
|
nul terminated:null-terminated
|
|
null terminated:null-terminated
|
|
NULL-terminated=null-terminated
|
|
zero terminated:null-terminated
|
|
zero-terminated:null-terminated
|
|
nul terminator:null-terminator
|
|
null terminator:null-terminator
|
|
zero terminator:null-terminator
|
|
work-around:workaround or work around
|
|
work-arounds:workarounds or works around
|
|
it's:it is
|
|
aren't:are not
|
|
can't:cannot
|
|
could've:could have
|
|
couldn't:could not
|
|
didn't:did not
|
|
doesn't:does not
|
|
don't:do not
|
|
haven't:have not
|
|
i'd:I would
|
|
i'll:I will
|
|
i'm:I am
|
|
i've:I have
|
|
isn't:is not
|
|
it'd:it would
|
|
it'll:it will
|
|
might've:might have
|
|
needn't:need not
|
|
should've:should have
|
|
shouldn't:should not
|
|
that's:that is
|
|
there's:there is
|
|
they'd:They would
|
|
they'll:They will
|
|
they're:They are
|
|
they've:They have
|
|
this'll:this will
|
|
wasn't:was not
|
|
we'd:we would
|
|
we'll:we will
|
|
we're:we are
|
|
we've:we have
|
|
weren't:were not
|
|
won't:will not
|
|
would've:would have
|
|
wouldn't:would not
|
|
you'd:you would
|
|
you'll:you will
|
|
you're:you are
|
|
you've:you have
|
|
a html:an html
|
|
a http:an http
|
|
a ftp:an ftp
|
|
a IPv4:an IPv4
|
|
a IPv6:an IPv6
|
|
url= URL
|
|
internet=Internet
|
|
isation:ization
|
|
So=Rewrite it somehow?
|
|
And=Rewrite it somehow?
|
|
But=Rewrite it somehow?
|
|
sub-directory:subdirectory
|
|
web page:webpage
|
|
host name:hostname
|
|
host names:hostnames
|
|
file name:filename
|
|
file names:filenames
|
|
fist:first
|
|
user name:username
|
|
user names:usernames
|
|
pass phrase:passphrase
|
|
will:rewrite to present tense
|
|
7 bit:7-bit
|
|
8 bit:8-bit
|
|
16 bit:16-bit
|
|
24 bit:24-bit
|
|
32 bit:32-bit
|
|
56 bit:56-bit
|
|
63 bit:63-bit
|
|
64 bit:64-bit
|
|
128 bit:128-bit
|
|
256 bit:256-bit
|
|
8-bits:8 bits
|
|
16-bits:16 bits
|
|
32-bits:32 bits
|
|
64-bits:64 bits
|
|
initialise:initialize
|
|
initialising:initializing
|
|
very:rephrase using an alternative word
|
|
just:rephrase using an alternative word
|
|
simply:rephrase using an alternative word
|
|
Curl=curl
|
|
cURL=curl
|
|
Libcurl=libcurl
|
|
LibCurl=libcurl
|
|
manpages:man pages
|
|
manpage:man page
|
|
favour:favor
|
|
basically:rephrase?
|
|
However,:rephrase?
|
|
the the:the
|
|
with with:with
|
|
---WWW::Curl
|
|
---NET::Curl
|
|
---Curl Corporation
|
|
---:lib/:will
|
|
---:src/:will
|
|
---:tests/data/:file name
|