mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 06:16:35 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
186 lines
4.3 KiB
Makefile
Vendored
Generated
186 lines
4.3 KiB
Makefile
Vendored
Generated
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
|
|
# scripts used in test cases
|
|
TESTSCRIPTS = \
|
|
test1119.pl \
|
|
test1135.pl \
|
|
test1139.pl \
|
|
test1140.pl \
|
|
test1165.pl \
|
|
test1167.pl \
|
|
test1173.pl \
|
|
test1175.pl \
|
|
test1177.pl \
|
|
test1222.pl \
|
|
test1275.pl \
|
|
test1276.pl \
|
|
test1477.pl \
|
|
test1486.pl \
|
|
test1488.pl \
|
|
test1544.pl \
|
|
test1707.pl \
|
|
test745.pl \
|
|
test971.pl
|
|
|
|
EXTRA_DIST = \
|
|
CMakeLists.txt \
|
|
allversions.pm \
|
|
appveyor.pm \
|
|
azure.pm \
|
|
devtest.pl \
|
|
dictserver.py \
|
|
directories.pm \
|
|
ech_combos.py \
|
|
ech_tests.sh \
|
|
ftpserver.pl \
|
|
getpart.pm \
|
|
globalconfig.pm \
|
|
http-server.pl \
|
|
http2-server.pl \
|
|
http3-server.pl \
|
|
memanalyze.pl \
|
|
memanalyzer.pm \
|
|
negtelnetserver.py \
|
|
nghttpx.conf \
|
|
pathhelp.pm \
|
|
processhelp.pm \
|
|
requirements.txt \
|
|
rtspserver.pl \
|
|
runner.pm \
|
|
runtests.pl \
|
|
secureserver.pl \
|
|
serverhelp.pm \
|
|
servers.pm \
|
|
smbserver.py \
|
|
sshhelp.pm \
|
|
sshserver.pl \
|
|
testcurl.pl \
|
|
testutil.pm \
|
|
tftpserver.pl \
|
|
util.py \
|
|
valgrind.pm \
|
|
valgrind.supp \
|
|
$(TESTSCRIPTS)
|
|
|
|
# we have two variables here to make sure DIST_SUBDIRS does not get 'unit'
|
|
# added twice as then targets such as 'distclean' misbehave and try to
|
|
# do things twice in that subdir at times (and thus fails).
|
|
if BUILD_UNITTESTS
|
|
BUILD_UNIT = unit tunit
|
|
DIST_UNIT =
|
|
else
|
|
BUILD_UNIT =
|
|
DIST_UNIT = unit tunit
|
|
endif
|
|
|
|
SUBDIRS = certs data server libtest http $(BUILD_UNIT)
|
|
DIST_SUBDIRS = $(SUBDIRS) $(DIST_UNIT)
|
|
|
|
PERLFLAGS = -I$(srcdir)
|
|
|
|
CLEANFILES = .http.pid .https.pid .ftp.pid .ftps.pid
|
|
|
|
curl:
|
|
@cd $(top_builddir) && $(MAKE)
|
|
|
|
TEST_COMMON =
|
|
|
|
if CROSSCOMPILING
|
|
TEST = @echo "NOTICE: we cannot run the tests when cross-compiling!"
|
|
PYTEST = $(TEST)
|
|
else # if not cross-compiling:
|
|
|
|
if BUILD_DOCS
|
|
else
|
|
TEST_COMMON += !documentation
|
|
endif
|
|
|
|
TEST = srcdir=$(srcdir) @PERL@ $(PERLFLAGS) $(srcdir)/runtests.pl $(TEST_COMMON)
|
|
TEST_Q = -a -s
|
|
TEST_AM = -a -am
|
|
TEST_F = -a -p -r
|
|
TEST_T = -a -t -j20
|
|
TEST_E = -a -e
|
|
|
|
# ~<keyword> means that it runs all tests matching the keyword, but ignores
|
|
# their results (since these ones are likely to fail for no good reason)
|
|
TEST_NF = -a -p ~flaky ~timing-dependent
|
|
|
|
# special target for CI use
|
|
TEST_CI = $(TEST_NF) -r --retry=5 -j20 --buildinfo
|
|
|
|
PYTEST = pytest
|
|
endif
|
|
|
|
# make sure that PERL is pointing to an executable
|
|
perlcheck:
|
|
@if ! test -x "@PERL@"; then echo "No perl!"; exit 2; fi
|
|
|
|
build-certs: perlcheck
|
|
(cd certs && $(MAKE))
|
|
|
|
# alias for 'test' to match CMake, where 'test' is a reserved target
|
|
tests: test
|
|
|
|
test: perlcheck all
|
|
$(TEST) $(TFLAGS)
|
|
|
|
quiet-test: perlcheck all
|
|
$(TEST) $(TEST_Q) $(TFLAGS)
|
|
|
|
am-test: perlcheck all
|
|
$(TEST) $(TEST_AM) $(TFLAGS)
|
|
|
|
ci-test: perlcheck all
|
|
$(TEST) $(TEST_CI) $(TFLAGS)
|
|
|
|
full-test: perlcheck all
|
|
$(TEST) $(TEST_F) $(TFLAGS)
|
|
|
|
nonflaky-test: perlcheck all
|
|
$(TEST) $(TEST_NF) $(TFLAGS)
|
|
|
|
torture-test: perlcheck all
|
|
$(TEST) $(TEST_T) $(TFLAGS)
|
|
|
|
event-test: perlcheck all
|
|
$(TEST) $(TEST_E) $(TFLAGS)
|
|
|
|
default-pytest: ci-pytest
|
|
|
|
ci-pytest: all
|
|
srcdir=$(srcdir) $(PYTEST) -n auto -v $(srcdir)/http
|
|
|
|
checksrc:
|
|
(cd libtest && $(MAKE) checksrc)
|
|
(cd unit && $(MAKE) checksrc)
|
|
(cd tunit && $(MAKE) checksrc)
|
|
(cd server && $(MAKE) checksrc)
|
|
|
|
all-local: $(MANFILES) build-certs
|
|
|
|
distclean:
|
|
rm -f $(MANFILES)
|