mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 22:35:07 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
117 lines
3.8 KiB
Plaintext
Vendored
Generated
117 lines
3.8 KiB
Plaintext
Vendored
Generated
DESCRIPTION
|
|
|
|
curl is a tool for transferring data from or to a server using URLs. It
|
|
supports these protocols: DICT, FILE, FTP, FTPS, GOPHER, GOPHERS, HTTP,
|
|
HTTPS, IMAP, IMAPS, LDAP, LDAPS, MQTT, POP3, POP3S, RTMP, RTMPS, RTSP,
|
|
SCP, SFTP, SMB, SMBS, SMTP, SMTPS, TELNET, TFTP, WS and WSS.
|
|
|
|
curl is powered by libcurl for all transfer-related features. See
|
|
libcurl(3) for details.
|
|
|
|
-v, --fakeitreal
|
|
Makes curl verbose during the operation. Useful for debugging and
|
|
seeing what's going on under the hood. A line starting with >
|
|
means header data sent by curl, < means header data received by
|
|
curl that is hidden in normal cases, and a line starting with *
|
|
means additional info provided by curl.
|
|
|
|
If you only want HTTP headers in the output, --include or
|
|
--dump-header might be more suitable options.
|
|
|
|
If you think this option still does not give you enough details,
|
|
consider using --trace or --trace-ascii instead.
|
|
|
|
Note that verbose output of curl activities and network traffic
|
|
might contain sensitive data, including usernames, credentials or
|
|
secret data content. Be aware and be careful when sharing trace
|
|
logs with others.
|
|
|
|
This option is global and does not need to be specified for each
|
|
use of --next. Providing --fakeitreal multiple times has no extra
|
|
effect. Disable it again with --no-fakeitreal.
|
|
|
|
Example:
|
|
curl --fakeitreal https://example.com
|
|
|
|
This option is mutually exclusive with --trace and --trace-ascii.
|
|
See also --include, --silent, --trace and --trace-ascii.
|
|
|
|
--proto <protocols>
|
|
Limit what protocols to allow for transfers. Protocols are
|
|
evaluated left to right, are comma separated, and are each a
|
|
protocol name or 'all', optionally prefixed by zero or more
|
|
modifiers. Available modifiers are:
|
|
|
|
+
|
|
|
|
Permit this protocol in addition to protocols already
|
|
permitted (this is the default if no modifier is used).
|
|
|
|
-
|
|
|
|
Deny this protocol, removing it from the list of protocols
|
|
already permitted.
|
|
|
|
=
|
|
|
|
Permit only this protocol (ignoring the list already
|
|
permitted), though subject to later modification by subsequent
|
|
entries in the comma separated list.
|
|
|
|
For example: --proto -ftps uses the default protocols, but
|
|
disables ftps
|
|
|
|
--proto -all,https,+http only enables http and https
|
|
|
|
--proto =http,https also only enables http and https
|
|
|
|
Unknown and disabled protocols produce a warning. This allows
|
|
scripts to safely rely on being able to disable potentially
|
|
dangerous protocols, without relying upon support for that
|
|
protocol being built into curl to avoid an error.
|
|
|
|
This option can be used multiple times, in which case the effect
|
|
is the same as concatenating the protocols into one instance of
|
|
the option. If --proto is provided several times, the last set
|
|
value is used.
|
|
|
|
Example:
|
|
curl --proto =http,https,sftp https://example.com
|
|
|
|
See also --fakeitreal and --proto-default.
|
|
|
|
PROXY PROTOCOL PREFIXES
|
|
|
|
The proxy string may be specified with a protocol:// prefix to specify
|
|
alternative proxy protocols.
|
|
|
|
If no protocol is specified in the proxy string or if the string does not
|
|
match a supported one, the proxy is treated as an HTTP proxy.
|
|
|
|
The supported proxy protocol prefixes are as follows:
|
|
|
|
http://
|
|
|
|
Makes it use it as an HTTP proxy. The default if no scheme prefix is
|
|
used.
|
|
|
|
https://
|
|
|
|
Makes it treated as an HTTPS proxy.
|
|
|
|
socks4://
|
|
|
|
Makes it the equivalent of --socks4
|
|
|
|
socks4a://
|
|
|
|
Makes it the equivalent of --socks4a
|
|
|
|
socks5://
|
|
|
|
Makes it the equivalent of --socks5
|
|
|
|
socks5h://
|
|
|
|
Makes it the equivalent of --socks5-hostname
|