mirror of
https://github.com/open-goal/jak-project
synced 2026-08-20 22:35:07 -04:00
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
148 lines
4.5 KiB
C
Vendored
Generated
148 lines
4.5 KiB
C
Vendored
Generated
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "first.h"
|
|
|
|
struct t1541_transfer_status {
|
|
CURL *curl;
|
|
int hd_count;
|
|
int bd_count;
|
|
};
|
|
|
|
#define KN(a) a, #a
|
|
|
|
static void t1541_geterr(const char *name, CURLcode val, int lineno)
|
|
{
|
|
curl_mprintf("CURLINFO_%s returned %d, \"%s\" on line %d\n",
|
|
name, (int)val, curl_easy_strerror(val), lineno);
|
|
}
|
|
|
|
static void report_time(const char *key, const char *where, curl_off_t time,
|
|
bool ok)
|
|
{
|
|
if(ok)
|
|
curl_mprintf("%s on %s is OK\n", key, where);
|
|
else
|
|
curl_mprintf("%s on %s is WRONG: %" CURL_FORMAT_CURL_OFF_T "\n",
|
|
key, where, time);
|
|
}
|
|
|
|
static void check_time(CURL *curl, int key, const char *name,
|
|
const char *where)
|
|
{
|
|
curl_off_t tval;
|
|
CURLcode result = curl_easy_getinfo(curl, (CURLINFO)key, &tval);
|
|
if(result) {
|
|
t1541_geterr(name, result, __LINE__);
|
|
}
|
|
else
|
|
report_time(name, where, tval, tval > 0);
|
|
}
|
|
|
|
static void check_time0(CURL *curl, int key, const char *name,
|
|
const char *where)
|
|
{
|
|
curl_off_t tval;
|
|
CURLcode result = curl_easy_getinfo(curl, (CURLINFO)key, &tval);
|
|
if(result) {
|
|
t1541_geterr(name, result, __LINE__);
|
|
}
|
|
else
|
|
report_time(name, where, tval, !tval);
|
|
}
|
|
|
|
static size_t t1541_header_callback(char *ptr, size_t size, size_t nmemb,
|
|
void *userp)
|
|
{
|
|
struct t1541_transfer_status *st = (struct t1541_transfer_status *)userp;
|
|
size_t len = size * nmemb;
|
|
|
|
(void)ptr;
|
|
if(!st->hd_count++) {
|
|
/* first header, check some CURLINFO value to be reported. See #13125 */
|
|
check_time(st->curl, KN(CURLINFO_CONNECT_TIME_T), "1st header");
|
|
check_time(st->curl, KN(CURLINFO_PRETRANSFER_TIME_T), "1st header");
|
|
check_time(st->curl, KN(CURLINFO_STARTTRANSFER_TIME_T), "1st header");
|
|
/* continuously updated */
|
|
check_time(st->curl, KN(CURLINFO_TOTAL_TIME_T), "1st header");
|
|
/* no SSL, must be 0 */
|
|
check_time0(st->curl, KN(CURLINFO_APPCONNECT_TIME_T), "1st header");
|
|
/* download not really started */
|
|
check_time0(st->curl, KN(CURLINFO_SPEED_DOWNLOAD_T), "1st header");
|
|
}
|
|
(void)fwrite(ptr, size, nmemb, stdout);
|
|
return len;
|
|
}
|
|
|
|
static size_t t1541_write_cb(char *ptr, size_t size, size_t nmemb, void *userp)
|
|
{
|
|
struct t1541_transfer_status *st = (struct t1541_transfer_status *)userp;
|
|
|
|
(void)ptr;
|
|
(void)st;
|
|
fwrite(ptr, size, nmemb, stdout);
|
|
return size * nmemb;
|
|
}
|
|
|
|
static CURLcode test_lib1541(const char *URL)
|
|
{
|
|
CURL *curl = NULL;
|
|
CURLcode result = CURLE_OK;
|
|
struct t1541_transfer_status st;
|
|
|
|
start_test_timing();
|
|
|
|
memset(&st, 0, sizeof(st));
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
|
|
easy_init(curl);
|
|
st.curl = curl; /* to allow callbacks access */
|
|
|
|
easy_setopt(curl, CURLOPT_URL, URL);
|
|
easy_setopt(curl, CURLOPT_WRITEFUNCTION, t1541_write_cb);
|
|
easy_setopt(curl, CURLOPT_WRITEDATA, &st);
|
|
easy_setopt(curl, CURLOPT_HEADERFUNCTION, t1541_header_callback);
|
|
easy_setopt(curl, CURLOPT_HEADERDATA, &st);
|
|
|
|
easy_setopt(curl, CURLOPT_NOPROGRESS, 0L);
|
|
|
|
result = curl_easy_perform(curl);
|
|
|
|
check_time(curl, KN(CURLINFO_CONNECT_TIME_T), "done");
|
|
check_time(curl, KN(CURLINFO_PRETRANSFER_TIME_T), "done");
|
|
check_time(curl, KN(CURLINFO_POSTTRANSFER_TIME_T), "done");
|
|
check_time(curl, KN(CURLINFO_STARTTRANSFER_TIME_T), "done");
|
|
/* no SSL, must be 0 */
|
|
check_time0(curl, KN(CURLINFO_APPCONNECT_TIME_T), "done");
|
|
check_time(curl, KN(CURLINFO_SPEED_DOWNLOAD_T), "done");
|
|
check_time(curl, KN(CURLINFO_TOTAL_TIME_T), "done");
|
|
|
|
test_cleanup:
|
|
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return result; /* return the final return code */
|
|
}
|