Files
jak-project/third-party/curl/tests/libtest/lib753.c
T
Alexander J. Semenuk 5d5e35fb9b fix: Windows toolchain compatibility (curl 8.21 re-vendor, endless reconfigure loop) (#4355)
## Problem

Windows builds break with a current local toolchain (Scoop LLVM 22.1.8,
CMake 4.4.0, VS 2026), in two independent ways:

1. The build stops at curl's deliberate guard: `#error "no non-blocking
method was found/used/set"` in `third-party/curl/lib/nonblock.c`.
2. From the second configure onward, `cmake --build` re-runs CMake in an
endless loop (observed 42 consecutive reconfigure cycles in a single
build). Likely the same mechanism behind the "endlessly building" VS
2026 note in `docs/setup/dev/vs.md`.

## Root cause

1. `third-party/curl/CMake/CurlTests.c` passes `int *` to
`ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes
`-Wincompatible-pointer-types` to a hard error in C, so the
`HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and
`curl_config.h` never defines it. Upstream CI does not see this because
the windows-2022 runner image ships an older LLVM. GCC 14 promotes the
same warning to a hard error, which is very likely the `CurlTests.c.obj`
failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl
hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0
(curl/curl#13578).
2. The root CMakeLists copies the build tree's `compile_commands.json`
into `<src>/build/` for clangd using `configure_file()`, which registers
its input as a configure dependency. CMake rewrites
`compile_commands.json` late in every generation, after
`CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same
Ninja regen rule), so once the dependency is registered the rule is
deterministically dirty and every `ninja` invocation re-runs CMake. A
pristine first configure is safe (the file does not exist yet, so the
`if(EXISTS ...)` guard skips the copy), which is why the loop looks
machine- or IDE-specific.

## Fix

1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag
(previously `curl-8_3_0`), which carries the upstream probe fix plus two
years of upstream development; `vendor.yaml` updated to match.
Adjustments the version jump forced:
- curl 8.15 removed the native macOS Secure Transport backend
(`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like
Linux. The two macOS workflows install Homebrew `openssl@3` and export
`OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same
two lines.
- `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10;
pinned OFF to keep the previous no-compression behavior and avoid
silently linking whatever the CI images happen to have.
- curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked
into discord-rpc's identically named option and broke configure at a
nonexistent `examples/send-presence` directory; pinned OFF ahead of the
third-party subdirectories.

The diff is dominated by the mechanical tag-tree swap under
`third-party/curl` (linguist-vendored, collapsed in review). The
hand-written changes are `CMakeLists.txt`, the two macOS workflows,
`docs/setup/system/macos.md`, and `vendor.yaml`.
2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy
with no configure dependency registered. (`file(COPY_FILE ...
ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21,
above the declared `cmake_minimum_required(VERSION 3.10)`.)

## Test plan

- [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache
seeding) completes and logs `Enabled SSL backends: Schannel`; the
FIONBIO probe passes without the previous `#error`
- [x] Full Windows Release build from scratch in the branch worktree
(all 1422 targets)
- [x] goalc-test suite: 1509 passed, 0 failed
- [x] Second consecutive configure with `compile_commands.json` present:
the regen rule in `build.ninja` has no `compile_commands.json` input;
`<src>/build/compile_commands.json` is still refreshed for clangd
- [x] Repeated `ninja` invocations after a full build no longer re-run
CMake
- [x] macOS Intel and ARM CI green (first exercise of the OpenSSL
backend switch)

---

I work off a self-hosted forge, so this GitHub account is quiet; the
configure logs and ninja dirty-node traces from the investigation are
available if anyone wants the raw data.

(AI-assisted)
2026-07-27 19:19:18 -04:00

184 lines
5.1 KiB
C
Vendored
Generated

/***************************************************************************
* _ _ ____ _
* Project ___| | | | _ \| |
* / __| | | | |_) | |
* | (__| |_| | _ <| |___
* \___|\___/|_| \_\_____|
*
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
*
* This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms
* are also available at https://curl.se/docs/copyright.html.
*
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
* copies of the Software, and permit persons to whom the Software is
* furnished to do so, under the terms of the COPYING file.
*
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
* KIND, either express or implied.
*
* SPDX-License-Identifier: curl
*
***************************************************************************/
#include "first.h"
#include "testtrace.h"
struct t753_transfer_status {
CURL *curl;
const char *name;
bool pause;
bool is_paused;
bool seen_welcome;
};
static size_t t753_write_cb(char *ptr, size_t size, size_t nmemb, void *userp)
{
struct t753_transfer_status *st = userp;
size_t len = size * nmemb;
(void)ptr;
if(st->pause) {
curl_mfprintf(stderr, "[%s] write_cb(len=%zu), PAUSE\n", st->name, len);
st->is_paused = TRUE;
return CURL_READFUNC_PAUSE;
}
curl_mfprintf(stderr, "[%s] write_cb(len=%zu), CONSUME\n", st->name, len);
st->is_paused = FALSE;
return len;
}
static size_t t753_hd_cb(char *ptr, size_t size, size_t nmemb, void *userp)
{
struct t753_transfer_status *st = userp;
size_t len = size * nmemb;
curl_mfprintf(stderr, "[%s] hd_cb '%.*s'\n", st->name, (int)len, ptr);
if(!strcmp("230 Welcome you silly person\r\n", ptr)) {
st->seen_welcome = TRUE;
st->curl = NULL;
}
return len;
}
static bool t753_setup(const char *URL, const char *name,
CURL **pcurl,
struct t753_transfer_status *st)
{
CURL *curl = NULL;
CURLcode result = CURLE_OK;
*pcurl = NULL;
memset(st, 0, sizeof(*st));
st->name = name;
st->curl = curl;
st->pause = TRUE;
easy_init(curl);
easy_setopt(curl, CURLOPT_URL, URL);
easy_setopt(curl, CURLOPT_WRITEFUNCTION, t753_write_cb);
easy_setopt(curl, CURLOPT_WRITEDATA, st);
easy_setopt(curl, CURLOPT_HEADERFUNCTION, t753_hd_cb);
easy_setopt(curl, CURLOPT_HEADERDATA, st);
easy_setopt(curl, CURLOPT_NOPROGRESS, 1L);
easy_setopt(curl, CURLOPT_DEBUGDATA, &debug_config);
easy_setopt(curl, CURLOPT_DEBUGFUNCTION, libtest_debug_cb);
easy_setopt(curl, CURLOPT_VERBOSE, 1L);
*pcurl = curl;
return TRUE;
test_cleanup:
if(curl)
curl_easy_cleanup(curl);
return FALSE;
}
static CURLcode test_lib753(const char *URL)
{
CURL *curl1 = NULL, *curl2 = NULL;
CURLM *multi = NULL;
struct t753_transfer_status st1, st2;
CURLcode result = CURLE_OK;
CURLMcode mresult;
int still_running;
start_test_timing();
debug_config.nohex = TRUE;
debug_config.tracetime = TRUE;
curl_global_init(CURL_GLOBAL_DEFAULT);
curl_mfprintf(stderr, "init multi\n");
multi = curl_multi_init();
if(!multi) {
result = CURLE_OUT_OF_MEMORY;
goto test_cleanup;
}
if(!t753_setup(URL, "EASY1", &curl1, &st1))
goto test_cleanup;
multi_add_handle(multi, curl1);
multi_perform(multi, &still_running);
abort_on_test_timeout();
curl_mfprintf(stderr, "multi_perform() -> %d running\n", still_running);
while(still_running) {
int num;
/* The purpose of this Test:
* 1. Violently cleanup EASY1 *without* removing it from the multi
* handle first. This MUST discard the connection that EASY1 holds,
* as EASY1 is not DONE at this point.
* With the env var CURL_FTP_PWD_STOP set, the connection has
* no outstanding data at this point. This would allow
* reuse if the connection is not terminated by the cleanup.
* 2. Add EASY2 for the same URL and observe in the expected result
* that the connection is NOT reused, e.g. all FTP commands
* are sent again on the new connection.
*/
if(curl1 && st1.seen_welcome) {
curl_easy_cleanup(curl1);
curl1 = NULL;
if(!curl2) {
if(!t753_setup(URL, "EASY2", &curl2, &st2))
goto test_cleanup;
st2.pause = FALSE;
multi_add_handle(multi, curl2);
}
}
mresult = curl_multi_wait(multi, NULL, 0, 1, &num);
if(mresult != CURLM_OK) {
curl_mfprintf(stderr, "curl_multi_wait() returned %d\n", mresult);
result = TEST_ERR_MAJOR_BAD;
goto test_cleanup;
}
abort_on_test_timeout();
multi_perform(multi, &still_running);
curl_mfprintf(stderr, "multi_perform() -> %d running\n", still_running);
abort_on_test_timeout();
}
test_cleanup:
if(result)
curl_mfprintf(stderr, "ERROR: %s\n", curl_easy_strerror(result));
if(curl1)
curl_easy_cleanup(curl1);
if(curl2)
curl_easy_cleanup(curl2);
curl_multi_cleanup(multi);
curl_global_cleanup();
return result;
}