Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
3.4 KiB
Vendored
Generated
Code defines to disable features and protocols
CURL_DISABLE_ALTSVC
Disable support for Alt-Svc: HTTP headers.
CURL_DISABLE_BINDLOCAL
Disable support for binding the local end of connections.
CURL_DISABLE_COOKIES
Disable support for HTTP cookies.
CURL_DISABLE_BASIC_AUTH
Disable support for the Basic authentication methods.
CURL_DISABLE_BEARER_AUTH
Disable support for the Bearer authentication methods.
CURL_DISABLE_DIGEST_AUTH
Disable support for the Digest authentication methods.
CURL_DISABLE_KERBEROS_AUTH
Disable support for the Kerberos authentication methods.
CURL_DISABLE_NEGOTIATE_AUTH
Disable support for the negotiate authentication methods.
CURL_DISABLE_AWS
Disable aws-sigv4 support.
CURL_DISABLE_CA_SEARCH
Disable unsafe CA bundle search in PATH on Windows.
CURL_DISABLE_DICT
Disable the DICT protocol
CURL_DISABLE_DOH
Disable DNS-over-HTTPS
CURL_DISABLE_FILE
Disable the FILE protocol
CURL_DISABLE_FORM_API
Disable the form API
CURL_DISABLE_FTP
Disable the FTP (and FTPS) protocol
CURL_DISABLE_GETOPTIONS
Disable the curl_easy_options() API calls that lets users get information
about existing options to curl_easy_setopt().
CURL_DISABLE_GOPHER
Disable the GOPHER protocol.
CURL_DISABLE_HEADERS_API
Disable the HTTP header API.
CURL_DISABLE_HSTS
Disable the HTTP Strict Transport Security support.
CURL_DISABLE_HTTP
Disable the HTTP(S) protocols. Note that this then also disable HTTP proxy support.
CURL_DISABLE_HTTP_AUTH
Disable support for all HTTP authentication methods.
CURL_DISABLE_IMAP
Disable the IMAP(S) protocols.
CURL_DISABLE_LDAP
Disable the LDAP(S) protocols.
CURL_DISABLE_LDAPS
Disable the LDAPS protocol.
CURL_DISABLE_LIBCURL_OPTION
Disable the --libcurl option from the curl tool.
CURL_DISABLE_MIME
Disable MIME support.
CURL_DISABLE_MQTT
Disable MQTT support.
CURL_DISABLE_NETRC
Disable the netrc parser.
CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG
Disable the auto load config support in the OpenSSL backend.
CURL_DISABLE_PARSEDATE
Disable date parsing
CURL_DISABLE_POP3
Disable the POP3 protocol
CURL_DISABLE_PROGRESS_METER
Disable the built-in progress meter
CURL_DISABLE_PROXY
Disable support for proxies
CURL_DISABLE_IPFS
Disable the IPFS/IPNS protocols. This affects the curl tool only, where IPFS/IPNS protocol support is implemented.
CURL_DISABLE_RTSP
Disable the RTSP protocol.
CURL_DISABLE_SHA512_256
Disable the SHA-512/256 hash algorithm.
CURL_DISABLE_SHUFFLE_DNS
Disable the shuffle DNS feature
CURL_ENABLE_SMB
Enable the SMB(S) protocols
CURL_DISABLE_SMTP
Disable the SMTP(S) protocols
CURL_DISABLE_SOCKETPAIR
Disable the use of socketpair() internally to allow waking up and canceling
curl_multi_poll().
CURL_DISABLE_TELNET
Disable the TELNET protocol
CURL_DISABLE_TFTP
Disable the TFTP protocol
CURL_DISABLE_TYPECHECK
Disable curl_easy_setopt()/curl_easy_getinfo() type checking.
Useful to improve build performance for the tests/libtest test tool.
CURL_DISABLE_VERBOSE_STRINGS
Disable verbose strings and error messages.
CURL_DISABLE_WEBSOCKETS
Disable the WebSocket protocols.