mirror of
https://github.com/open-goal/jak-project
synced 2026-05-31 01:16:12 -04:00
Tyler Wilding
bd5bfe837b
Closes #4183 Jak 2 didn't have this logging call so its fine, but jak 3 added this which is a nice idea. TLDR - there's some settings we stopped loading from the memcard as the source of truth, this function (`load-game...`) skips said portions of the save file and in jak 3, includes a helpful log message. It constructed that log message by calling a `defun-debug` function, which means that in retail mode, that function is gone, instead of that being a straight forward crash, it returns garbage, which is passed to `format`, which causes the crash. Fix is simple, make it a non-debug function so it's always available. Feels like something that could be improved about `goalc` but, be-careful with debug only functions is the take away. This would seem to impact any save file that wrote these related tags (and thus, triggered the logging code) but it might also be semi-random with how unlucky you get with the returned garbage addr