mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
014b164e1392a166fe96e003d2f0e7ad2e2a0bb7
linux/fs
History
David Woodhouse 014b164e13 [JFFS2] Fix free space leak with in-band cleanmarkers 
We were accounting for the cleanmarker by calling jffs2_link_node_ref()
(without locking!), which adjusted both superblock and per-eraseblock
accounting, subtracting the size of the cleanmarker from {jeb,c}->free_size
and adding it to {jeb,c}->used_size.

But only _then_ were we adding the size of the newly-erased block back
to the superblock counts, and we were adding each of jeb->{free,used}_size
to the corresponding superblock counts. Thus, the size of the cleanmarker
was effectively subtracted from the superblock's free_size _twice_.

Fix this, by always adding a full eraseblock size to c->free_size when
we've erased a block. And call jffs2_link_node_ref() under the proper
lock, while we're at it.

Thanks to Alexander Yurchenko and/or Damir Shayhutdinov for (almost)
pinpointing the problem.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
2008-04-22 23:54:38 +01:00
..
9p
fs: Remove unnecessary inclusions of asm/semaphore.h
2008-04-18 22:16:44 -04:00
adfs
mount options: fix adfs
2008-02-08 09:22:39 -08:00
affs
mount options: fix affs
2008-02-08 09:22:39 -08:00
afs
AFS: Do not describe debug parameters with their value
2008-04-16 07:43:48 -07:00
autofs
mount options: fix autofs
2008-02-08 09:22:40 -08:00
autofs4
Introduce path_put()
2008-02-14 21:13:33 -08:00
befs
mount options: fix befs
2008-02-08 09:22:40 -08:00
bfs
iget: stop BFS from using iget() and read_inode()
2008-02-07 08:42:27 -08:00
cifs
cifs: fix misannotations
2008-03-30 14:20:23 -07:00
coda
Introduce path_put()
2008-02-14 21:13:33 -08:00
configfs
Introduce path_put()
2008-02-14 21:13:33 -08:00
cramfs
fs: Remove unnecessary inclusions of asm/semaphore.h
2008-04-18 22:16:44 -04:00
debugfs
debugfs: fix sparse warnings
2008-03-04 14:47:06 -08:00
devpts
mount options: fix devpts
2008-02-08 09:22:40 -08:00
dlm
fs: Remove unnecessary inclusions of asm/semaphore.h
2008-04-18 22:16:44 -04:00
ecryptfs
eCryptfs: Swap dput() and mntput()
2008-03-19 18:53:36 -07:00
efs
efs: update error msg to not refer to deleted read_inode()
2008-04-02 15:28:19 -07:00
exportfs
exportfs: update documentation
2007-10-22 08:13:21 -07:00
ext2
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial
2008-04-21 16:36:46 -07:00
ext3
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial
2008-04-21 16:36:46 -07:00
ext4
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial
2008-04-21 16:36:46 -07:00
fat
[PATCH] r/o bind mounts: elevate write count for ioctls()
2008-04-19 00:29:24 -04:00
freevxfs
iget: stop FreeVXFS from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
fuse
fuse: fix permission checking
2008-02-23 17:12:13 -08:00
gfs2
[GFS2] fix assertion in log_refund()
2008-04-18 08:36:09 +01:00
hfs
hfs_bnode_find() can fail, resulting in hfs_bnode_split() breakage
2008-03-17 09:46:55 -07:00
hfsplus
[PATCH] r/o bind mounts: elevate write count for ioctls()
2008-04-19 00:29:24 -04:00
hostfs
uml: fix hostfs tv_usec calculations
2008-02-05 09:44:30 -08:00
hpfs
mount options: fix hpfs
2008-02-08 09:22:40 -08:00
hppfs
[PATCH] sanitize hppfs
2008-03-19 06:42:18 -04:00
hugetlbfs
[PATCH] double iput() on failure exit in hugetlb
2008-03-19 06:55:01 -04:00
isofs
zisofs: fix readpage() outside i_size
2008-03-19 18:53:36 -07:00
jbd
jbd/jbd2 NULL noise
2008-03-30 14:18:41 -07:00
jbd2
jbd/jbd2 NULL noise
2008-03-30 14:18:41 -07:00
jffs2
[JFFS2] Fix free space leak with in-band cleanmarkers
2008-04-22 23:54:38 +01:00
jfs
[PATCH] r/o bind mounts: elevate write count for ioctls()
2008-04-19 00:29:24 -04:00
lockd
Wrap buffers used for rpc debug printks into RPC_IFDEBUG
2008-02-21 18:42:29 -05:00
minix
iget: stop the MINIX filesystem from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
msdos
…
ncpfs
[PATCH] r/o bind mounts: elevate write count for ncp_ioctl()
2008-04-19 00:29:23 -04:00
nfs
[PATCH] r/o bind mounts: check mnt instead of superblock directly
2008-04-19 00:29:27 -04:00
nfs_common
…
nfsd
[PATCH] r/o bind mounts: check mnt instead of superblock directly
2008-04-19 00:29:27 -04:00
nls
sparse pointer use of zero as null
2007-10-18 14:37:31 -07:00
ntfs
is_vmalloc_addr(): Check if an address is within the vmalloc boundaries
2008-02-05 09:44:14 -08:00
ocfs2
[PATCH] r/o bind mounts: elevate write count for ioctls()
2008-04-19 00:29:24 -04:00
openpromfs
iget: stop OPENPROMFS from using iget() and read_inode()
2008-02-07 08:42:29 -08:00
partitions
block: send disk "change" event for rescan_partitions()
2008-04-19 19:10:24 -07:00
proc
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
2008-04-03 14:33:42 -07:00
qnx4
iget: stop QNX4 from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
ramfs
Remove valueless definition of hard-selected RAMFS option
2007-10-17 08:42:56 -07:00
reiserfs
Merge branch 'semaphore' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc
2008-04-21 15:41:27 -07:00
romfs
ROMFS: Fix up an error in iget removal
2008-03-19 18:53:36 -07:00
smbfs
NULL noise: fs/*, mm/*, kernel/*
2008-03-30 14:18:41 -07:00
sysfs
sysfs: refill attribute buffer when reading from offset 0
2008-04-19 19:10:29 -07:00
sysv
iget: stop the SYSV filesystem from using iget() and read_inode()
2008-02-07 08:42:29 -08:00
udf
udf: fix udf_add_free_space
2008-02-13 16:21:20 -08:00
ufs
fs/ufs/balloc.c: fix sparc64 printk warning
2008-03-19 18:53:37 -07:00
vfat
Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)
2008-02-07 08:42:26 -08:00
xfs
Merge branch 'semaphore' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc
2008-04-21 15:41:27 -07:00
aio.c
eventfd/kaio integration fix
2008-04-11 08:06:43 -07:00
anon_inodes.c
[PATCH] fix up new filp allocators
2008-03-19 06:54:05 -04:00
attr.c
VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations
2007-10-18 14:37:22 -07:00
bad_inode.c
iget: introduce a function to register iget failure
2008-02-07 08:42:26 -08:00
binfmt_aout.c
aout: suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT
2008-02-08 09:22:30 -08:00
binfmt_elf_fdpic.c
pid namespaces: changes to show virtual ids to user
2007-10-19 11:53:40 -07:00
binfmt_elf.c
core dump: user_regset writeback
2008-03-04 16:35:10 -08:00
binfmt_em86.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_flat.c
FLAT binaries: drop BINFMT_FLAT bad header magic warning
2008-02-14 20:58:05 -08:00
binfmt_misc.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_script.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_som.c
aout: remove unnecessary inclusions of {asm, linux}/a.out.h
2008-02-08 09:22:30 -08:00
bio.c
block: convert bio_copy_user to bio_copy_user_iov
2008-04-21 09:50:08 +02:00
block_dev.c
fs/block_dev.c: remove #if 0'ed code
2008-02-19 10:04:00 +01:00
buffer.c
Be more careful about marking buffers dirty
2008-04-04 14:38:17 -07:00
char_dev.c
fs/char_dev.c: chrdev_open marked static and removed from fs.h
2008-02-08 09:22:42 -08:00
compat_binfmt_elf.c
x86: compat_binfmt_elf
2008-01-30 13:31:46 +01:00
compat_ioctl.c
d_path: Make d_path() use a struct path
2008-02-14 21:17:09 -08:00
compat.c
Merge branch 'linus_origin' into hotfixes
2008-02-15 13:36:30 -05:00
dcache.c
dentries: Extract common code to remove dentry from lru
2008-02-14 21:17:09 -08:00
dcookies.c
d_path: Make d_path() use a struct path
2008-02-14 21:17:09 -08:00
direct-io.c
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
dnotify.c
…
dquot.c
quota: add possibly missing iput() when quotaon and quotaoff races
2008-03-19 18:53:35 -07:00
drop_caches.c
…
eventfd.c
fs/eventfd.c should #include <linux/syscalls.h>
2008-02-06 10:41:03 -08:00
eventpoll.c
lockdep: annotate epoll
2008-02-05 09:44:07 -08:00
exec.c
Allow ARG_MAX execve string space even with a small stack limit
2008-03-03 10:12:14 -08:00
fcntl.c
fs: remove fastcall, it is always empty
2008-02-08 09:22:31 -08:00
fifo.c
…
file_table.c
[PATCH] r/o bind mounts: debugging for missed calls
2008-04-19 00:29:28 -04:00
file.c
get rid of NR_OPEN and introduce a sysctl_nr_open
2008-02-06 10:41:06 -08:00
filesystems.c
…
fs-writeback.c
fs: fix kernel-doc notation warnings
2008-03-19 18:53:36 -07:00
generic_acl.c
…
inode.c
[PATCH] r/o bind mounts: write count for file_update_time()
2008-04-19 00:29:24 -04:00
inotify_user.c
Introduce path_put()
2008-02-14 21:13:33 -08:00
inotify.c
inotify: remove debug code
2008-02-06 10:41:07 -08:00
internal.h
…
ioctl.c
fix up kerneldoc in fs/ioctl.c a little bit
2008-02-09 11:08:33 -08:00
ioprio.c
cfq-iosched: relax IOPRIO_CLASS_IDLE restrictions
2008-01-28 11:38:15 +01:00
Kconfig
ocfs2: Allow selection of cluster plug-ins.
2008-04-18 08:56:07 -07:00
Kconfig.binfmt
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
libfs.c
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
locks.c
fs: Remove unnecessary inclusions of asm/semaphore.h
2008-04-18 22:16:44 -04:00
Makefile
x86: compat_binfmt_elf Kconfig
2008-01-30 13:31:46 +01:00
mbcache.c
vfs: fix possible deadlock in ext2, ext3, ext4 when using xattrs
2008-04-15 19:35:41 -07:00
mpage.c
docbook: fix filesystems.tmpl source files
2008-03-03 10:47:13 -08:00
namei.c
[PATCH] r/o bind mounts: elevate write count for open()s
2008-04-19 00:29:25 -04:00
namespace.c
[PATCH] r/o bind mounts: honor mount writer counts at remount
2008-04-19 00:29:27 -04:00
nfsctl.c
Introduce path_put()
2008-02-14 21:13:33 -08:00
no-block.c
…
open.c
[PATCH] r/o bind mounts: debugging for missed calls
2008-04-19 00:29:28 -04:00
pipe.c
[PATCH] fix up new filp allocators
2008-03-19 06:54:05 -04:00
pnode.c
[PATCH] count ghost references to vfsmounts
2008-03-27 20:47:46 -04:00
pnode.h
[PATCH] new helpers - collect_mounts() and release_collected_mounts()
2007-10-21 02:37:25 -04:00
posix_acl.c
…
quota_v1.c
…
quota_v2.c
…
quota.c
Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)
2008-02-07 08:42:26 -08:00
read_write.c
remove the unused exports of sys_open/sys_read
2008-02-08 09:22:36 -08:00
read_write.h
…
readdir.c
Use mutex_lock_killable in vfs_readdir
2007-12-06 17:39:54 -05:00
select.c
trivial: small cleanups
2008-04-21 22:15:06 +00:00
seq_file.c
d_path: Make d_path() use a struct path
2008-02-14 21:17:09 -08:00
signalfd.c
signalfd: fix for incorrect SI_QUEUE user data reporting
2008-04-11 08:06:44 -07:00
splice.c
splice: fix infinite loop in generic_file_splice_read()
2008-04-10 08:24:25 +02:00
stack.c
…
stat.c
Introduce path_put()
2008-02-14 21:13:33 -08:00
super.c
[PATCH] r/o bind mounts: debugging for missed calls
2008-04-19 00:29:28 -04:00
sync.c
…
timerfd.c
timerfd: new timerfd API
2008-02-05 09:44:07 -08:00
utimes.c
[PATCH] r/o bind mounts: elevate write count for do_utimes()
2008-04-19 00:29:24 -04:00
xattr_acl.c
…
xattr.c
[PATCH] r/o bind mounts: elevate write count for xattr_permission() callers
2008-04-19 00:29:15 -04:00