Files
linux/kernel
Li Zefan 0670e08bdf cgroups: don't change release_agent when remount failed
Remount can fail in either case:
  - wrong mount options is specified, or option 'noprefix' is changed.
  - a to-be-added subsys is already mounted/active.

When using remount to change 'release_agent', for the above former failure
case, remount will return errno with release_agent unchanged, but for the
latter case, remount will return EBUSY with relase_agent changed, which is
unexpected I think:

 # mount -t cgroup -o cpu xxx /cgrp1
 # mount -t cgroup -o cpuset,release_agent=agent1 yyy /cgrp2
 # cat /cgrp2/release_agent
 agent1
 # mount -t cgroup -o remount,cpuset,noprefix,release_agent=agent2 yyy /cgrp2
 mount: /cgrp2 not mounted already, or bad option
 # cat /cgrp2/release_agent
 agent1     <-- ok
 # mount -t cgroup -o remount,cpu,cpuset,release_agent=agent2 yyy /cgrp2
 mount: /cgrp2 is busy
 # cat /cgrp2/release_agent
 agent2     <-- unexpected!

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Paul Menage <menage@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-04-02 19:04:54 -07:00
..
2009-04-02 19:04:54 -07:00
2008-10-16 11:21:30 -07:00
2009-02-13 09:44:22 +01:00
2009-04-02 19:04:51 -07:00
2008-07-28 14:37:38 +02:00
2009-03-30 21:46:55 +02:00
2009-02-21 14:17:17 -08:00
2009-01-14 18:09:02 +01:00
2009-02-10 00:41:54 +01:00
2009-01-08 08:31:12 -08:00
2008-09-02 19:21:40 -07:00
2009-03-30 22:05:16 +10:30
2009-02-18 19:26:33 +01:00
2009-02-26 21:56:07 +01:00
2009-01-06 11:07:15 +01:00
2009-03-23 09:22:31 -07:00
2009-03-24 10:52:46 +11:00
2008-10-16 11:21:47 -07:00