Paul E. McKenney
1423cc033d
rcu: Delay rcu_barrier() wait until beginning of next CPU-hotunplug operation.
Ingo Molnar reported this lockup:
[ 200.380003] Hangcheck: hangcheck value past margin!
[ 248.192003] INFO: task S99local:2974 blocked for more than 120 seconds.
[ 248.194532] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 248.202330] S99local D 0000000c 6256 2974 2687 0x00000000
[ 248.208929] 9c7ebe90 00000086 6b67ef8b 0000000c 9f25a610 81a69869 00000001 820b6990
[ 248.216123] 820b6990 820b6990 9c6e4c20 9c6e4eb4 82c78990 00000000 6b993559 0000000c
[ 248.220616] 9c7ebe90 8105f22a 9c6e4eb4 9c6e4c20 00000001 9c7ebe98 9c7ebeb4 81a65cb3
[ 248.229990] Call Trace:
[ 248.234049] [<81a69869>] ? _spin_unlock_irqrestore+0x22/0x37
[ 248.239769] [<8105f22a>] ? prepare_to_wait+0x48/0x4e
[ 248.244796] [<81a65cb3>] rcu_barrier_cpu_hotplug+0xaa/0xc9
[ 248.250343] [<8105f029>] ? autoremove_wake_function+0x0/0x38
[ 248.256063] [<81062cf2>] notifier_call_chain+0x49/0x71
[ 248.261263] [<81062da0>] raw_notifier_call_chain+0x11/0x13
[ 248.266809] [<81a0b475>] _cpu_down+0x272/0x288
[ 248.271316] [<81a0b4d5>] cpu_down+0x4a/0xa2
[ 248.275563] [<81a0c48a>] store_online+0x2a/0x5e
[ 248.280156] [<81a0c460>] ? store_online+0x0/0x5e
[ 248.284836] [<814ddc35>] sysdev_store+0x20/0x28
[ 248.289429] [<8112e403>] sysfs_write_file+0xb8/0xe3
[ 248.294369] [<8112e34b>] ? sysfs_write_file+0x0/0xe3
[ 248.299396] [<810e4c8f>] vfs_write+0x91/0x120
[ 248.303817] [<810e4dc1>] sys_write+0x40/0x65
[ 248.308150] [<81002d73>] sysenter_do_call+0x12/0x28
This change moves an RCU grace period delay off of the
critical path for CPU-hotunplug operations.
Since RCU callback migration is only performed on
CPU-hotunplug operations, and since the rcu_barrier() race is
provoked only by consecutive CPU-hotunplug operations, it is
not necessary to delay the end of a given CPU-hotunplug
operation.
We can instead choose to delay the beginning of the next
CPU-hotunplug operation.
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josht@linux.vnet.ibm.com>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: akpm@linux-foundation.org
Cc: mathieu.desnoyers@polymtl.ca
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
Cc: hugh.dickins@tiscali.co.uk
Cc: benh@kernel.crashing.org
LKML-Reference: <20090819060614.GA14383@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-08-19 13:58:54 +02:00
..
2009-06-18 13:03:58 -07:00
2009-08-13 23:09:27 +02:00
2009-07-12 12:22:34 -07:00
2009-07-19 17:15:54 +02:00
2009-08-12 18:50:08 +02:00
2009-06-30 18:56:00 -07:00
2009-06-08 12:31:53 -07:00
2009-06-24 00:02:38 -04:00
2009-06-24 00:00:52 -04:00
2009-06-24 00:02:38 -04:00
2009-06-24 00:02:38 -04:00
2009-06-24 00:00:52 -04:00
2009-06-24 00:02:38 -04:00
2009-07-29 19:10:35 -07:00
2009-04-30 19:24:24 +02:00
2009-06-22 21:18:12 -07:00
2009-06-16 19:47:31 -07:00
2009-05-11 08:15:36 +10:00
2009-07-08 09:31:56 -07:00
2009-08-07 10:39:56 -07:00
2009-07-18 14:19:53 +02:00
2009-08-10 15:41:12 +02:00
2009-08-10 20:38:11 +02:00
2009-06-16 19:47:48 -07:00
2009-07-10 17:32:55 +02:00
2009-06-09 22:37:52 +02:00
2009-07-29 19:10:34 -07:00
2009-06-16 19:47:47 -07:00
2009-05-15 07:56:24 -05:00
2009-07-08 09:31:56 -07:00
2009-07-30 16:44:06 -07:00
2009-07-27 12:15:46 -07:00
2009-05-12 19:59:52 +02:00
2009-08-07 11:58:38 +02:00
2009-05-07 11:17:34 +02:00
2009-08-15 18:56:13 +02:00
2009-07-27 12:15:45 -07:00
2009-06-11 17:55:42 +02:00
2009-06-18 13:03:56 -07:00
2009-07-24 15:30:45 -04:00
2009-06-12 21:46:58 +09:30
2009-08-13 16:17:15 +02:00
2009-06-18 13:03:55 -07:00
2009-07-09 17:07:02 +01:00
2009-08-08 18:30:25 +02:00
2009-08-04 10:16:41 +02:00
2009-06-16 11:02:28 -07:00
2009-07-29 19:10:36 -07:00
2009-07-06 13:57:04 -07:00
2009-08-19 13:58:54 +02:00
2009-08-15 19:02:09 +02:00
2009-08-15 19:02:09 +02:00
2009-07-03 10:02:29 +02:00
2009-04-14 11:33:43 +02:00
2009-08-15 19:02:08 +02:00
2009-06-18 13:03:48 -07:00
2009-06-30 18:56:00 -07:00
2009-08-06 05:50:21 +02:00
2009-05-09 10:08:19 +02:00
2009-08-02 14:23:29 +02:00
2009-06-17 18:29:42 +02:00
2009-08-02 14:10:12 +02:00
2009-05-15 15:32:45 +02:00
2009-07-10 10:43:29 +02:00
2009-08-15 18:56:13 +02:00
2009-08-01 11:18:56 -07:00
2009-06-16 19:47:49 -07:00
2009-08-07 10:39:55 -07:00
2009-07-22 17:01:17 +02:00
2009-06-16 19:47:48 -07:00
2009-06-28 11:05:28 -07:00
2009-07-18 23:11:43 +02:00
2009-06-15 21:30:23 -07:00
2009-06-18 13:03:55 -07:00
2009-08-10 14:43:09 +02:00
2009-06-02 01:10:40 +02:00