mirror
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers
History
Stanimir Varbanov 1d95af02f2 venus: pm_helpers: Fix warning in OPP during probe 
Fix the following WARN triggered during Venus driver probe on
5.19.0-rc8-next-20220728:

 WARNING: CPU: 7 PID: 339 at drivers/opp/core.c:2471 dev_pm_opp_set_config+0x49c/0x610
 Modules linked in: qcom_spmi_adc5 rtc_pm8xxx qcom_spmi_adc_tm5 leds_qcom_lpg led_class_multicolor
  qcom_pon qcom_vadc_common venus_core(+) qcom_spmi_temp_alarm v4l2_mem2mem videobuf2_v4l2 msm(+)
  videobuf2_common crct10dif_ce spi_geni_qcom snd_soc_sm8250 i2c_qcom_geni gpu_sched
  snd_soc_qcom_common videodev qcom_q6v5_pas soundwire_qcom drm_dp_aux_bus qcom_stats
  drm_display_helper qcom_pil_info soundwire_bus snd_soc_lpass_va_macro mc qcom_q6v5
  phy_qcom_snps_femto_v2 qcom_rng snd_soc_lpass_macro_common snd_soc_lpass_wsa_macro
  lpass_gfm_sm8250 slimbus qcom_sysmon qcom_common qcom_glink_smem qmi_helpers
  qcom_wdt mdt_loader socinfo icc_osm_l3 display_connector
  drm_kms_helper qnoc_sm8250 drm fuse ip_tables x_tables ipv6
 CPU: 7 PID: 339 Comm: systemd-udevd Not tainted 5.19.0-rc8-next-20220728 #4
 Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT)
 pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
 pc : dev_pm_opp_set_config+0x49c/0x610
 lr : dev_pm_opp_set_config+0x58/0x610
 sp : ffff8000093c3710
 x29: ffff8000093c3710 x28: ffffbca3959d82b8 x27: ffff8000093c3d00
 x26: ffffbca3959d8e08 x25: ffff4396cac98118 x24: ffff4396c0e24810
 x23: ffff4396c4272c40 x22: ffff4396c0e24810 x21: ffff8000093c3810
 x20: ffff4396cac36800 x19: ffff4396cac96800 x18: 0000000000000000
 x17: 0000000000000003 x16: ffffbca3f4edf198 x15: 0000001cba64a858
 x14: 0000000000000180 x13: 000000000000017e x12: 0000000000000000
 x11: 0000000000000002 x10: 0000000000000a60 x9 : ffff8000093c35c0
 x8 : ffff4396c4273700 x7 : ffff43983efca6c0 x6 : ffff43983efca640
 x5 : 00000000410fd0d0 x4 : ffff4396c4272c40 x3 : ffffbca3f5d1e008
 x2 : 0000000000000000 x1 : ffff4396c2421600 x0 : ffff4396cac96860
 Call trace:
  dev_pm_opp_set_config+0x49c/0x610
  devm_pm_opp_set_config+0x18/0x70
  vcodec_domains_get+0xb8/0x1638 [venus_core]
  core_get_v4+0x1d8/0x218 [venus_core]
  venus_probe+0xf4/0x468 [venus_core]
  platform_probe+0x68/0xd8
  really_probe+0xbc/0x2a8
  __driver_probe_device+0x78/0xe0
  driver_probe_device+0x3c/0xf0
  __driver_attach+0x70/0x120
  bus_for_each_dev+0x70/0xc0
  driver_attach+0x24/0x30
  bus_add_driver+0x150/0x200
  driver_register+0x64/0x120
  __platform_driver_register+0x28/0x38
  qcom_venus_driver_init+0x24/0x1000 [venus_core]
  do_one_initcall+0x54/0x1c8
  do_init_module+0x44/0x1d0
  load_module+0x16c8/0x1aa0
  __do_sys_finit_module+0xbc/0x110
  __arm64_sys_finit_module+0x20/0x30
  invoke_syscall+0x44/0x108
  el0_svc_common.constprop.0+0xcc/0xf0
  do_el0_svc+0x2c/0xb8
  el0_svc+0x2c/0x88
  el0t_64_sync_handler+0xb8/0xc0
  el0t_64_sync+0x18c/0x190
  qcom-venus: probe of aa00000.video-codec failed with error -16

The fix is re-ordering the code related to OPP core. The OPP core
expects all configuration options to be provided before the OPP
table is added.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
 		2022-08-02 09:44:22 +05:30
..
accessibility Revert "speakup: Generate speakupmap.h automatically" 2022-05-20 21:07:05 +02:00
acpi More power management updates for 5.19-rc1 2022-05-30 11:37:26 -07:00
amba Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
android fix for breakage in #work.fd this window 2022-06-05 17:14:03 -07:00
ata ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
atm
…
auxdisplay
…
base firmware_loader: enable XZ by default if compressed support is enabled 2022-06-03 15:46:03 -07:00
bcma
…
block xen: branch for v5.19-rc1b 2022-06-04 13:42:53 -07:00
bluetooth
…
bus Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
cdrom
…
char Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
clk Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
clocksource Clockevent/clocksource updates: 2022-06-05 10:47:06 -07:00
comedi drivers: comedi: replace ternary operator with min() 2022-05-19 18:54:45 +02:00
connector
…
counter
…
cpufreq OPP: Migrate set-prop-name helper API to use set-config helpers 2022-07-08 11:27:49 +05:30
cpuidle Merge branches 'pm-em' and 'pm-cpuidle' 2022-05-23 19:18:51 +02:00
crypto virtio-crypto: enable retry for virtio-crypto-dev 2022-05-31 12:45:09 -04:00
cxl cxl/port: Enable HDM Capability after validating DVSEC Ranges 2022-05-20 12:30:53 -07:00
dax
…
dca
…
devfreq PM / devfreq: tegra30: Register config_clks helper 2022-07-12 20:35:21 +05:30
dio drivers: dio: add missing iounmap() in dio_init() 2022-05-19 18:56:51 +02:00
dma dmaengine updates for v5.19-rc1 2022-05-29 11:38:27 -07:00
dma-buf drm for 5.19-rc1 2022-05-25 16:18:27 -07:00
edac - A gargen variety of fixes which don't fit any other tip bucket: 2022-05-23 19:32:59 -07:00
eisa
…
extcon
…
firewire Merge branch 'for-linus' into for-next 2022-05-23 07:48:27 +02:00
firmware Follow-up tweaks for the EFI changes in v5.19 2022-06-03 13:39:30 -07:00
fpga
…
fsi
…
gnss
…
gpio hte: New subsystem for v5.19-rc1 2022-06-05 09:12:28 -07:00
gpu drm/lima: Migrate to dev_pm_opp_set_config() 2022-07-08 11:27:33 +05:30
greybus
…
hid USB / Thunderbolt changes for 5.19-rc1 2022-06-03 11:17:49 -07:00
hsi
…
hte hte: Uninitialized variable in hte_ts_get() 2022-05-20 15:54:41 +02:00
hv Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
hwmon hwmon: (aquacomputer_d5next) Fix an error handling path in aqc_probe() 2022-05-22 12:25:55 -07:00
hwspinlock
…
hwtracing
…
i2c i2c: ismt: prevent memory corruption in ismt_access() 2022-06-02 08:40:56 -07:00
i3c
…
idle
…
iio Bitmap patches for 5.19-rc1 2022-06-04 14:04:27 -07:00
infiniband v5.19 pull request 2022-05-26 21:08:40 -07:00
input xen: branch for v5.19-rc1b 2022-06-04 13:42:53 -07:00
interconnect Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
iommu IOMMU Updates for Linux v5.19 2022-05-31 09:56:54 -07:00
ipack
…
irqchip irq: mips: replace cpumask_weight with cpumask_empty where appropriate 2022-06-03 06:52:57 -07:00
isdn
…
leds ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
macintosh macintosh: via-pmu and via-cuda need RTC_LIB 2022-05-22 15:58:30 +10:00
mailbox mailbox: qcom-ipcc: Fix -Wunused-function with CONFIG_PM_SLEEP=n 2022-05-24 08:08:24 -05:00
mcb
…
md for-5.19/drivers-2022-06-02 2022-06-03 10:25:56 -07:00
media venus: pm_helpers: Fix warning in OPP during probe 2022-08-02 09:44:22 +05:30
memory OPP: Migrate set-supported-hw API to use set-config helpers 2022-07-08 11:27:48 +05:30
memstick
…
message
…
mfd ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
misc Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
mmc ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
most
…
mtd This pull request contains fixes for JFFS2, UBI and UBIFS 2022-06-03 14:42:24 -07:00
mux
…
net Bitmap patches for 5.19-rc1 2022-06-04 14:04:27 -07:00
nfc NFC: hci: fix sleep in atomic context bugs in nfc_hci_hcp_message_tx 2022-05-19 17:54:02 -07:00
ntb
…
nubus
…
nvdimm cxl for 5.19 2022-05-27 21:24:19 -07:00
nvme SCSI misc on 20220604 2022-06-05 09:25:12 -07:00
nvmem
…
of drm for 5.19-rc1 2022-05-25 16:18:27 -07:00
opp OPP: Don't drop opp->np reference while it is still in use 2022-07-19 11:07:02 +05:30
parisc
…
parport
…
pci Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
pcmcia ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
peci
…
perf arm64 updates for 5.19: 2022-05-23 21:06:11 -07:00
phy phy-for-5.19 2022-05-19 16:56:17 +02:00
pinctrl Pin control bulk changes for the v5.19 series: 2022-05-28 11:15:54 -07:00
platform Cleanups and fixes 2022-05-30 11:01:50 -07:00
pnp
…
power Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
powercap Merge branches 'pm-em' and 'pm-cpuidle' 2022-05-23 19:18:51 +02:00
pps
…
ps3
…
ptp ptp: ptp_clockmatrix: fix is_single_shot 2022-05-25 21:51:32 -07:00
pwm pwm: pwm-cros-ec: Add channel type support 2022-05-20 16:40:01 +02:00
rapidio
…
ras
…
regulator Merge back reboot/poweroff notifiers rework for 5.19-rc1. 2022-05-25 14:38:29 +02:00
remoteproc
…
reset
…
rpmsg Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
rtc ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
s390 Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
sbus
…
scsi SCSI misc on 20220604 2022-06-05 09:25:12 -07:00
sh
…
siox
…
slimbus Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
soc soc/tegra: Migrate to dev_pm_opp_set_config() 2022-07-08 11:27:33 +05:30
soundwire
…
spi Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
spmi
…
ssb
…
staging Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
target blk-mq: remove the done argument to blk_execute_rq_nowait 2022-05-28 06:15:27 -06:00
tc
…
tee Fix a compiler warning in OP-TEE driver 2022-05-30 14:44:27 +02:00
thermal Additional thermal control update for 5.19-rc1 2022-05-30 11:34:13 -07:00
thunderbolt USB / Thunderbolt changes for 5.19-rc1 2022-06-03 11:17:49 -07:00
tty xen: branch for v5.19-rc1b 2022-06-04 13:42:53 -07:00
ufs SCSI misc on 20220604 2022-06-05 09:25:12 -07:00
uio
…
usb Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
vdpa Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
vfio VFIO updates for v5.19-rc1 2022-06-01 13:49:15 -07:00
vhost vhost: rename vhost_work_dev_flush 2022-05-31 12:45:10 -04:00
video parisc architecture fixes & updates for kernel v5.19-rc1 2022-06-04 13:50:23 -07:00
virt Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
virtio virtio: Directly use ida_alloc()/free() 2022-05-31 12:45:10 -04:00
vlynq
…
vme
…
w1
…
watchdog ARM: SoC changes, part 2 2022-06-02 15:27:44 -07:00
xen xen: branch for v5.19-rc1b 2022-06-04 13:42:53 -07:00
zorro
…
Kconfig SCSI misc on 20220604 2022-06-05 09:25:12 -07:00
Makefile SCSI misc on 20220604 2022-06-05 09:25:12 -07:00