Jianbo Liu
2aeeef906d
bonding: change ipsec_lock from spin lock to mutex
In the cited commit, bond->ipsec_lock is added to protect ipsec_list,
hence xdo_dev_state_add and xdo_dev_state_delete are called inside
this lock. As ipsec_lock is a spin lock and such xfrmdev ops may sleep,
"scheduling while atomic" will be triggered when changing bond's
active slave.
[ 101.055189] BUG: scheduling while atomic: bash/902/0x00000200
[ 101.055726] Modules linked in:
[ 101.058211] CPU: 3 PID: 902 Comm: bash Not tainted 6.9.0-rc4+ #1
[ 101.058760] Hardware name:
[ 101.059434] Call Trace:
[ 101.059436] <TASK>
[ 101.060873] dump_stack_lvl+0x51/0x60
[ 101.061275] __schedule_bug+0x4e/0x60
[ 101.061682] __schedule+0x612/0x7c0
[ 101.062078] ? __mod_timer+0x25c/0x370
[ 101.062486] schedule+0x25/0xd0
[ 101.062845] schedule_timeout+0x77/0xf0
[ 101.063265] ? asm_common_interrupt+0x22/0x40
[ 101.063724] ? __bpf_trace_itimer_state+0x10/0x10
[ 101.064215] __wait_for_common+0x87/0x190
[ 101.064648] ? usleep_range_state+0x90/0x90
[ 101.065091] cmd_exec+0x437/0xb20 [mlx5_core]
[ 101.065569] mlx5_cmd_do+0x1e/0x40 [mlx5_core]
[ 101.066051] mlx5_cmd_exec+0x18/0x30 [mlx5_core]
[ 101.066552] mlx5_crypto_create_dek_key+0xea/0x120 [mlx5_core]
[ 101.067163] ? bonding_sysfs_store_option+0x4d/0x80 [bonding]
[ 101.067738] ? kmalloc_trace+0x4d/0x350
[ 101.068156] mlx5_ipsec_create_sa_ctx+0x33/0x100 [mlx5_core]
[ 101.068747] mlx5e_xfrm_add_state+0x47b/0xaa0 [mlx5_core]
[ 101.069312] bond_change_active_slave+0x392/0x900 [bonding]
[ 101.069868] bond_option_active_slave_set+0x1c2/0x240 [bonding]
[ 101.070454] __bond_opt_set+0xa6/0x430 [bonding]
[ 101.070935] __bond_opt_set_notify+0x2f/0x90 [bonding]
[ 101.071453] bond_opt_tryset_rtnl+0x72/0xb0 [bonding]
[ 101.071965] bonding_sysfs_store_option+0x4d/0x80 [bonding]
[ 101.072567] kernfs_fop_write_iter+0x10c/0x1a0
[ 101.073033] vfs_write+0x2d8/0x400
[ 101.073416] ? alloc_fd+0x48/0x180
[ 101.073798] ksys_write+0x5f/0xe0
[ 101.074175] do_syscall_64+0x52/0x110
[ 101.074576] entry_SYSCALL_64_after_hwframe+0x4b/0x53
As bond_ipsec_add_sa_all and bond_ipsec_del_sa_all are only called
from bond_change_active_slave, which requires holding the RTNL lock.
And bond_ipsec_add_sa and bond_ipsec_del_sa are xfrm state
xdo_dev_state_add and xdo_dev_state_delete APIs, which are in user
context. So ipsec_lock doesn't have to be spin lock, change it to
mutex, and thus the above issue can be resolved.
Fixes: 9a5605505d ("bonding: Add struct bond_ipesc to manage SA")
Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jay Vosburgh <jv@jvosburgh.net>
Link: https://patch.msgid.link/20240823031056.110999-4-jianbol@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-08-27 13:11:37 -07:00
..
2024-08-12 18:36:44 +09:00
2024-08-13 13:45:14 +02:00
2024-07-31 13:48:25 +02:00
2024-08-14 15:49:37 +02:00
2024-08-12 10:41:44 +01:00
2024-07-26 11:04:28 -07:00
2024-07-31 14:41:44 +02:00
2024-07-27 15:28:53 -07:00
2024-08-23 15:56:04 -04:00
2024-07-27 12:46:16 -07:00
2024-08-01 07:15:02 -07:00
2024-07-24 20:59:29 +02:00
2024-08-16 09:57:56 +02:00
2024-07-31 14:51:47 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 15:55:08 -07:00
2024-08-02 14:40:13 +02:00
2024-07-20 12:41:03 -07:00
2024-08-09 15:13:07 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-10 15:38:14 +02:00
2024-07-25 10:42:22 -07:00
2024-07-21 17:15:46 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-07-29 10:33:51 -07:00
2024-07-25 10:42:22 -07:00
2024-07-31 13:40:00 +02:00
2024-08-10 21:35:16 +02:00
2024-08-16 13:16:47 +10:00
2024-07-25 10:42:22 -07:00
2024-08-19 11:02:13 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-08-15 00:22:28 +02:00
2024-07-27 10:53:06 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 09:59:58 -07:00
2024-07-29 10:44:48 -07:00
2024-07-19 15:55:08 -07:00
2024-08-20 16:06:39 -07:00
2024-08-10 10:42:04 +02:00
2024-07-25 08:05:05 -07:00
2024-07-17 17:51:30 -07:00
2024-07-25 12:58:36 -07:00
2024-07-19 21:25:23 -05:00
2024-07-25 10:42:22 -07:00
2024-08-16 14:03:31 -07:00
2024-08-15 10:23:19 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:46:16 -07:00
2024-08-18 10:16:34 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-28 11:51:51 -07:00
2024-08-27 13:11:37 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-08-09 14:29:58 -05:00
2024-07-31 07:40:10 -07:00
2024-07-25 10:42:22 -07:00
2024-08-13 15:17:24 -06:00
2024-07-15 18:55:14 +02:00
2024-07-25 12:58:36 -07:00
2024-08-01 12:58:03 -05:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-08-01 07:15:13 -07:00
2024-07-24 13:11:28 -07:00
2024-07-25 06:53:47 -05:00
2024-08-22 06:34:27 +08:00
2024-07-09 13:12:41 +02:00
2024-08-07 09:45:21 -07:00
2024-07-25 10:42:22 -07:00
2024-07-16 19:28:34 -07:00
2024-07-25 06:53:47 -05:00
2024-07-15 18:20:24 -07:00
2024-07-27 12:27:52 -07:00
2024-07-23 13:41:59 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-10 17:15:33 +02:00
2024-08-16 14:03:31 -07:00
2024-07-11 15:42:03 +02:00
2024-08-17 10:04:01 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-08-08 20:08:44 +10:00
2024-07-25 10:42:22 -07:00
2024-08-07 23:45:12 +01:00
2024-07-31 13:49:28 +02:00
2024-08-23 07:43:15 +08:00
2024-07-25 10:42:22 -07:00
2024-08-16 13:13:59 +02:00
2024-08-06 08:01:10 +03:00
2024-08-15 07:22:10 +02:00
2024-08-01 21:59:00 -04:00
2024-08-15 16:29:46 +02:00
2024-07-29 12:53:37 -07:00
2024-07-25 10:42:22 -07:00
2024-08-06 10:58:28 -07:00
2024-07-21 17:15:46 -07:00
2024-07-20 12:41:03 -07:00
2024-07-29 12:53:37 -07:00
2024-07-25 10:18:35 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00