mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
30939293262eb433c960c4532a0d59c4073b2b84
linux/kernel
History
Yu Kuai 3093929326 blktrace: fix use after free for struct blk_trace 
When tracing the whole disk, 'dropped' and 'msg' will be created
under 'q->debugfs_dir' and 'bt->dir' is NULL, thus blk_trace_free()
won't remove those files. What's worse, the following UAF can be
triggered because of accessing stale 'dropped' and 'msg':

==================================================================
BUG: KASAN: use-after-free in blk_dropped_read+0x89/0x100
Read of size 4 at addr ffff88816912f3d8 by task blktrace/1188

CPU: 27 PID: 1188 Comm: blktrace Not tainted 5.17.0-rc4-next-20220217+ #469
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20190727_073836-4
Call Trace:
 <TASK>
 dump_stack_lvl+0x34/0x44
 print_address_description.constprop.0.cold+0xab/0x381
 ? blk_dropped_read+0x89/0x100
 ? blk_dropped_read+0x89/0x100
 kasan_report.cold+0x83/0xdf
 ? blk_dropped_read+0x89/0x100
 kasan_check_range+0x140/0x1b0
 blk_dropped_read+0x89/0x100
 ? blk_create_buf_file_callback+0x20/0x20
 ? kmem_cache_free+0xa1/0x500
 ? do_sys_openat2+0x258/0x460
 full_proxy_read+0x8f/0xc0
 vfs_read+0xc6/0x260
 ksys_read+0xb9/0x150
 ? vfs_write+0x3d0/0x3d0
 ? fpregs_assert_state_consistent+0x55/0x60
 ? exit_to_user_mode_prepare+0x39/0x1e0
 do_syscall_64+0x35/0x80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7fbc080d92fd
Code: ce 20 00 00 75 10 b8 00 00 00 00 0f 05 48 3d 01 f0 ff ff 73 31 c3 48 83 1
RSP: 002b:00007fbb95ff9cb0 EFLAGS: 00000293 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 00007fbb95ff9dc0 RCX: 00007fbc080d92fd
RDX: 0000000000000100 RSI: 00007fbb95ff9cc0 RDI: 0000000000000045
RBP: 0000000000000045 R08: 0000000000406299 R09: 00000000fffffffd
R10: 000000000153afa0 R11: 0000000000000293 R12: 00007fbb780008c0
R13: 00007fbb78000938 R14: 0000000000608b30 R15: 00007fbb780029c8
 </TASK>

Allocated by task 1050:
 kasan_save_stack+0x1e/0x40
 __kasan_kmalloc+0x81/0xa0
 do_blk_trace_setup+0xcb/0x410
 __blk_trace_setup+0xac/0x130
 blk_trace_ioctl+0xe9/0x1c0
 blkdev_ioctl+0xf1/0x390
 __x64_sys_ioctl+0xa5/0xe0
 do_syscall_64+0x35/0x80
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Freed by task 1050:
 kasan_save_stack+0x1e/0x40
 kasan_set_track+0x21/0x30
 kasan_set_free_info+0x20/0x30
 __kasan_slab_free+0x103/0x180
 kfree+0x9a/0x4c0
 __blk_trace_remove+0x53/0x70
 blk_trace_ioctl+0x199/0x1c0
 blkdev_common_ioctl+0x5e9/0xb30
 blkdev_ioctl+0x1a5/0x390
 __x64_sys_ioctl+0xa5/0xe0
 do_syscall_64+0x35/0x80
 entry_SYSCALL_64_after_hwframe+0x44/0xae

The buggy address belongs to the object at ffff88816912f380
 which belongs to the cache kmalloc-96 of size 96
The buggy address is located 88 bytes inside of
 96-byte region [ffff88816912f380, ffff88816912f3e0)
The buggy address belongs to the page:
page:000000009a1b4e7c refcount:1 mapcount:0 mapping:0000000000000000 index:0x0f
flags: 0x17ffffc0000200(slab|node=0|zone=2|lastcpupid=0x1fffff)
raw: 0017ffffc0000200 ffffea00044f1100 dead000000000002 ffff88810004c780
raw: 0000000000000000 0000000000200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88816912f280: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
 ffff88816912f300: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
>ffff88816912f380: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
                                                    ^
 ffff88816912f400: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
 ffff88816912f480: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
==================================================================

Fixes: c0ea57608b ("blktrace: remove debugfs file dentries from struct blk_trace")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20220228034354.4047385-1-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-02-28 06:36:33 -07:00
..
bpf
Merge tag 'powerpc-5.17-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2022-01-23 17:52:42 +02:00
cgroup
psi: Fix uaf issue when psi trigger is destroyed while being polled
2022-01-18 12:09:57 +01:00
configs
configs: introduce debug.config for CI-like setup
2022-01-20 08:52:55 +02:00
debug
kdb: Adopt scheduler's task classification
2021-11-03 17:21:37 +00:00
dma
Merge tag 'hyperv-next-signed-20220114' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux
2022-01-16 15:53:00 +02:00
entry
entry: Snapshot thread flags
2021-12-01 00:06:43 +01:00
events
perf: Fix perf_event_read_local() time
2022-01-18 12:09:47 +01:00
futex
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
gcov
gcov: Remove compiler version check
2021-12-02 17:25:21 +09:00
irq
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
kcsan
Merge tag 'kcsan.2022.01.09a' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu
2022-01-11 09:51:26 -08:00
livepatch
Merge tag 'livepatching-for-5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching
2022-01-16 10:08:13 +02:00
locking
locking/rwlocks: introduce write_lock_nested
2022-01-22 08:33:37 +02:00
power
PM: hibernate: Allow ACPI hardware signature to be honoured
2021-12-08 16:06:10 +01:00
printk
printk: fix build warning when CONFIG_PRINTK=n
2022-01-22 08:33:36 +02:00
rcu
Merge branch 'akpm' (patches from Andrew)
2022-01-15 20:37:06 +02:00
sched
Merge tag 'sched_urgent_for_v5.17_rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2022-01-23 17:35:27 +02:00
time
Merge tag 'bitmap-5.17-rc1' of git://github.com/norov/linux
2022-01-23 06:20:44 +02:00
trace
blktrace: fix use after free for struct blk_trace
2022-02-28 06:36:33 -07:00
.gitignore
.gitignore: prefix local generated files with a slash
2021-05-02 00:43:35 +09:00
acct.c
kernel: remove spurious blkdev.h includes
2021-10-18 06:17:01 -06:00
async.c
kernel/async.c: remove async_unregister_domain()
2021-05-07 00:26:33 -07:00
audit_fsnotify.c
fsnotify: clarify contract for create event hooks
2021-10-27 12:32:34 +02:00
audit_tree.c
audit: use struct_size() helper in kmalloc()
2021-12-14 17:39:42 -05:00
audit_watch.c
Merge tag 'fsnotify_for_v5.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2021-11-06 16:43:20 -07:00
audit.c
Merge tag 'audit-pr-20220110' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
2022-01-11 13:08:21 -08:00
audit.h
Merge tag 'audit-pr-20211101' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
2021-11-01 21:17:39 -07:00
auditfilter.c
Merge tag 'audit-pr-20220110' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
2022-01-11 13:08:21 -08:00
auditsc.c
lsm: security_task_getsecid_subj() -> security_current_getsecid_subj()
2021-11-22 17:52:47 -05:00
backtracetest.c
…
bounds.c
…
capability.c
…
cfi.c
cfi: Use rcu_read_{un}lock_sched_notrace
2021-08-11 13:11:12 -07:00
compat.c
arch: remove compat_alloc_user_space
2021-09-08 15:32:35 -07:00
configs.c
…
context_tracking.c
…
cpu_pm.c
PM: cpu: Make notifier chain use a raw_spinlock_t
2021-08-16 18:55:32 +02:00
cpu.c
sched/scs: Reset task stack state in bringup_cpu()
2021-11-24 12:20:27 +01:00
crash_core.c
kernel/crash_core: suppress unknown crashkernel parameter warning
2021-12-25 12:20:55 -08:00
crash_dump.c
…
cred.c
ucounts: In set_cred_ucounts assume new->ucounts is non-NULL
2021-10-20 10:45:34 -05:00
delayacct.c
delayacct: track delays from memory compact
2022-01-20 08:52:55 +02:00
dma.c
…
exec_domain.c
…
exit.c
exit: Fix the exit_code for wait_task_zombie
2022-01-08 12:43:57 -06:00
extable.c
extable: use is_kernel_text() helper
2021-11-09 10:02:51 -08:00
fail_function.c
…
fork.c
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
freezer.c
sched: Add get_current_state()
2021-06-18 11:43:08 +02:00
gen_kheaders.sh
kbuild: clean up ${quiet} checks in shell scripts
2021-05-27 04:01:50 +09:00
groups.c
…
hung_task.c
hung_task: move hung_task sysctl interface to hung_task.c
2022-01-22 08:33:34 +02:00
iomem.c
…
irq_work.c
irq_work: Also rcuwait for !IRQ_WORK_HARD_IRQ on PREEMPT_RT
2021-10-15 11:25:18 +02:00
jump_label.c
jump_label: Fix jump_label_text_reserved() vs __init
2021-07-05 10:46:20 +02:00
kallsyms.c
Merge tag 'livepatching-for-5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching
2022-01-16 10:08:13 +02:00
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
locking/rwlock: Provide RT variant
2021-08-17 17:50:51 +02:00
Kconfig.preempt
preempt: Restore preemption model selection configs
2021-11-11 13:09:33 +01:00
kcov.c
kcov: replace local_irq_save() with a local_lock_t
2021-11-09 10:02:52 -08:00
kexec_core.c
exit: Move oops specific logic from do_exit into make_task_dead
2021-12-13 12:04:45 -06:00
kexec_elf.c
…
kexec_file.c
memblock: add MEMBLOCK_DRIVER_MANAGED to mimic IORESOURCE_SYSRAM_DRIVER_MANAGED
2021-11-06 13:30:42 -07:00
kexec_internal.h
…
kexec.c
kexec: avoid compat_alloc_user_space
2021-09-08 15:32:34 -07:00
kheaders.c
…
kmod.c
modules: add CONFIG_MODPROBE_PATH
2021-05-07 00:26:33 -07:00
kprobes.c
kprobe: move sysctl_kprobes_optimization to kprobes.c
2022-01-22 08:33:36 +02:00
ksysfs.c
…
kthread.c
Merge branch 'akpm' (patches from Andrew)
2022-01-20 10:41:01 +02:00
latencytop.c
…
Makefile
module: add in-kernel support for decompressing
2022-01-11 18:45:02 -08:00
module_decompress.c
kernel: Fix spelling mistake "compresser" -> "compressor"
2022-01-13 07:17:47 -08:00
module_signature.c
…
module_signing.c
…
module-internal.h
module: add in-kernel support for decompressing
2022-01-11 18:45:02 -08:00
module.c
Merge branch 'modules-next' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2022-01-17 07:32:51 +02:00
notifier.c
notifier: Return an error when a callback has already been registered
2021-12-29 10:37:33 +01:00
nsproxy.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
padata.c
padata: Remove repeated verbose license text
2021-08-27 16:30:18 +08:00
panic.c
panic: remove oops_id
2022-01-20 08:52:55 +02:00
params.c
kobject: remove kset from struct kset_uevent_ops callbacks
2021-12-28 11:26:18 +01:00
pid_namespace.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
pid.c
pid: add pidfd_get_task() helper
2021-10-14 13:29:18 +02:00
profile.c
exit: Remove profile_handoff_task
2022-01-08 12:43:57 -06:00
ptrace.c
ptrace: Remove second setting of PT_SEIZED in ptrace_attach
2022-01-08 12:43:57 -06:00
range.c
…
reboot.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2021-11-12 11:53:16 -08:00
regset.c
…
relay.c
…
resource_kunit.c
…
resource.c
proc: remove PDE_DATA() completely
2022-01-22 08:33:37 +02:00
rseq.c
KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest
2021-09-22 10:24:01 -04:00
scftorture.c
scftorture: Always log error message
2021-12-07 16:36:17 -08:00
scs.c
scs: Release kasan vmalloc poison in scs_free process
2021-09-30 09:37:27 +01:00
seccomp.c
Merge branch 'exit-cleanups-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2021-09-01 14:52:05 -07:00
signal.c
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
smp.c
sched: Improve wake_up_all_idle_cpus() take #2
2021-10-22 15:32:46 +02:00
smpboot.c
smpboot: Replace deprecated CPU-hotplug functions.
2021-08-10 14:57:42 +02:00
smpboot.h
…
softirq.c
timers/nohz: Last resort update jiffies on nohz_full IRQ entry
2021-12-02 15:07:22 +01:00
stackleak.c
stackleak: move stack_erasing sysctl to stackleak.c
2022-01-22 08:33:35 +02:00
stacktrace.c
stacktrace: move filter_irq_stacks() to kernel/stacktrace.c
2021-11-06 13:30:43 -07:00
static_call.c
static_call: Fix static_call_text_reserved() vs __init
2021-07-05 10:46:33 +02:00
stop_machine.c
…
sys_ni.c
mm/mempolicy: wire up syscall set_mempolicy_home_node
2022-01-15 16:30:30 +02:00
sys.c
Merge branch 'akpm' (patches from Andrew)
2022-01-20 10:41:01 +02:00
sysctl-test.c
kernel/sysctl-test: Remove some casts which are no-longer required
2021-06-23 16:41:24 -06:00
sysctl.c
sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax
2022-01-22 08:33:37 +02:00
task_work.c
kasan: record task_work_add() call stack
2021-04-30 11:20:42 -07:00
taskstats.c
…
torture.c
locktorture,rcutorture,torture: Always log error message
2021-12-07 16:36:17 -08:00
tracepoint.c
tracepoint: Fix kerneldoc comments
2021-08-16 11:39:51 -04:00
tsacct.c
taskstats: Cleanup the use of task->exit_code
2022-01-08 12:43:57 -06:00
ucount.c
ucounts: Fix rlimit max values check
2021-12-09 15:37:18 -06:00
uid16.c
…
uid16.h
…
umh.c
kernel/umh.c: fix some spelling mistakes
2021-05-07 00:26:34 -07:00
up.c
Merge tag 'locking-urgent-2021-05-09' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2021-05-09 13:07:03 -07:00
user_namespace.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
user-return-notifier.c
…
user.c
fs/epoll: use a per-cpu counter for user's watches count
2021-09-08 11:50:27 -07:00
usermode_driver.c
Merge branch 'work.namei' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2021-07-03 11:41:14 -07:00
utsname_sysctl.c
…
utsname.c
…
watch_queue.c
…
watchdog_hld.c
…
watchdog.c
watchdog: move watchdog sysctl interface to watchdog.c
2022-01-22 08:33:34 +02:00
workqueue_internal.h
workqueue: Assign a color to barrier work items
2021-08-17 07:49:10 -10:00
workqueue.c
Merge branch 'workqueue/for-5.16-fixes' into workqueue/for-5.17
2022-01-10 07:54:04 -10:00