Yunsheng Lin 368d3cb406
page_pool: fix inconsistency for page_pool_ring_[un]lock() ...
page_pool_ring_[un]lock() use in_softirq() to decide which
spin lock variant to use, and when they are called in the
context with in_softirq() being false, spin_lock_bh() is
called in page_pool_ring_lock() while spin_unlock() is
called in page_pool_ring_unlock(), because spin_lock_bh()
has disabled the softirq in page_pool_ring_lock(), which
causes inconsistency for spin lock pair calling.
This patch fixes it by returning in_softirq state from
page_pool_producer_lock(), and use it to decide which
spin lock variant to use in page_pool_producer_unlock().
As pool->ring has both producer and consumer lock, so
rename it to page_pool_producer_[un]lock() to reflect
the actual usage. Also move them to page_pool.c as they
are only used there, and remove the 'inline' as the
compiler may have better idea to do inlining or not.
Fixes: 7886244736linyunsheng@huawei.com >
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com >
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org >
Link: https://lore.kernel.org/r/20230522031714.5089-1-linyunsheng@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2023-05-23 20:25:13 -07:00
2023-03-27 02:33:48 +00:00
2023-05-19 15:37:45 -07:00
2021-07-01 13:19:48 -07:00
2021-11-19 11:52:25 +00:00
2023-04-14 08:56:19 +01:00
2023-05-03 08:24:32 +02:00
2023-04-20 20:07:50 -07:00
2021-11-17 20:17:05 -08:00
2022-07-22 12:53:22 +01:00
2023-04-21 08:19:30 +01:00
2023-02-16 10:39:28 +01:00
2023-02-20 16:46:10 -08:00
2023-03-17 08:56:37 +00:00
2023-05-01 07:43:19 +01:00
2023-03-18 12:23:33 +00:00
2023-03-29 08:19:38 +01:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2023-03-18 12:23:34 +00:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2022-09-16 14:34:01 +01:00
2022-11-02 20:38:13 -07:00
2022-07-22 12:53:22 +01:00
2023-05-19 22:46:37 -07:00
2021-03-26 17:43:55 +01:00
2022-08-24 13:46:58 +01:00
2022-11-16 11:31:47 +02:00
2023-03-24 11:45:51 +01:00
2023-01-28 13:51:22 +01:00
2023-01-27 11:19:46 +00:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2021-12-22 15:03:51 -08:00
2022-07-24 18:39:17 -06:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2023-01-20 09:33:22 +00:00
2023-02-13 09:49:14 +00:00
2023-04-20 20:20:49 -07:00
2023-04-20 20:20:49 -07:00
2023-04-09 15:35:49 +01:00
2023-04-03 10:04:27 +01:00
2021-11-29 19:50:45 -08:00
2022-12-05 21:58:27 -08:00
2023-01-13 20:59:14 -08:00
2023-03-28 18:52:28 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2021-12-16 07:18:35 -08:00
2022-07-28 22:21:54 -07:00
2023-04-20 19:25:02 -07:00
2023-02-20 16:46:10 -08:00
2023-01-27 11:19:46 +00:00
2023-04-12 16:40:39 -07:00
2022-12-01 15:09:10 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-10-18 12:54:41 +01:00
2022-11-21 13:09:07 +00:00
2022-10-31 10:43:04 +00:00
2021-01-29 20:39:14 -08:00
2022-08-25 16:07:42 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2023-04-19 18:48:48 -07:00
2022-07-22 12:53:22 +01:00
2021-06-28 14:29:45 -07:00
2023-03-07 20:11:36 +01:00
2023-01-28 13:55:10 +01:00
2022-04-06 22:09:39 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-29 11:58:54 +01:00
2022-07-22 12:53:22 +01:00
2022-08-24 19:30:07 -07:00
2022-02-07 20:12:45 -08:00
2021-10-15 11:33:08 +01:00
2023-04-20 20:20:49 -07:00
2022-12-30 07:25:52 +00:00
2023-03-17 08:56:37 +00:00
2022-12-30 07:25:52 +00:00
2022-02-17 07:00:39 -06:00
2021-11-16 13:16:54 +00:00
2023-03-29 08:22:52 +01:00
2023-03-28 18:52:22 -07:00
2022-04-25 11:40:45 +01:00
2022-04-11 17:37:50 -07:00
2023-04-13 16:43:38 -07:00
2023-04-22 01:39:41 +02:00
2023-05-23 15:38:59 +02:00
2022-09-29 07:18:00 +02:00
2022-07-22 12:53:22 +01:00
2022-10-31 20:14:27 -07:00
2022-09-02 20:34:32 -07:00
2023-02-13 19:55:32 -08:00
2021-03-23 14:14:50 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-12-07 20:44:59 -08:00
2021-10-13 09:40:46 -07:00
2021-07-27 13:05:56 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-28 11:29:36 +02:00
2021-11-07 19:25:29 +00:00
2021-08-30 01:51:36 +02:00
2023-04-18 14:48:01 +02:00
2022-10-12 12:57:19 +02:00
2022-09-23 06:56:08 -07:00
2022-04-01 12:04:15 +01:00
2021-10-29 13:23:51 +01:00
2021-03-26 15:14:56 -07:00
2022-07-22 12:53:22 +01:00
2022-12-12 13:11:24 -08:00
2022-11-18 12:14:55 +00:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2023-03-21 21:32:18 -07:00
2022-05-11 12:43:10 +01:00
2022-10-24 11:04:43 +01:00
2021-12-10 06:38:26 -08:00
2023-04-18 12:59:01 +02:00
2022-07-22 12:53:22 +01:00
2023-01-28 00:33:51 -08:00
2022-07-22 12:53:22 +01:00
2023-05-11 18:07:05 -07:00
2023-01-28 13:51:22 +01:00
2022-07-22 12:53:22 +01:00
2023-05-23 20:25:13 -07:00
2022-12-01 12:42:46 +01:00
2023-02-20 16:46:10 -08:00
2023-04-13 22:22:10 -07:00
2022-07-22 12:53:22 +01:00
2022-07-15 18:50:35 -07:00
2021-08-09 15:34:21 -07:00
2022-07-22 12:53:22 +01:00
2023-04-06 12:01:20 -07:00
2023-03-17 08:56:37 +00:00
2022-10-11 17:42:58 -06:00
2022-07-22 12:53:22 +01:00
2022-02-02 14:45:18 +00:00
2022-08-01 11:59:23 -07:00
2023-03-28 18:52:22 -07:00
2022-10-31 18:10:21 -07:00
2023-02-20 16:46:10 -08:00
2023-03-15 08:20:12 +00:00
2022-07-22 12:53:22 +01:00
2022-01-04 12:17:35 +00:00
2021-04-28 14:06:45 -07:00
2023-03-15 08:18:35 +00:00
2022-10-25 11:35:16 +02:00
2023-05-09 20:09:49 -07:00
2021-08-03 13:05:26 +01:00
2022-07-22 12:53:22 +01:00
2022-07-18 11:24:10 +01:00
2022-11-09 19:06:13 -08:00
2023-02-16 09:27:07 +01:00
2023-04-13 16:43:38 -07:00
2023-05-19 08:37:37 +01:00
2022-10-24 09:40:39 +01:00
2022-12-12 15:04:39 -08:00
2022-07-22 12:53:22 +01:00
2022-11-08 16:42:28 +00:00
2022-10-24 10:52:50 +01:00
2022-10-12 17:50:37 -07:00
2023-03-17 22:41:16 -07:00
2023-03-18 12:23:34 +00:00
2022-07-22 12:53:22 +01:00
2022-09-30 07:55:46 -07:00
2023-03-07 09:33:43 -08:00
2023-04-13 16:43:38 -07:00
2023-03-20 11:29:33 +02:00
2023-04-06 09:53:05 -07:00
368d3cb406