Peter Wang
3911af778f
scsi: ufs: core: Fix deadlock during RTC update
There is a deadlock when runtime suspend waits for the flush of RTC work,
and the RTC work calls ufshcd_rpm_get_sync() to wait for runtime resume.
Here is deadlock backtrace:
kworker/0:1 D 4892.876354 10 10971 4859 0x4208060 0x8 10 0 120 670730152367
ptr f0ffff80c2e40000 0 1 0x00000001 0x000000ff 0x000000ff 0x000000ff
<ffffffee5e71ddb0> __switch_to+0x1a8/0x2d4
<ffffffee5e71e604> __schedule+0x684/0xa98
<ffffffee5e71ea60> schedule+0x48/0xc8
<ffffffee5e725f78> schedule_timeout+0x48/0x170
<ffffffee5e71fb74> do_wait_for_common+0x108/0x1b0
<ffffffee5e71efe0> wait_for_completion+0x44/0x60
<ffffffee5d6de968> __flush_work+0x39c/0x424
<ffffffee5d6decc0> __cancel_work_sync+0xd8/0x208
<ffffffee5d6dee2c> cancel_delayed_work_sync+0x14/0x28
<ffffffee5e2551b8> __ufshcd_wl_suspend+0x19c/0x480
<ffffffee5e255fb8> ufshcd_wl_runtime_suspend+0x3c/0x1d4
<ffffffee5dffd80c> scsi_runtime_suspend+0x78/0xc8
<ffffffee5df93580> __rpm_callback+0x94/0x3e0
<ffffffee5df90b0c> rpm_suspend+0x2d4/0x65c
<ffffffee5df91448> __pm_runtime_suspend+0x80/0x114
<ffffffee5dffd95c> scsi_runtime_idle+0x38/0x6c
<ffffffee5df912f4> rpm_idle+0x264/0x338
<ffffffee5df90f14> __pm_runtime_idle+0x80/0x110
<ffffffee5e24ce44> ufshcd_rtc_work+0x128/0x1e4
<ffffffee5d6e3a40> process_one_work+0x26c/0x650
<ffffffee5d6e65c8> worker_thread+0x260/0x3d8
<ffffffee5d6edec8> kthread+0x110/0x134
<ffffffee5d616b18> ret_from_fork+0x10/0x20
Skip updating RTC if RPM state is not RPM_ACTIVE.
Fixes: 6bf999e0eb ("scsi: ufs: core: Add UFS RTC support")
Cc: stable@vger.kernel.org # 6.9.x
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20240715063831.29792-1-peter.wang@mediatek.com
Reviewed-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2024-07-15 22:57:16 -04:00
..
2024-05-19 09:21:03 -07:00
2024-05-24 08:43:25 -07:00
2024-05-22 12:26:46 -07:00
2024-05-21 10:09:28 -07:00
2024-05-06 18:26:47 -07:00
2024-05-22 10:45:12 -07:00
2024-05-23 13:38:31 -07:00
2024-05-23 13:44:47 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 20:14:47 -04:00
2024-05-15 12:59:55 -06:00
2024-05-25 14:32:29 -07:00
2024-05-18 12:48:37 -07:00
2024-05-22 09:56:00 -07:00
2024-05-21 11:40:49 -07:00
2024-05-16 08:50:32 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 20:14:47 -04:00
2024-05-19 09:21:03 -07:00
2024-05-09 00:30:37 +09:00
2024-05-21 11:15:56 -07:00
2024-05-22 20:14:47 -04:00
2024-05-13 16:53:53 -07:00
2024-05-14 08:31:10 -07:00
2024-05-09 01:03:39 +09:00
2024-05-14 18:57:22 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 12:26:46 -07:00
2024-05-23 12:04:36 -07:00
2024-05-24 17:28:02 -07:00
2024-05-22 10:45:12 -07:00
2024-05-22 12:26:46 -07:00
2024-05-22 12:13:40 -07:00
2024-05-22 12:26:46 -07:00
2024-05-20 08:55:18 -07:00
2024-05-23 00:29:19 +02:00
2024-05-22 12:26:46 -07:00
2024-05-22 20:14:47 -04:00
2024-05-24 09:01:21 -07:00
2024-05-22 20:14:47 -04:00
2024-05-23 12:28:01 -07:00
2024-05-23 04:48:40 -07:00
2024-05-17 09:05:46 -07:00
2024-05-19 22:33:28 -05:00
2024-05-21 11:43:11 -07:00
2024-05-22 20:14:47 -04:00
2024-05-17 08:53:47 -07:00
2024-05-14 18:25:53 -07:00
2024-05-21 10:09:28 -07:00
2024-05-23 12:28:01 -07:00
2024-05-16 08:56:49 -07:00
2024-05-21 09:51:42 -07:00
2024-05-23 12:49:37 -07:00
2024-05-23 12:04:36 -07:00
2024-05-14 09:14:49 -06:00
2024-05-20 08:55:18 -07:00
2024-05-17 13:01:24 +02:00
2024-05-21 10:09:28 -07:00
2024-05-23 12:09:22 -07:00
2024-05-21 11:19:18 -07:00
2024-05-22 10:41:14 -07:00
2024-05-22 12:13:40 -07:00
2024-05-21 11:40:49 -07:00
2024-05-20 08:55:18 -07:00
2024-05-14 19:42:24 -07:00
2024-05-10 07:30:27 +02:00
2024-05-14 23:36:19 +09:00
2024-05-23 13:39:42 -07:00
2024-05-06 13:34:12 -06:00
2024-05-18 12:48:37 -07:00
2024-05-23 12:04:36 -07:00
2024-05-07 23:40:46 +02:00
2024-05-21 12:09:36 -07:00
2024-07-10 22:51:44 -04:00
2024-05-08 19:21:51 +01:00
2024-05-22 20:14:47 -04:00
2024-05-21 11:23:36 -07:00
2024-05-14 14:41:01 -07:00
2024-05-08 19:46:11 +01:00
2024-05-22 12:11:48 -07:00
2024-05-21 13:11:44 -07:00
2024-05-22 20:14:47 -04:00
2024-05-10 10:25:22 +01:00
2024-05-24 08:38:28 -07:00
2024-07-15 22:57:16 -04:00
2024-06-13 21:03:13 -04:00
2024-05-22 08:32:48 -04:00
2024-05-20 14:56:50 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 10:45:12 -07:00
2024-05-19 09:21:03 -07:00
2024-05-23 12:04:36 -07:00
2024-05-11 11:32:06 +02:00
2024-05-24 10:24:49 -07:00
2024-05-10 04:34:52 +09:00