Hans Schillstrom
f7a1dd6e3a
ipvs: ip_vs_sip_fill_param() BUG: bad check of return value
The reason for this patch is crash in kmemdup
caused by returning from get_callid with uniialized
matchoff and matchlen.
Removing Zero check of matchlen since it's done by ct_sip_get_header()
BUG: unable to handle kernel paging request at ffff880457b5763f
IP: [<ffffffff810df7fc>] kmemdup+0x2e/0x35
PGD 27f6067 PUD 0
Oops: 0000 [#1] PREEMPT SMP
Modules linked in: xt_state xt_helper nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_mangle xt_connmark xt_conntrack ip6_tables nf_conntrack_ftp ip_vs_ftp nf_nat xt_tcpudp iptable_mangle xt_mark ip_tables x_tables ip_vs_rr ip_vs_lblcr ip_vs_pe_sip ip_vs nf_conntrack_sip nf_conntrack bonding igb i2c_algo_bit i2c_core
CPU 5
Pid: 0, comm: swapper/5 Not tainted 3.9.0-rc5+ #5 /S1200KP
RIP: 0010:[<ffffffff810df7fc>] [<ffffffff810df7fc>] kmemdup+0x2e/0x35
RSP: 0018:ffff8803fea03648 EFLAGS: 00010282
RAX: ffff8803d61063e0 RBX: 0000000000000003 RCX: 0000000000000003
RDX: 0000000000000003 RSI: ffff880457b5763f RDI: ffff8803d61063e0
RBP: ffff8803fea03658 R08: 0000000000000008 R09: 0000000000000011
R10: 0000000000000011 R11: 00ffffffff81a8a3 R12: ffff880457b5763f
R13: ffff8803d67f786a R14: ffff8803fea03730 R15: ffffffffa0098e90
FS: 0000000000000000(0000) GS:ffff8803fea00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffff880457b5763f CR3: 0000000001a0c000 CR4: 00000000001407e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process swapper/5 (pid: 0, threadinfo ffff8803ee18c000, task ffff8803ee18a480)
Stack:
ffff8803d822a080 000000000000001c ffff8803fea036c8 ffffffffa000937a
ffffffff81f0d8a0 000000038135fdd5 ffff880300000014 ffff880300110000
ffffffff150118ac ffff8803d7e8a000 ffff88031e0118ac 0000000000000000
Call Trace:
<IRQ>
[<ffffffffa000937a>] ip_vs_sip_fill_param+0x13a/0x187 [ip_vs_pe_sip]
[<ffffffffa007b209>] ip_vs_sched_persist+0x2c6/0x9c3 [ip_vs]
[<ffffffff8107dc53>] ? __lock_acquire+0x677/0x1697
[<ffffffff8100972e>] ? native_sched_clock+0x3c/0x7d
[<ffffffff8100972e>] ? native_sched_clock+0x3c/0x7d
[<ffffffff810649bc>] ? sched_clock_cpu+0x43/0xcf
[<ffffffffa007bb1e>] ip_vs_schedule+0x181/0x4ba [ip_vs]
...
Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-04-29 11:35:30 -04:00
..
2013-04-18 23:40:41 +02:00
2013-04-29 11:35:30 -04:00
2012-12-03 15:07:48 +01:00
2013-02-21 12:05:51 -08:00
2013-01-21 12:20:19 +01:00
2013-01-23 12:55:29 +01:00
2013-02-19 02:48:05 +01:00
2011-01-18 18:12:24 +01:00
2013-01-23 12:56:33 +01:00
2013-01-23 12:55:50 +01:00
2013-02-27 19:10:24 -08:00
2012-06-16 15:08:49 +02:00
2013-02-19 02:48:05 +01:00
2011-04-04 15:21:02 +02:00
2013-02-19 02:48:05 +01:00
2013-03-07 15:20:02 -05:00
2013-02-19 02:48:05 +01:00
2013-01-23 12:56:23 +01:00
2011-01-18 18:12:24 +01:00
2013-02-27 19:10:24 -08:00
2013-02-05 05:10:02 +01:00
2013-03-15 12:29:25 +01:00
2012-07-04 19:37:22 +02:00
2013-03-15 12:29:25 +01:00
2013-03-15 12:29:25 +01:00
2012-12-03 15:13:10 +01:00
2012-07-04 19:37:22 +02:00
2013-03-15 12:29:25 +01:00
2013-01-23 14:40:53 +01:00
2013-02-19 02:48:05 +01:00
2013-04-06 14:03:18 +02:00
2013-01-18 00:28:18 +01:00
2013-03-27 18:31:17 +01:00
2013-02-19 02:48:05 +01:00
2013-01-23 12:56:02 +01:00
2013-01-23 12:55:39 +01:00
2012-09-03 13:52:54 +02:00
2012-11-19 14:29:46 +01:00
2013-02-19 02:48:05 +01:00
2013-04-12 11:46:31 +02:00
2013-02-19 02:48:05 +01:00
2012-08-30 03:00:14 +02:00
2013-02-19 02:48:05 +01:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2012-08-30 03:00:14 +02:00
2013-02-19 02:48:05 +01:00
2013-02-19 02:48:05 +01:00
2012-12-03 15:07:48 +01:00
2011-02-17 11:32:38 +01:00
2013-03-25 14:21:30 +01:00
2013-02-27 19:10:24 -08:00
2012-11-21 23:50:14 +01:00
2013-02-27 19:10:24 -08:00
2013-03-25 14:21:27 +01:00
2012-06-23 02:13:38 +02:00
2013-03-04 14:45:36 +01:00
2013-02-18 14:53:08 -05:00
2011-12-16 15:49:52 -05:00
2013-03-04 14:45:25 +01:00
2013-01-21 12:20:19 +01:00
2010-07-15 17:20:46 +02:00
2010-11-15 13:57:56 +01:00
2011-12-25 02:21:45 -05:00
2013-01-18 00:28:15 +01:00
2013-02-27 19:10:24 -08:00
2011-05-10 12:13:36 +02:00
2011-01-18 06:33:54 +01:00
2013-02-05 01:49:26 +01:00
2011-02-03 00:05:43 +01:00
2011-05-10 10:00:21 +02:00
2011-12-27 20:45:25 +01:00
2013-02-27 19:10:24 -08:00
2011-07-01 16:11:15 -07:00
2011-07-01 16:11:15 -07:00
2012-11-09 17:05:07 -08:00
2011-11-01 09:19:49 +01:00
2011-02-04 14:28:58 -08:00
2012-09-28 11:34:33 +09:00
2011-01-18 06:33:54 +01:00
2012-09-26 01:33:16 +02:00
2012-10-02 11:11:09 -07:00
2012-05-09 20:49:18 -04:00
2012-10-15 13:39:12 +02:00
2012-09-21 12:11:08 +02:00
2011-12-25 02:43:17 +01:00
2012-08-20 12:45:57 +02:00
2012-08-20 12:45:57 +02:00
2012-08-14 21:55:30 -07:00
2011-10-31 19:30:28 -04:00
2011-07-29 16:24:46 +02:00
2013-02-27 19:10:24 -08:00
2013-02-26 20:16:07 -08:00
2012-09-21 12:12:05 +02:00
2010-06-09 14:47:40 +02:00
2010-10-21 10:12:48 +11:00
2012-09-22 22:44:34 +02:00
2012-09-03 13:31:39 +02:00
2011-10-31 19:30:28 -04:00
2012-05-15 13:45:03 -04:00
2011-12-16 15:49:52 -05:00
2012-10-17 11:00:31 +02:00
2012-09-24 14:29:01 +02:00
2012-07-10 23:13:45 -07:00