Tejun Heo 39efa3ef3a
signal: Use GROUP_STOP_PENDING to stop once for a single group stop ...
Currently task->signal->group_stop_count is used to decide whether to
stop for group stop. However, if there is a task in the group which
is taking a long time to stop, other tasks which are continued by
ptrace would repeatedly stop for the same group stop until the group
stop is complete.
Conversely, if a ptraced task is in TASK_TRACED state, the debugger
won't get notified of group stops which is inconsistent compared to
the ptraced task in any other state.
This patch introduces GROUP_STOP_PENDING which tracks whether a task
is yet to stop for the group stop in progress. The flag is set when a
group stop starts and cleared when the task stops the first time for
the group stop, and consulted whenever whether the task should
participate in a group stop needs to be determined. Note that now
tasks in TASK_TRACED also participate in group stop.
This results in the following behavior changes.
* For a single group stop, a ptracer would see at most one stop
reported.
* A ptracee in TASK_TRACED now also participates in group stop and the
tracer would get the notification. However, as a ptraced task could
be in TASK_STOPPED state or any ptrace trap could consume group
stop, the notification may still be missing. These will be
addressed with further patches.
* A ptracee may start a group stop while one is still in progress if
the tracer let it continue with stop signal delivery. Group stop
code handles this correctly.
Oleg:
* Spotted that a task might skip signal check even when its
GROUP_STOP_PENDING is set. Fixed by updating
recalc_sigpending_tsk() to check GROUP_STOP_PENDING instead of
group_stop_count.
* Pointed out that task->group_stop should be cleared whenever
task->signal->group_stop_count is cleared. Fixed accordingly.
* Pointed out the behavior inconsistency between TASK_TRACED and
RUNNING and the last behavior change.
Signed-off-by: Tejun Heo <tj@kernel.org >
Acked-by: Oleg Nesterov <oleg@redhat.com >
Cc: Roland McGrath <roland@redhat.com >
2011-03-23 10:37:00 +01:00
2011-03-17 11:04:51 +00:00
2011-01-30 01:14:14 -08:00
2011-03-22 11:33:55 -07:00
2011-01-13 08:03:25 -08:00
2011-03-22 10:05:27 -07:00
2011-03-18 23:38:50 -07:00
2010-12-16 12:37:26 -05:00
2011-03-19 22:27:06 -07:00
2011-01-12 14:49:17 -08:00
2011-03-17 15:35:22 -04:00
2011-03-18 10:50:27 -07:00
2011-03-20 15:33:26 +01:00
2011-01-20 17:50:17 +01:00
2011-01-20 17:50:17 +01:00
2011-01-20 17:50:17 +01:00
2011-01-13 08:03:19 -08:00
2011-01-13 21:04:07 -05:00
2011-03-16 15:11:04 -07:00
2011-01-14 18:11:59 +03:00
2011-01-12 14:33:05 +00:00
2011-03-19 22:27:06 -07:00
2011-02-18 16:54:54 -05:00
2011-03-17 12:38:59 -04:00
2011-01-13 08:03:08 -08:00
2011-03-16 15:11:04 -07:00
2011-01-20 18:30:17 -08:00
2011-01-20 18:30:17 -08:00
2010-11-23 20:14:46 +00:00
2011-03-15 02:42:32 -04:00
2011-01-31 14:03:00 -08:00
2010-12-10 15:45:05 -08:00
2010-11-12 07:55:30 -08:00
2011-01-19 23:51:37 +01:00
2011-01-15 20:07:45 -05:00
2010-12-06 15:58:43 -05:00
2011-03-22 17:43:59 -07:00
2011-01-10 13:31:14 -08:00
2011-01-13 08:03:12 -08:00
2010-11-10 14:54:09 +01:00
2011-01-07 17:50:31 +11:00
2010-11-15 13:27:04 -05:00
2010-11-10 14:54:09 +01:00
2011-03-02 08:48:05 -05:00
2011-03-03 10:53:20 -05:00
2010-12-13 16:11:13 -08:00
2010-11-29 08:35:12 +11:00
2011-01-13 08:03:17 -08:00
2010-12-16 17:53:38 +01:00
2011-02-16 13:30:48 +01:00
2011-02-16 13:30:48 +01:00
2010-11-26 10:51:04 +00:00
2010-12-20 09:07:35 -08:00
2011-03-22 17:44:00 -07:00
2011-03-22 17:44:10 -07:00
2011-03-22 17:44:10 -07:00
2011-03-22 17:44:10 -07:00
2011-01-05 14:15:50 +01:00
2011-02-23 13:22:26 -08:00
2011-01-26 10:50:06 +10:00
2010-12-13 23:40:45 -05:00
2011-01-24 14:51:56 -08:00
2010-11-10 16:57:11 -08:00
2011-03-16 17:54:33 -04:00
2011-01-12 12:47:34 -05:00
2011-01-13 08:03:22 -08:00
2010-11-30 13:39:55 +00:00
2011-03-22 17:44:15 -07:00
2011-01-13 08:03:13 -08:00
2011-03-21 12:13:10 -04:00
2011-03-14 17:02:43 -07:00
2011-01-20 17:01:09 -08:00
2011-01-10 08:51:44 -08:00
2011-03-08 16:10:38 +01:00
2011-01-13 20:00:02 +00:00
2011-03-16 17:28:10 -07:00
2011-01-13 19:59:58 +00:00
2011-01-13 19:59:52 +00:00
2011-01-17 10:54:41 -08:00
2010-11-26 09:57:36 +01:00
2011-02-25 12:00:34 -08:00
2011-03-07 01:12:28 +05:30
2011-02-03 15:39:16 -08:00
2011-03-14 08:40:51 -07:00
2010-12-17 15:07:19 +01:00
2011-03-22 17:44:11 -07:00
2011-01-13 21:49:56 -08:00
2011-03-18 15:13:11 -07:00
2011-03-15 02:21:37 -04:00
2011-03-08 11:38:10 +11:00
2011-01-12 20:16:43 -05:00
2010-12-15 13:56:33 -05:00
2011-03-17 09:19:20 +08:00
2011-03-14 19:12:20 -04:00
2011-01-09 15:42:55 -08:00
2011-03-15 02:21:45 -04:00
2010-12-08 10:30:34 -08:00
2010-11-01 15:38:34 -04:00
2011-03-21 10:05:22 -07:00
2011-01-10 08:51:44 -08:00
2011-02-03 15:39:17 -08:00
2010-11-30 17:28:57 -05:00
2011-02-16 17:48:59 +01:00
2011-01-07 17:50:27 +11:00
2011-03-22 17:44:10 -07:00
2010-11-15 13:49:51 +09:00
2011-01-07 17:50:23 +11:00
2011-01-07 17:50:23 +11:00
2011-03-10 10:31:48 -05:00
2011-02-11 16:23:33 -05:00
2010-12-07 20:16:56 +01:00
2011-01-07 17:50:29 +11:00
2011-01-13 14:47:54 +01:00
2011-03-22 17:44:05 -07:00
2010-12-06 17:15:15 -08:00
2011-01-10 22:11:23 +01:00
2011-01-14 08:06:39 -08:00
2011-03-05 10:56:00 +01:00
2011-02-03 16:37:28 +01:00
2011-03-17 14:31:46 +01:00
2011-02-11 15:05:49 +01:00
2010-12-17 15:18:04 +01:00
2011-03-10 19:15:58 +01:00
2011-02-15 15:21:11 -08:00
2010-11-12 14:51:55 +01:00
2011-02-17 09:52:03 -08:00
2010-11-09 09:31:10 -08:00
2011-02-23 00:53:26 +00:00
2011-03-20 14:50:53 +01:00
2011-03-12 15:08:54 -08:00
2011-03-09 16:10:56 -05:00
2010-11-19 17:47:57 +08:00
2011-01-11 23:55:51 +01:00
2011-01-06 11:10:05 -08:00
2011-01-19 23:31:09 -08:00
2010-11-16 10:58:30 -08:00
2011-03-18 15:14:45 -07:00
2010-11-12 12:30:57 -08:00
2011-02-27 16:11:51 -08:00
2011-03-10 16:37:26 -08:00
2011-02-10 07:51:44 -05:00
2011-02-18 12:42:28 -08:00
2011-01-06 10:23:33 -08:00
2011-01-31 21:17:41 -08:00
2011-01-31 21:16:59 -08:00
2011-03-15 19:23:40 -07:00
2010-11-11 13:40:11 +01:00
2010-12-17 10:01:09 -08:00
2010-11-25 10:42:59 +09:00
2010-12-14 00:21:51 -05:00
2010-12-14 00:21:51 -05:00
2010-11-24 11:16:42 -08:00
2011-03-12 11:12:58 +01:00
2011-03-11 14:15:35 +01:00
2010-10-28 11:58:39 +02:00
2011-01-10 12:29:43 -05:00
2010-12-09 20:17:07 -08:00
2011-01-26 12:33:20 +01:00
2010-10-29 14:45:29 -04:00
2011-03-22 16:17:32 -07:00
2011-01-31 14:03:00 -08:00
2011-02-17 11:12:40 -08:00
2011-01-13 17:32:31 -08:00
2011-03-22 17:44:14 -07:00
2011-03-08 11:17:18 +11:00
2011-03-08 11:17:18 +11:00
2011-03-08 11:17:22 +11:00
2010-10-29 13:14:41 -05:00
2011-01-13 17:32:47 -08:00
2011-02-13 16:54:24 -08:00
2011-01-24 14:45:11 +10:30
2011-01-13 08:03:07 -08:00
2011-02-18 08:02:10 -08:00
2011-01-07 17:02:58 -08:00
2011-01-07 08:43:37 +01:00
2011-03-22 17:44:01 -07:00
2011-03-17 13:08:30 -03:00
2011-01-12 11:23:08 +02:00
2011-01-12 11:23:12 +02:00
2011-03-22 17:43:59 -07:00
2011-01-13 08:03:06 -08:00
2011-01-13 08:03:05 -08:00
2011-03-22 17:43:59 -07:00
2011-03-14 02:52:41 -04:00
2011-01-14 13:12:45 +00:00
2011-02-18 11:32:28 -08:00
2011-01-21 13:38:57 -08:00
2011-03-18 22:33:38 -07:00
2010-11-22 08:34:23 -08:00
2011-01-10 19:04:08 +01:00
2010-12-06 11:03:46 -08:00
2011-03-22 17:44:03 -07:00
2011-01-15 13:28:17 +02:00
2011-02-03 16:08:57 -08:00
2011-02-14 17:38:30 -08:00
2011-01-13 17:32:34 -08:00
2011-01-13 17:32:46 -08:00
2011-03-22 17:44:03 -07:00
2011-03-22 17:44:04 -07:00
2011-01-13 17:32:46 -08:00
2011-02-15 10:24:31 +01:00
2011-02-21 15:21:53 -08:00
2011-01-24 14:32:52 +10:30
2011-01-16 13:47:07 -05:00
2011-02-03 18:05:29 -08:00
2011-01-30 01:14:38 -08:00
2011-03-02 13:43:15 -08:00
2010-11-26 15:05:34 +01:00
2011-03-18 09:04:20 -04:00
2011-01-12 20:03:43 -05:00
2011-01-12 20:03:43 -05:00
2011-02-22 10:19:31 -08:00
2011-03-16 12:53:54 -07:00
2011-01-18 16:08:30 +01:00
2011-03-03 13:32:07 -08:00
2010-12-16 12:37:23 -05:00
2011-01-14 13:17:26 -08:00
2011-03-11 15:39:27 -05:00
2011-03-11 15:38:40 -05:00
2011-03-11 15:39:26 -05:00
2011-03-11 15:38:44 -05:00
2011-03-11 15:38:44 -05:00
2011-03-14 18:25:53 -04:00
2011-01-25 15:24:47 -05:00
2011-03-10 17:29:40 +09:00
2011-03-01 13:48:21 -05:00
2010-12-22 22:15:32 +01:00
2011-02-03 16:08:57 -08:00
2010-12-23 15:57:48 -07:00
2011-02-28 01:36:38 -07:00
2011-01-15 22:01:58 -07:00
2010-11-01 01:08:14 -04:00
2011-02-04 11:46:50 -07:00
2011-03-01 09:38:26 -07:00
2011-03-16 17:28:10 -07:00
2011-02-15 11:10:20 +01:00
2011-01-14 07:52:02 -08:00
2011-03-22 17:44:03 -07:00
2011-03-22 17:44:02 -07:00
2011-03-14 02:58:03 -04:00
2011-01-16 13:47:07 -05:00
2011-03-18 10:56:44 -07:00
2010-12-23 12:54:03 -08:00
2011-01-16 11:56:26 -08:00
2010-12-23 12:53:08 -08:00
2011-03-18 10:56:44 -07:00
2011-02-28 11:20:03 +01:00
2011-03-16 14:04:14 +01:00
2011-03-09 11:59:33 -08:00
2011-01-10 07:38:54 -08:00
2011-02-24 22:11:56 -08:00
2011-02-18 08:15:51 -08:00
2011-03-11 15:13:26 -05:00
2011-03-15 00:43:14 +01:00
2011-03-15 00:43:14 +01:00
2011-03-15 00:43:16 +01:00
2010-12-10 15:06:43 +01:00
2011-01-25 15:24:47 -05:00
2011-02-02 15:28:20 +01:00
2011-02-02 15:28:20 +01:00
2011-01-13 08:03:21 -08:00
2011-01-13 08:03:21 -08:00
2011-01-13 08:03:10 -08:00
2010-12-28 14:25:21 -08:00
2011-03-04 09:23:30 -08:00
2011-03-22 17:44:00 -07:00
2010-12-02 17:55:12 +01:00
2011-01-12 19:14:55 +01:00
2011-01-12 19:14:55 +01:00
2011-01-13 17:32:48 -08:00
2010-10-29 04:16:31 -04:00
2010-11-29 11:17:22 -08:00
2011-01-14 02:36:43 +00:00
2010-12-17 12:34:59 -08:00
2010-12-17 12:34:08 -08:00
2010-11-29 22:01:58 -08:00
2010-11-29 22:01:58 -08:00
2010-11-17 08:59:32 -08:00
2011-02-01 11:12:29 -05:00
2011-02-02 16:03:19 -08:00
2010-11-12 07:55:30 -08:00
2010-11-15 13:24:06 -05:00
2011-03-09 13:52:27 -05:00
2011-01-13 08:03:17 -08:00
2011-01-13 08:03:18 -08:00
2011-02-25 15:07:37 -08:00
2011-01-13 08:03:18 -08:00
2011-03-22 17:44:03 -07:00
2011-01-13 08:03:23 -08:00
2011-03-09 11:23:37 -08:00
2010-11-15 11:29:30 -08:00
2011-01-27 12:30:38 +01:00
2011-01-27 12:30:39 +01:00
2011-01-27 12:30:40 +01:00
2010-12-22 02:39:57 +03:00
2011-03-23 10:37:00 +01:00
2011-03-16 16:29:25 -07:00
2010-10-30 12:12:50 +02:00
2011-01-07 17:50:27 +11:00
2011-01-13 08:03:19 -08:00
2010-11-30 14:11:49 -08:00
2011-01-19 15:37:31 +09:00
2010-11-09 14:45:52 +01:00
2010-11-15 18:48:25 +09:00
2010-11-09 16:38:20 +09:00
2010-10-31 10:40:39 -04:00
2011-03-22 17:44:15 -07:00
2011-03-16 12:53:54 -07:00
2010-11-28 21:16:28 +02:00
2011-01-23 21:00:05 +02:00
2011-03-22 20:48:04 +02:00
2011-03-22 17:44:11 -07:00
2010-12-08 12:16:33 -08:00
2011-01-13 10:25:58 -08:00
2011-03-09 14:08:09 -08:00
2011-01-10 12:00:22 -05:00
2011-01-27 12:30:38 +01:00
2010-11-18 14:37:34 +01:00
2010-11-24 11:14:24 -08:00
2011-03-15 00:43:16 +01:00
2011-03-22 17:44:04 -07:00
2011-03-21 00:40:29 -04:00
2011-03-15 00:43:46 +01:00
2011-03-09 16:43:24 -08:00
2011-01-24 09:33:36 -08:00
2010-12-22 19:43:34 -08:00
2011-02-28 18:00:31 -08:00
2011-02-02 15:28:13 +01:00
2011-02-04 12:41:21 -08:00
2011-02-21 12:53:08 -08:00
2010-12-11 12:34:34 +01:00
2011-02-02 15:28:18 +01:00
2011-03-13 16:35:18 -04:00
2011-02-23 18:05:11 -05:00
2011-01-13 08:03:08 -08:00
2010-11-29 08:55:25 +11:00
2010-11-29 08:55:22 +11:00
2011-03-23 10:37:00 +01:00
2011-02-03 09:28:46 -05:00
2011-02-17 11:59:56 -08:00
2011-01-13 08:03:20 -08:00
2011-03-22 16:17:32 -07:00
2011-03-22 17:44:09 -07:00
2010-11-28 23:08:04 +01:00
2010-12-20 09:37:33 +01:00
2010-11-10 16:57:11 -08:00
2011-02-04 11:48:55 -08:00
2011-01-13 08:03:18 -08:00
2011-01-06 13:05:04 +10:00
2010-11-10 12:04:41 +09:00
2010-12-11 02:01:35 -05:00
2011-01-24 14:45:11 +10:30
2011-02-09 08:19:55 +10:30
2011-01-13 17:32:34 -08:00
2011-03-22 17:44:05 -07:00
2011-02-17 11:13:19 -08:00
2010-11-15 13:25:02 -05:00
2011-02-21 10:07:23 +01:00
2010-10-30 09:05:48 -07:00
2011-01-17 08:05:27 -08:00
2011-03-13 20:22:28 -07:00
2011-01-13 08:03:24 -08:00
2011-03-22 17:44:17 -07:00
39efa3ef3a