mirror
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/phy/marvell
History
Pali Rohár 0a6fc70d76 phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support 
Reset support for SATA PHY is somehow broken and after calling it, kernel
is not able to detect and initialize SATA disk Samsung SSD 850 EMT0 [1].

Reset support was introduced in commit 934337080c ("phy: marvell:
phy-mvebu-a3700-comphy: Add native kernel implementation") as part of
complete rewrite of this driver. v1 patch series of that commit [2] did
not contain reset support and was tested that is working fine with
Ethernet, SATA and USB PHYs without issues too.

So for now remove broken reset support and change implementation of
power_off callback to power off all functions on specified lane (and not
only selected function) because during startup kernel does not know which
function was selected and configured by bootloader. Same logic was used
also in v1 patch series of that commit.

This change fixes issues with initialization of SATA disk Samsung SSD 850
and disk is working again, like before mentioned commit.

Once problem with PHY reset callback is solved its functionality could be
re-introduced. But for now it is unknown why it does not work.

[1] - https://lore.kernel.org/r/20220531124159.3e4lgn2v462irbtz@shindev/
[2] - https://lore.kernel.org/r/20211028184242.22105-1-kabel@kernel.org/

Reported-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Fixes: 934337080c ("phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation")
Cc: stable@vger.kernel.org # v5.18+
Signed-off-by: Pali Rohár <pali@kernel.org>
Tested-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Link: https://lore.kernel.org/r/20220829083046.15082-1-pali@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
 		2022-08-30 10:32:33 +05:30
..
Kconfig phy: marvell: phy-mvebu-cp11i-utmi needs USB_COMMON 2021-04-06 10:34:20 +05:30
Makefile drivers: phy: add support for Armada CP110 UTMI PHY 2021-03-30 23:32:53 +05:30
phy-armada38x-comphy.c phy: armada-38x: fix NETA lockup when repeatedly switching speeds 2020-07-21 22:57:46 +05:30
phy-armada375-usb2.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-berlin-sata.c
…
phy-berlin-usb.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-mmp3-hsic.c phy: phy-mmp3-hsic: Remove redundant dev_err call in mmp3_hsic_phy_probe() 2021-06-14 11:00:52 +05:30
phy-mmp3-usb.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-mvebu-a3700-comphy.c phy: marvell: phy-mvebu-a3700-comphy: Remove broken reset support 2022-08-30 10:32:33 +05:30
phy-mvebu-a3700-utmi.c
…
phy-mvebu-cp110-comphy.c phy: marvell: phy-mvebu-cp110-comphy: add support for 5gbase-r 2021-11-23 12:14:48 +00:00
phy-mvebu-cp110-utmi.c phy: mvebu-cp110-utmi: Fix kernel-doc warns 2021-11-20 11:33:22 +05:30
phy-mvebu-sata.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-pxa-28nm-hsic.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-pxa-28nm-usb2.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30
phy-pxa-usb.c phy: marvell: convert to devm_platform_ioremap_resource 2020-11-16 12:47:47 +05:30