Julian Wiedmann
7c4046b1c5
Revert "net: sched: make newly activated qdiscs visible"
This reverts commit 4cda75275f
from net-next.
Brown bag time.
Michal noticed that this change doesn't work at all when
netif_set_real_num_tx_queues() gets called prior to an initial
dev_activate(), as for instance igb does.
Doing so dies with:
[ 40.579142] BUG: kernel NULL pointer dereference, address: 0000000000000400
[ 40.586922] #PF: supervisor read access in kernel mode
[ 40.592668] #PF: error_code(0x0000) - not-present page
[ 40.598405] PGD 0 P4D 0
[ 40.601234] Oops: 0000 [#1] PREEMPT SMP PTI
[ 40.605909] CPU: 18 PID: 1681 Comm: wickedd Tainted: G E 5.6.0-rc3-ethnl.50-default #1
[ 40.616205] Hardware name: Intel Corporation S2600CP/S2600CP, BIOS RMLSDP.86I.R3.27.D685.1305151734 05/15/2013
[ 40.627377] RIP: 0010:qdisc_hash_add.part.22+0x2e/0x90
[ 40.633115] Code: 00 55 53 89 f5 48 89 fb e8 2f 9b fb ff 85 c0 74 44 48 8b 43 40 48 8b 08 69 43 38 47 86 c8 61 c1 e8 1c 48 83 e8 80 48 8d 14 c1 <48> 8b 04 c1 48 8d 4b 28 48 89 53 30 48 89 43 28 48 85 c0 48 89 0a
[ 40.654080] RSP: 0018:ffffb879864934d8 EFLAGS: 00010203
[ 40.659914] RAX: 0000000000000080 RBX: ffffffffb8328d80 RCX: 0000000000000000
[ 40.667882] RDX: 0000000000000400 RSI: 0000000000000000 RDI: ffffffffb831faa0
[ 40.675849] RBP: 0000000000000000 R08: ffffa0752c8b9088 R09: ffffa0752c8b9208
[ 40.683816] R10: 0000000000000006 R11: 0000000000000000 R12: ffffa0752d734000
[ 40.691783] R13: 0000000000000008 R14: 0000000000000000 R15: ffffa07113c18000
[ 40.699750] FS: 00007f94548e5880(0000) GS:ffffa0752e980000(0000) knlGS:0000000000000000
[ 40.708782] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 40.715189] CR2: 0000000000000400 CR3: 000000082b6ae006 CR4: 00000000001606e0
[ 40.723156] Call Trace:
[ 40.725888] dev_qdisc_set_real_num_tx_queues+0x61/0x90
[ 40.731725] netif_set_real_num_tx_queues+0x94/0x1d0
[ 40.737286] __igb_open+0x19a/0x5d0 [igb]
[ 40.741767] __dev_open+0xbb/0x150
[ 40.745567] __dev_change_flags+0x157/0x1a0
[ 40.750240] dev_change_flags+0x23/0x60
[...]
Fixes: 4cda75275f ("net: sched: make newly activated qdiscs visible")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
CC: Michal Kubecek <mkubecek@suse.cz>
CC: Eric Dumazet <edumazet@google.com>
CC: Jamal Hadi Salim <jhs@mojatatu.com>
CC: Cong Wang <xiyou.wangcong@gmail.com>
CC: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-03-12 11:19:24 -07:00
..
2019-09-27 15:10:34 -07:00
2020-02-24 13:02:53 -08:00
2020-02-17 14:30:54 -08:00
2019-09-24 16:37:18 +02:00
2020-02-04 03:05:26 +00:00
2020-01-09 18:41:40 -08:00
2020-02-17 22:43:42 +01:00
2020-01-26 10:34:17 +02:00
2020-02-24 16:20:09 -08:00
2020-02-04 01:53:07 +09:00
2020-02-24 11:11:19 -08:00
2020-01-24 08:12:06 +01:00
2019-12-08 11:52:02 +01:00
2020-02-08 13:26:41 -08:00
2020-03-12 11:19:24 -07:00
2020-02-29 15:53:35 -08:00
2020-01-09 18:41:40 -08:00
2020-03-08 21:07:48 -07:00
2020-01-27 11:09:31 +01:00
2020-03-05 12:12:34 -08:00
2020-03-05 11:59:47 -08:00
2019-11-02 13:54:56 -07:00
2019-09-26 08:56:17 +02:00
2020-03-11 23:19:41 -07:00
2020-03-03 14:50:08 -08:00
2019-12-09 10:36:44 -08:00
2020-02-24 16:20:09 -08:00
2020-02-28 12:08:37 -08:00
2020-02-26 20:38:13 -08:00
2020-02-27 18:31:39 -08:00
2020-02-28 12:08:37 -08:00
2020-03-11 23:59:11 -07:00
2020-01-09 18:36:22 -08:00
2020-02-26 23:25:07 +01:00
2020-02-18 12:44:23 -08:00
2020-03-11 23:19:41 -07:00
2020-02-24 13:26:49 -08:00
2020-02-17 19:05:05 -08:00
2020-02-21 13:39:34 -08:00
2020-01-29 14:55:47 -08:00
2020-01-03 12:25:50 -08:00
2019-11-26 14:40:13 -08:00
2020-03-03 17:52:21 -08:00
2020-02-16 18:37:09 -08:00
2019-12-16 10:15:49 +01:00
2020-01-26 10:40:21 +01:00
2020-02-07 11:20:57 +01:00
2020-03-12 11:19:24 -07:00
2020-02-29 15:53:35 -08:00
2020-02-27 18:31:39 -08:00
2020-02-13 15:35:33 -05:00
2020-02-26 20:58:33 -08:00
2020-02-10 10:23:00 +01:00
2020-02-21 15:22:45 -08:00
2020-02-28 12:12:53 -08:00
2020-02-27 18:31:39 -08:00
2020-02-27 18:31:39 -08:00
2020-02-16 18:59:42 -08:00
2020-02-28 12:08:37 -08:00
2020-02-28 12:12:53 -08:00
2019-11-15 14:38:29 +01:00
2020-02-20 15:02:02 -08:00
2020-01-24 13:44:07 +01:00
2020-01-08 15:02:21 -08:00