Richard Weinberger 4756227734 um: call free_irq() only on enabled channels ...

When I use OpenSUSE-11.2 on UML (> 2.6.25)
I get lots of such errors:

Registering fd 1 twice
Irqs : 3, 3
Ids : 0x09cb41a0, 0x09cb4120
------------[ cut here ]------------
WARNING: at kernel/irq/manage.c:896 __free_irq+0x79/0x11a()
Trying to free already-free IRQ 3
Modules linked in:
09dadc6c:  [<081b2edb>] dump_stack+0x1c/0x20
09dadc84:  [<080716da>] warn_slowpath_common+0x49/0x77
09dadc9c:  [<08071772>] warn_slowpath_fmt+0x26/0x2a
09dadcb4:  [<08094e08>] __free_irq+0x79/0x11a
09dadce4:  [<08094ed6>] free_irq+0x2d/0x49
09dadcf4:  [<0805b4bc>] close_one_chan+0x70/0x9c
09dadd0c:  [<0805b833>] close_chan+0x17/0x22
09dadd1c:  [<0805bdda>] enable_chan+0x70/0x7c
09dadd3c:  [<0805cbb7>] line_open+0x34/0x9f
09dadd54:  [<0805b21e>] con_open+0x13/0x35
09dadd6c:  [<0814dc89>] tty_open+0x285/0x384
09dadda0:  [<080b754e>] chrdev_open+0xe0/0xf9
09daddc0:  [<080b3fb2>] __dentry_open+0xf3/0x1e2
09dadde4:  [<080b4142>] nameidata_to_filp+0x35/0x49
09daddfc:  [<080bd270>] do_last+0x409/0x50e
09dade28:  [<080bea04>] do_filp_open+0x175/0x446
09dadecc:  [<080b3d89>] do_sys_open+0x4a/0x128
09dadf04:  [<080b3ea2>] sys_open+0x19/0x21
09dadf28:  [<0805ab5a>] handle_syscall+0x7a/0x98
09dadf78:  [<08068441>] userspace+0x2c9/0x370
09dadfe0:  [<08058bb3>] fork_handler+0x53/0x5b
09dadffc:  [<00766564>] 0x766564

---[ end trace 9ebc1094aaf4bded ]---

This patch fixes the issue.

Signed-off-by: Richard Weinberger <richard@nod.at>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2010-08-09 20:45:04 -07:00

..

chan_kern.c

um: call free_irq() only on enabled channels

2010-08-09 20:45:04 -07:00

chan_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

cow_sys.h

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

cow_user.c

uml: arch/um/drivers formatting

2007-10-16 09:43:09 -07:00

cow.h

[PATCH] uml: avoid warnings for diffent names for an unsigned quadword

2006-04-11 06:18:37 -07:00

daemon_kern.c

um: Kill directly reference of netdev->priv

2008-12-04 15:07:33 -08:00

daemon_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

daemon.h

uml: network formatting

2007-10-16 09:43:08 -07:00

fd.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

harddog_kern.c

uml: Pushdown the bkl from harddog_kern ioctl

2010-05-22 17:44:21 +02:00

harddog_user.c

uml: fix helper_wait calls in watchdog

2008-02-23 17:12:15 -08:00

hostaudio_kern.c

sound: push BKL into open functions

2010-07-12 17:41:05 +02:00

line.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2010-05-20 09:20:59 -07:00

Makefile

x86, um: get rid of arch/um/os symlink

2008-10-22 22:55:22 -07:00

mcast_kern.c

um: Kill directly reference of netdev->priv

2008-12-04 15:07:33 -08:00

mcast_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

mcast.h

uml: network formatting

2007-10-16 09:43:08 -07:00

mconsole_kern.c

Switch may_open() and break_lease() to passing O_...

2010-03-03 13:00:21 -05:00

mconsole_user.c

uml: make three functions static

2008-04-28 08:58:28 -07:00

mmapper_kern.c

um/mmapper: Remove BKL usage

2010-05-17 05:27:03 +02:00

net_kern.c

arch/um/drivers: remove duplicate structure field initialization

2010-07-21 11:16:09 -07:00

net_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

null.c

spelling fixes: arch/um/

2007-10-20 01:23:03 +02:00

pcap_kern.c

um: Kill directly reference of netdev->priv

2008-12-04 15:07:33 -08:00

pcap_user.c

missed kmalloc() in pcap_user.c

2008-05-21 16:55:57 -07:00

pcap_user.h

uml: remove useless comments

2009-04-01 08:59:17 -07:00

port_kern.c

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30 22:02:32 +09:00

port_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

port.h

uml: remove useless comments

2009-04-01 08:59:17 -07:00

pty.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

random.c

um: Remove BKL from random

2009-10-14 15:35:51 +02:00

slip_common.c

[PATCH] uml: slirp and slip driver cleanups and fixes

2005-06-13 20:58:43 -07:00

slip_common.h

[PATCH] uml: fix hugest stack users

2006-02-01 08:53:22 -08:00

slip_kern.c

UML: Fix some apparent bitrot

2009-06-25 11:22:13 -07:00

slip_user.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

slip.h

[PATCH] uml: const more data

2006-09-27 08:26:15 -07:00

slirp_kern.c

UML: Fix some apparent bitrot

2009-06-25 11:22:13 -07:00

slirp_user.c

uml: tidy helper code

2008-02-05 09:44:30 -08:00

slirp.h

[PATCH] uml: const more data

2006-09-27 08:26:15 -07:00

ssl.c

uml: tidy kern_util.h

2008-02-05 09:44:26 -08:00

ssl.h

uml: remove useless comments

2009-04-01 08:59:17 -07:00

stderr_console.c

spelling fixes: arch/um/

2007-10-20 01:23:03 +02:00

stdio_console.c

uml: make several things static

2008-04-28 08:58:28 -07:00

stdio_console.h

uml: remove useless comments

2009-04-01 08:59:17 -07:00

tty.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

ubd_kern.c

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30 22:02:32 +09:00

ubd_user.c

uml: tidy kern_util.h

2008-02-05 09:44:26 -08:00

vde_kern.c

um: Kill directly reference of netdev->priv

2008-12-04 15:07:33 -08:00

vde_user.c

uml: fix vde network backend in user mode linux

2009-02-20 17:57:48 -08:00

vde.h

uml: add VDE networking support

2007-10-16 09:43:05 -07:00

xterm_kern.c

uml: xterm driver tidying

2007-07-16 09:05:38 -07:00

xterm.c

uml: fix build when SLOB is enabled

2008-05-13 08:02:22 -07:00

xterm.h

uml: remove useless comments

2009-04-01 08:59:17 -07:00