Dmitry Eremin-Solenikov
50d1e7d107
serial: pxa: hold port.lock when reporting modem line changes
Both uart_handle_dcd_change() and uart_handle_cts_change() require a
port lock to be held and will emit a warning when lockdep is enabled.
Held corresponding lock.
This fixes the following warnings:
------------[ cut here ]------------
WARNING: CPU: 0 PID: 0 at drivers/tty/serial/serial_core.c:2760 uart_handle_dcd_change+0xc8/0xf8()
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted 3.18.0-rc5+ #26
[<c000dff8>] (unwind_backtrace) from [<c000bc70>] (show_stack+0x10/0x14)
[<c000bc70>] (show_stack) from [<c00192ac>] (warn_slowpath_common+0x6c/0x8c)
[<c00192ac>] (warn_slowpath_common) from [<c00192e8>] (warn_slowpath_null+0x1c/0x24)
[<c00192e8>] (warn_slowpath_null) from [<c0182984>] (uart_handle_dcd_change+0xc8/0xf8)
[<c0182984>] (uart_handle_dcd_change) from [<c018625c>] (serial_pxa_irq+0x268/0x3b0)
[<c018625c>] (serial_pxa_irq) from [<c004d0d4>] (handle_irq_event_percpu+0x50/0x16c)
[<c004d0d4>] (handle_irq_event_percpu) from [<c004d22c>] (handle_irq_event+0x3c/0x5c)
[<c004d22c>] (handle_irq_event) from [<c004f7d0>] (handle_level_irq+0x94/0x118)
[<c004f7d0>] (handle_level_irq) from [<c004ca0c>] (generic_handle_irq+0x20/0x30)
[<c004ca0c>] (generic_handle_irq) from [<c004cbe0>] (__handle_domain_irq+0x38/0x70)
[<c004cbe0>] (__handle_domain_irq) from [<c00085c4>] (ichp_handle_irq+0x24/0x34)
[<c00085c4>] (ichp_handle_irq) from [<c000c7e4>] (__irq_svc+0x44/0x54)
Exception stack(0xc07c7f58 to 0xc07c7fa0)
7f40: 00000001 00000001
7f60: 00000000 20000013 c07c6000 00000000 00000000 c07ce0a4 c07d7798 00000000
7f80: c07e8fb8 0000004c 00000000 c07c7fa0 c0044798 c0009f20 20000013 ffffffff
[<c000c7e4>] (__irq_svc) from [<c0009f20>] (arch_cpu_idle+0x28/0x38)
[<c0009f20>] (arch_cpu_idle) from [<c003c974>] (cpu_startup_entry+0x1b8/0x220)
[<c003c974>] (cpu_startup_entry) from [<c0338c54>] (start_kernel+0x39c/0x40c)
---[ end trace 4c1b7ae03f6d9d30 ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 0 at drivers/tty/serial/serial_core.c:2791 uart_handle_cts_change+0xa0/0xdc()
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Tainted: G W 3.18.0-rc5+ #26
[<c000dff8>] (unwind_backtrace) from [<c000bc70>] (show_stack+0x10/0x14)
[<c000bc70>] (show_stack) from [<c00192ac>] (warn_slowpath_common+0x6c/0x8c)
[<c00192ac>] (warn_slowpath_common) from [<c00192e8>] (warn_slowpath_null+0x1c/0x24)
[<c00192e8>] (warn_slowpath_null) from [<c018528c>] (uart_handle_cts_change+0xa0/0xdc)
[<c018528c>] (uart_handle_cts_change) from [<c018624c>] (serial_pxa_irq+0x258/0x3b0)
[<c018624c>] (serial_pxa_irq) from [<c004d0d4>] (handle_irq_event_percpu+0x50/0x16c)
[<c004d0d4>] (handle_irq_event_percpu) from [<c004d22c>] (handle_irq_event+0x3c/0x5c)
[<c004d22c>] (handle_irq_event) from [<c004f7d0>] (handle_level_irq+0x94/0x118)
[<c004f7d0>] (handle_level_irq) from [<c004ca0c>] (generic_handle_irq+0x20/0x30)
[<c004ca0c>] (generic_handle_irq) from [<c004cbe0>] (__handle_domain_irq+0x38/0x70)
[<c004cbe0>] (__handle_domain_irq) from [<c00085c4>] (ichp_handle_irq+0x24/0x34)
[<c00085c4>] (ichp_handle_irq) from [<c000c7e4>] (__irq_svc+0x44/0x54)
Exception stack(0xc07c7f58 to 0xc07c7fa0)
7f40: 00000001 00000001
7f60: 00000000 20000013 c07c6000 00000000 00000000 c07ce0a4 c07d7798 00000000
7f80: c07e8fb8 0000004c 00000000 c07c7fa0 c0044798 c0009f20 20000013 ffffffff
[<c000c7e4>] (__irq_svc) from [<c0009f20>] (arch_cpu_idle+0x28/0x38)
[<c0009f20>] (arch_cpu_idle) from [<c003c974>] (cpu_startup_entry+0x1b8/0x220)
[<c003c974>] (cpu_startup_entry) from [<c0338c54>] (start_kernel+0x39c/0x40c)
---[ end trace 4c1b7ae03f6d9d31 ]---
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26 19:35:49 -08:00
..
2014-10-31 22:24:44 +01:00
2014-09-30 01:16:44 +02:00
2014-10-18 18:11:04 -07:00
2014-10-17 11:55:32 -04:00
2014-11-07 11:07:35 -08:00
2014-10-23 14:02:06 -04:00
2014-11-03 15:04:26 -08:00
2014-10-13 11:28:42 +02:00
2014-10-08 17:37:16 -04:00
2014-10-31 06:33:26 -04:00
2014-10-15 07:05:03 +02:00
2014-10-26 20:50:00 +01:00
2014-10-27 23:27:35 +01:00
2014-10-24 12:48:47 -07:00
2014-10-14 10:51:23 +02:00
2014-09-29 20:22:36 +09:00
2014-11-05 18:26:10 -08:00
2014-10-09 02:39:07 -04:00
2014-10-22 22:59:00 +02:00
2014-10-23 14:45:09 -07:00
2014-10-09 14:58:15 -04:00
2014-11-03 01:51:28 +09:00
2014-10-29 11:52:35 -07:00
2014-09-23 23:31:22 -07:00
2014-10-19 18:41:18 -07:00
2014-11-07 19:03:18 +01:00
2014-10-18 12:12:45 -07:00
2014-11-05 18:33:46 +00:00
2014-10-31 15:04:58 -07:00
2014-10-31 19:51:11 -07:00
2014-10-15 07:23:49 +02:00
2014-09-23 23:26:42 -07:00
2014-11-02 01:31:10 +00:00
2014-10-14 15:05:35 -04:00
2014-10-21 08:18:38 -07:00
2014-09-25 23:14:37 +10:00
2014-10-21 11:21:19 -07:00
2014-10-18 12:25:30 -07:00
2014-11-03 19:08:06 -02:00
2014-10-14 02:18:22 +02:00
2014-10-07 21:29:18 -04:00
2014-10-15 06:58:16 +02:00
2014-10-28 19:52:52 +11:00
2014-11-05 09:28:48 +01:00
2014-11-02 14:45:52 -08:00
2014-10-31 16:18:35 -04:00
2014-10-07 14:48:29 -04:00
2014-10-17 07:08:51 -04:00
2014-11-04 10:19:48 +00:00
2014-10-13 16:23:15 +02:00
2014-11-06 14:58:21 -08:00
2014-10-31 18:48:29 -07:00
2014-11-05 14:34:06 -08:00
2014-10-28 11:16:26 +01:00
2014-10-27 21:45:13 -07:00
2014-10-14 02:18:25 +02:00
2014-10-22 10:08:22 +02:00
2014-10-21 08:17:43 -07:00
2014-11-05 14:59:25 +00:00
2014-10-29 16:33:14 -07:00
2014-10-21 07:47:54 -07:00
2014-10-28 09:57:00 +01:00
2014-10-28 22:05:07 +01:00
2014-11-06 12:58:46 +00:00
2014-10-09 14:58:15 -04:00
2014-11-05 11:30:45 -08:00
2014-10-21 13:06:38 -07:00
2014-11-03 18:59:50 -04:00
2014-11-26 19:35:49 -08:00
2014-10-02 21:35:54 -07:00
2014-11-06 12:25:40 -08:00
2014-10-15 07:23:49 +02:00
2014-10-30 14:53:49 +02:00
2014-10-18 10:25:09 -07:00
2014-10-20 21:09:17 +02:00
2014-10-23 16:24:02 +01:00
2014-09-24 09:49:14 -04:00