mirror
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/gpu/drm/panel
History
Stephen Boyd a3ee9e0b57 drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable 
The unprepare sequence has started to fail after moving to panel bridge
code in the msm drm driver (commit 007ac0262b ("drm/msm/dsi: switch to
DRM_PANEL_BRIDGE")). You'll see messages like this in the kernel logs:

   panel-boe-tv101wum-nl6 ae94000.dsi.0: failed to set panel off: -22

This is because boe_panel_enter_sleep_mode() needs an operating DSI link
to set the panel into sleep mode. Performing those writes in the
unprepare phase of bridge ops is too late, because the link has already
been torn down by the DSI controller in post_disable, i.e. the PHY has
been disabled, etc. See dsi_mgr_bridge_post_disable() for more details
on the DSI .

Split the unprepare function into a disable part and an unprepare part.
For now, just the DSI writes to enter sleep mode are put in the disable
function. This fixes the panel off routine and keeps the panel happy.

My Wormdingler has an integrated touchscreen that stops responding to
touch if the panel is only half disabled too. This patch fixes it. And
finally, this saves power when the screen is off because without this
fix the regulators for the panel are left enabled when nothing is being
displayed on the screen.

Fixes: 007ac0262b ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")
Fixes: a869b9db7a ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel")
Cc: yangcong <yangcong5@huaqin.corp-partner.google.com>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Clark <robdclark@chromium.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230106030108.2542081-1-swboyd@chromium.org
(cherry picked from commit c913cd5489)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
 		2023-02-01 11:41:15 +01:00
..
Kconfig drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel 2022-11-14 12:44:46 +01:00
Makefile drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel 2022-11-14 12:44:46 +01:00
panel-abt-y030xx067a.c drm/panel: innolux-ej030na and abt-y030xx067a: add .enable and .disable 2022-04-05 21:41:36 +01:00
panel-arm-versatile.c
…
panel-asus-z00t-tm5p5-n35596.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-boe-bf060y8m-aj0.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-boe-himax8279d.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-boe-tv101wum-nl6.c drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable 2023-02-01 11:41:15 +01:00
panel-dsi-cm.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-ebbg-ft8719.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-edp.c drm/panel-edp: Add INX N116BGE-EA2 (HW: C4) 2022-10-21 07:32:00 -07:00
panel-elida-kd35t133.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-feixin-k101-im2ba02.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-feiyang-fy07024di26a30d.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-ilitek-ili9322.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-ilitek-ili9341.c drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
panel-ilitek-ili9881c.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-innolux-ej030na.c drm/panel: innolux-ej030na and abt-y030xx067a: add .enable and .disable 2022-04-05 21:41:36 +01:00
panel-innolux-p079zca.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-jadard-jd9365da-h3.c drm: panel: Add Jadard JD9365DA-H3 DSI panel 2022-11-09 10:40:56 +01:00
panel-jdi-fhd-r63452.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-jdi-lt070me05000.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-khadas-ts050.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-kingdisplay-kd097d04.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-leadtek-ltk050h3146w.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-leadtek-ltk500hd1829.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-lg-lb035q02.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-lg-lg4573.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-lvds.c drm/panel: lvds: Implement .get_orientation callback 2022-06-21 08:47:26 -07:00
panel-mantix-mlaf057we51.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-nec-nl8048hl11.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-newvision-nv3051d.c drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel 2022-11-14 12:44:46 +01:00
panel-newvision-nv3052c.c drm-misc-next for 5.19: 2022-04-12 17:44:27 +10:00
panel-novatek-nt35510.c drm: Fix typo 'the the' in comment 2022-07-27 09:17:58 +02:00
panel-novatek-nt35560.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-novatek-nt35950.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-novatek-nt36672a.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-novatek-nt39016.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-olimex-lcd-olinuxino.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
panel-orisetech-otm8009a.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-osd-osd101t2587-53ts.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-panasonic-vvx10f034n00.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-raspberrypi-touchscreen.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
panel-raydium-rm67191.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-raydium-rm68200.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-ronbo-rb070d30.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-atna33xc20.c drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_aux 2022-06-21 09:06:31 -07:00
panel-samsung-db7430.c drm/panel: db7430: Silent no spi_device_id warning 2022-10-03 21:48:41 +02:00
panel-samsung-ld9040.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-samsung-s6d16d0.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-s6d27a1.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-samsung-s6e3ha2.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-s6e8aa0.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-s6e63j0x03.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-s6e63m0-dsi.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-s6e63m0-spi.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-samsung-s6e63m0.c drm/panel: s6e63m0: Make s6e63m0_remove() return void 2021-10-11 18:49:29 +02:00
panel-samsung-s6e63m0.h drm/panel: s6e63m0: Make s6e63m0_remove() return void 2021-10-11 18:49:29 +02:00
panel-samsung-s6e88a0-ams452ef01.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-samsung-sofef00.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-seiko-43wvf1g.c drm: Remove linux/media-bus-format.h from drm_crtc.h 2022-07-05 21:15:13 +03:00
panel-sharp-lq101r1sx01.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-sharp-ls037v7dw01.c drm/panel: ls037v7dw01: Make use of the helper function dev_err_probe() 2021-10-14 22:10:03 +02:00
panel-sharp-ls043t1le01.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-sharp-ls060t1sx01.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-simple.c drm/panel: simple: set bpc field for logic technologies displays 2022-11-10 07:29:45 -08:00
panel-sitronix-st7701.c drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure 2022-11-01 23:12:06 +01:00
panel-sitronix-st7703.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-sitronix-st7789v.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-sony-acx565akm.c drm/panel: sony-acx565akm: Use backlight helpers 2022-06-24 21:38:04 +02:00
panel-sony-tulip-truly-nt35521.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-tdo-tl070wsh30.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-tpo-td028ttec1.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-tpo-td043mtea1.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
panel-tpo-tpg110.c drm/panel: tpg110: Silent no spi_device_id warning 2022-10-03 21:49:50 +02:00
panel-truly-nt35597.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-visionox-rm69299.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00
panel-widechips-ws2401.c drm/panel: ws2401: Silent no spi_device_id warning 2022-10-03 21:50:53 +02:00
panel-xinpeng-xpp055c272.c drm/mipi-dsi: Make remove callback return void 2022-07-09 10:50:03 +02:00