Files
linux/drivers/gpio
Johan Hovold 52176d0d3b gpio: sysfs: fix redundant lock-as-irq handling
Drivers should call gpiochip_lock_as_irq (which prevents the pin
direction from being changed) in their irq_request_resources callbacks
but some drivers currently fail to do so.

Instead a second, explicit and often redundant call to lock-as-irq is
made by the sysfs-interface implementation after an irq has been
requested.

Move the explicit call before the irq-request to match the unlock done
after the irq is later released. Note that this also fixes an irq leak,
should the explicit call ever have failed.

Also add a comment about removing the redundant call once the broken
drivers have been fixed.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2015-05-12 10:46:31 +02:00
..
2015-03-17 17:45:59 +01:00
2015-01-20 11:03:07 +01:00
2015-01-20 11:03:07 +01:00
2015-05-05 17:50:07 +02:00
2015-05-12 09:41:28 +02:00
2015-05-12 09:41:28 +02:00
2015-05-12 10:13:41 +02:00
2015-01-22 09:45:24 +01:00
2015-05-12 10:13:41 +02:00
2015-05-12 10:46:15 +02:00