Minchan Kim 5547932dc6 zram: fix double free backing device ...

If blkdev_get fails, we shouldn't do blkdev_put.  Otherwise, kernel emits
below log.  This patch fixes it.

  WARNING: CPU: 0 PID: 1893 at fs/block_dev.c:1828 blkdev_put+0x105/0x120
  Modules linked in:
  CPU: 0 PID: 1893 Comm: swapoff Not tainted 4.19.0+ #453
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
  RIP: 0010:blkdev_put+0x105/0x120
  Call Trace:
    __x64_sys_swapoff+0x46d/0x490
    do_syscall_64+0x5a/0x190
    entry_SYSCALL_64_after_hwframe+0x49/0xbe
  irq event stamp: 4466
  hardirqs last  enabled at (4465):  __free_pages_ok+0x1e3/0x490
  hardirqs last disabled at (4466):  trace_hardirqs_off_thunk+0x1a/0x1c
  softirqs last  enabled at (3420):  __do_softirq+0x333/0x446
  softirqs last disabled at (3407):  irq_exit+0xd1/0xe0

Link: http://lkml.kernel.org/r/20181127055429.251614-3-minchan@kernel.org
Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: <stable@vger.kernel.org>	[4.14+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2018-12-28 12:11:49 -08:00

..

aoe

aoe: convert aoeblk to blk-mq

2018-10-14 12:47:52 -06:00

drbd

crypto: drop mask=CRYPTO_ALG_ASYNC from 'shash' tfm allocations

2018-11-20 14:26:55 +08:00

mtip32xx

mtip32xx: clean an indentation issue, remove extraneous tabs

2018-10-30 14:31:36 -06:00

paride

paride: convert pf to blk-mq

2018-10-15 20:08:15 -06:00

rsxx

Merge tag 'pci-v4.20-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2018-10-25 06:50:48 -07:00

xen-blkback

xen/blkback: remove unused pers_gnts_lock from struct xen_blkif_ring

2018-08-27 12:12:04 -04:00

zram

zram: fix double free backing device

2018-12-28 12:11:49 -08:00

amiflop.c

amiflop: convert to blk-mq

2018-10-16 09:49:52 -06:00

ataflop.c

ataflop: convert to blk-mq

2018-10-16 09:50:09 -06:00

brd.c

block: brd: associate with queue until adding disk

2018-11-01 19:59:51 -06:00

cryptoloop.c

block: cryptoloop: Remove VLA usage of skcipher

2018-09-28 12:46:07 +08:00

floppy.c

floppy: fix race condition in __floppy_read_block_0()

2018-11-10 08:16:12 -07:00

Kconfig

drivers/block: Remove DAC960 driver

2018-10-17 09:42:30 -06:00

loop.c

Merge tag 'for-linus-20181102' of git://git.kernel.dk/linux-block

2018-11-02 11:25:48 -07:00

loop.h

loop: remember whether sysfs_create_group() was done

2018-05-07 15:26:36 -06:00

Makefile

drivers/block: Remove DAC960 driver

2018-10-17 09:42:30 -06:00

nbd.c

iov_iter: Separate type from direction and use accessor functions

2018-10-24 00:41:07 +01:00

null_blk_main.c

block: Introduce blk_revalidate_disk_zones()

2018-10-25 11:17:40 -06:00

null_blk_zoned.c

block: add a report_zones method

2018-10-25 11:17:40 -06:00

null_blk.h

block: add a report_zones method

2018-10-25 11:17:40 -06:00

pktcdvd.c

pktcdvd: fix fall-through annotation

2018-10-02 08:36:58 -06:00

ps3disk.c

ps3disk: convert to blk-mq

2018-10-15 20:07:56 -06:00

ps3vram.c

block: genhd: add 'groups' argument to device_add_disk

2018-09-28 08:30:28 -06:00

rbd_types.h

rbd: RBD_V{1,2}_DATA_FORMAT macros

2017-02-20 12:16:15 +01:00

rbd.c

libceph, rbd, ceph: move ceph_osdc_alloc_messages() calls

2018-10-22 10:28:22 +02:00

skd_main.c

skd: fix unchecked return values

2018-10-25 11:17:39 -06:00

skd_s1120.h

skd: Use __packed only when needed

2017-08-18 08:45:29 -06:00

sunvdc.c

Merge tag 'for-4.20/block-20181021' of git://git.kernel.dk/linux-block

2018-10-22 17:46:08 +01:00

swim3.c

swim3: convert to blk-mq

2018-10-16 09:49:36 -06:00

swim_asm.S

…

swim.c

swim: convert to blk-mq

2018-10-16 09:49:18 -06:00

sx8.c

sx8: switch to the generic DMA API

2018-10-18 15:14:45 -06:00

umem.c

umem: switch to the generic DMA API

2018-10-18 15:14:47 -06:00

umem.h

…

virtio_blk.c

virtio-blk: modernize sysfs attribute creation

2018-09-28 08:30:33 -06:00

xen-blkfront.c

Merge tag 'for-linus-4.20a-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip

2018-11-10 08:58:48 -06:00

xsysace.c

xsysace: convert to blk-mq

2018-10-15 20:08:24 -06:00

z2ram.c

Merge tag 'powerpc-4.20-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux

2018-10-26 14:36:21 -07:00