Rafael J. Wysocki 4e814173a8
thermal: core: Fix thermal zone suspend-resume synchronization ...
There are 3 synchronization issues with thermal zone suspend-resume
during system-wide transitions:
1. The resume code runs in a PM notifier which is invoked after user
space has been thawed, so it can run concurrently with user space
which can trigger a thermal zone device removal. If that happens,
the thermal zone resume code may use a stale pointer to the next
list element and crash, because it does not hold thermal_list_lock
while walking thermal_tz_list.
2. The thermal zone resume code calls thermal_zone_device_init()
outside the zone lock, so user space or an update triggered by
the platform firmware may see an inconsistent state of a
thermal zone leading to unexpected behavior.
3. Clearing the in_suspend global variable in thermal_pm_notify()
allows __thermal_zone_device_update() to continue for all thermal
zones and it may as well run before the thermal_tz_list walk (or
at any point during the list walk for that matter) and attempt to
operate on a thermal zone that has not been resumed yet. It may
also race destructively with thermal_zone_device_init().
To address these issues, add thermal_list_lock locking to
thermal_pm_notify(), especially arount the thermal_tz_list,
make it call thermal_zone_device_init() back-to-back with
__thermal_zone_device_update() under the zone lock and replace
in_suspend with per-zone bool "suspend" indicators set and unset
under the given zone's lock.
Link: https://lore.kernel.org/linux-pm/20231218162348.69101-1-bo.ye@mediatek.com/
Reported-by: Bo Ye <bo.ye@mediatek.com >
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
2023-12-28 14:20:15 +01:00
2023-10-09 18:14:15 +02:00
2023-10-05 09:13:42 -07:00
2023-10-05 21:44:48 +02:00
2023-11-03 14:51:08 -10:00
2023-11-10 09:52:56 -08:00
2023-08-22 14:13:11 -07:00
2023-10-05 13:34:05 +02:00
2023-10-24 13:08:14 -07:00
2023-11-01 14:46:51 -10:00
2023-11-04 10:22:52 +01:00
2023-08-22 16:32:35 +02:00
2023-10-09 12:37:23 +03:00
2023-11-04 16:25:36 -10:00
2023-10-11 15:54:41 +01:00
2023-09-30 09:24:17 -07:00
2023-10-16 12:44:04 -04:00
2023-11-02 14:40:51 -10:00
2023-08-23 08:25:28 +01:00
2023-11-05 09:02:32 -10:00
2023-11-03 12:01:32 +01:00
2023-11-04 11:04:30 -10:00
2023-10-04 14:12:01 +02:00
2023-08-25 07:42:58 +01:00
2023-09-18 09:28:22 +01:00
2023-10-24 19:26:14 +00:00
2023-11-04 10:23:22 +01:00
2023-11-07 17:10:02 -08:00
2023-08-23 08:21:37 +01:00
2023-09-11 08:13:18 +00:00
2023-10-02 19:43:49 +01:00
2023-11-02 20:53:31 -10:00
2023-11-01 14:46:51 -10:00
2023-09-03 10:20:57 -07:00
2023-11-10 13:54:58 +00:00
2023-11-08 13:39:16 -08:00
2023-09-26 16:01:07 +03:00
2023-10-21 12:45:45 +02:00
2023-11-05 08:41:14 -10:00
2023-10-27 20:13:38 -07:00
2023-10-06 16:01:54 +02:00
2023-10-08 21:18:48 +01:00
2023-09-12 13:07:37 +01:00
2023-10-03 16:28:40 +03:00
2023-08-31 01:29:28 +02:00
2023-09-26 00:44:33 -06:00
2023-10-11 08:46:01 -07:00
2023-08-30 17:35:54 +08:00
2023-10-14 20:25:22 -07:00
2023-10-16 16:14:45 -07:00
2023-09-22 08:52:13 -06:00
2023-10-28 13:29:16 +02:00
2023-10-25 16:47:13 -07:00
2023-10-20 14:15:13 -07:00
2023-10-23 21:49:32 -07:00
2023-10-11 17:27:47 -07:00
2023-11-01 11:16:34 -10:00
2023-11-15 07:51:06 -08:00
2023-10-06 16:01:27 -07:00
2023-09-15 12:08:27 -07:00
2023-11-01 22:33:53 -07:00
2023-10-25 16:47:10 -07:00
2023-10-18 18:07:57 -07:00
2023-08-24 16:20:25 -07:00
2023-10-25 16:47:10 -07:00
2023-11-02 19:38:47 -10:00
2023-10-19 17:02:46 -07:00
2023-09-13 14:59:54 +02:00
2023-10-13 15:38:24 -07:00
2023-10-30 21:48:22 -04:00
2023-10-03 19:51:37 +02:00
2023-10-03 12:17:10 -07:00
2023-10-04 10:41:56 -07:00
2023-10-04 10:41:56 -07:00
2023-10-18 14:43:22 -07:00
2023-11-03 15:44:25 -10:00
2023-10-18 14:43:22 -07:00
2023-10-23 11:32:25 +02:00
2023-10-06 22:05:56 +02:00
2023-11-19 13:35:07 -08:00
2023-10-14 20:25:21 -07:00
2023-11-02 20:53:31 -10:00
2023-09-18 12:23:27 +10:00
2023-10-30 20:13:17 -10:00
2023-10-27 18:04:29 +08:00
2023-10-25 16:47:15 -07:00
2023-10-04 10:32:20 -07:00
2023-09-11 23:59:47 -04:00
2023-10-28 13:29:18 +02:00
2023-10-05 11:15:52 +02:00
2023-08-25 16:07:30 -07:00
2023-10-05 11:05:58 +02:00
2023-11-06 08:35:09 +01:00
2023-10-04 19:25:30 +05:30
2023-10-15 16:08:24 +01:00
2023-09-11 08:13:17 +00:00
2023-08-23 14:17:42 -07:00
2023-11-02 12:17:17 +01:00
2023-11-17 13:24:08 +09:00
2023-11-07 12:11:26 -08:00
2023-10-16 12:52:39 -07:00
2023-09-29 08:27:15 +10:00
2023-10-19 11:02:48 +02:00
2023-10-16 21:05:33 -07:00
2023-11-02 20:53:31 -10:00
2023-10-12 18:53:36 +03:00
2023-10-18 14:08:29 +02:00
2023-11-02 19:38:47 -10:00
2023-10-08 20:44:26 -07:00
2023-10-19 11:03:15 +02:00
2023-08-22 05:20:34 -04:00
2023-10-27 20:48:03 -07:00
2023-10-05 13:11:29 +02:00
2023-10-19 14:47:33 -04:00
2023-10-25 16:47:16 -07:00
2023-09-24 13:31:33 +01:00
2023-10-25 18:33:42 +02:00
2023-10-25 20:19:00 +02:00
2023-10-20 13:39:26 +08:00
2023-11-11 18:06:42 +01:00
2023-10-18 14:34:17 -07:00
2023-10-25 16:47:16 -07:00
2023-09-15 18:29:45 +08:00
2023-09-04 11:26:29 -07:00
2023-09-13 10:48:48 +02:00
2023-11-03 09:12:00 +00:00
2023-10-26 20:27:58 -07:00
2023-08-25 08:08:27 +01:00
2023-09-19 16:28:37 +02:00
2023-10-02 11:24:52 -07:00
2023-10-28 21:31:22 +09:00
2023-10-13 20:18:42 -07:00
2023-09-12 17:50:53 +02:00
2023-10-04 11:12:11 +03:00
2023-10-30 18:01:41 -10:00
2023-11-01 11:25:08 -10:00
2023-10-19 16:42:03 -06:00
2023-10-24 11:58:42 -03:00
2023-08-29 20:21:42 -07:00
2023-11-09 13:37:28 -08:00
2023-10-05 13:58:07 +02:00
2023-10-12 09:58:02 +02:00
2023-09-25 14:30:28 +02:00
2023-10-24 11:58:42 -03:00
2023-10-03 15:51:04 -07:00
2023-10-26 13:53:06 +02:00
2023-09-28 12:25:31 +02:00
2023-10-16 12:44:14 -04:00
2023-10-04 10:32:25 -07:00
2023-10-26 13:46:28 -07:00
2023-10-03 16:28:40 +03:00
2023-10-05 13:42:11 +02:00
2023-10-04 10:41:58 -07:00
2023-10-11 10:11:54 -07:00
2023-11-10 19:59:05 +09:00
2023-10-18 14:43:21 -07:00
2023-10-04 10:41:57 -07:00
2023-10-08 22:46:04 -07:00
2023-10-03 09:39:50 +09:00
2023-10-20 12:47:33 +01:00
2023-09-22 09:38:42 +02:00
2023-10-16 12:44:06 -04:00
2023-10-05 11:11:31 -05:00
2023-11-08 15:39:42 -05:00
2023-10-16 12:44:06 -04:00
2023-09-29 17:20:46 -07:00
2023-10-05 09:50:14 +02:00
2023-11-13 11:02:30 +00:00
2023-10-18 10:01:33 +02:00
2023-10-04 10:32:30 -07:00
2023-10-25 16:47:14 -07:00
2023-10-16 15:44:39 -07:00
2023-10-25 16:47:16 -07:00
2023-10-20 11:50:46 +01:00
2023-10-04 10:32:28 -07:00
2023-10-18 14:43:22 -07:00
2023-10-18 14:34:18 -07:00
2023-11-02 19:38:47 -10:00
2023-11-02 19:38:47 -10:00
2023-10-06 14:44:10 -07:00
2023-10-25 16:47:11 -07:00
2023-11-03 23:28:33 +01:00
2023-11-03 15:31:04 -10:00
2023-11-01 13:07:08 -07:00
2023-11-01 21:09:37 -10:00
2023-09-11 15:05:50 +02:00
2023-10-26 13:53:06 +02:00
2023-10-19 11:02:49 +02:00
2023-10-27 10:51:41 +01:00
2023-10-18 10:26:43 +02:00
2023-10-16 12:44:26 -04:00
2023-11-01 15:15:52 -04:00
2023-09-13 11:51:11 -04:00
2023-11-01 15:40:44 -04:00
2023-10-30 15:40:57 -10:00
2023-10-17 13:57:54 -07:00
2023-09-05 05:34:14 -04:00
2023-11-08 08:07:08 -08:00
2023-10-11 10:11:54 -07:00
2023-11-06 08:34:15 -08:00
2023-09-19 19:57:53 -07:00
2023-10-27 13:17:54 +02:00
2023-10-18 22:35:36 +09:00
2023-10-30 13:20:02 -10:00
2023-09-05 13:02:13 -05:00
2023-10-27 18:04:30 +08:00
2023-10-03 12:17:10 -07:00
2023-08-24 16:20:18 -07:00
2023-10-18 14:34:17 -07:00
2023-10-18 14:34:16 -07:00
2023-10-18 10:02:52 +02:00
2023-11-02 14:05:18 -10:00
2023-11-02 14:05:18 -10:00
2023-10-18 14:34:14 -07:00
2023-10-20 14:15:06 -07:00
2023-11-15 04:18:31 +01:00
2023-09-29 17:20:46 -07:00
2023-09-19 17:03:44 +02:00
2023-10-17 17:51:53 -07:00
2023-10-19 11:02:47 +02:00
2023-10-28 13:29:17 +02:00
2023-10-06 09:40:10 +01:00
2023-10-06 12:37:34 +05:30
2023-08-22 21:31:57 +02:00
2023-08-22 22:03:43 +02:00
2023-10-26 15:16:03 +02:00
2023-10-03 21:18:13 +02:00
2023-10-15 20:07:52 +01:00
2023-09-17 00:43:13 +02:00
2023-09-21 09:40:30 +02:00
2023-10-05 13:12:06 +02:00
2023-10-10 13:49:21 +02:00
2023-11-10 09:20:55 +01:00
2023-10-06 11:01:23 +02:00
2023-10-06 11:01:23 +02:00
2023-08-24 21:34:28 -04:00
2023-09-11 22:10:47 +02:00
2023-10-04 22:29:45 +02:00
2023-10-04 22:29:45 +02:00
2023-10-04 22:29:45 +02:00
2023-10-11 19:43:43 +02:00
2023-09-19 13:21:34 -07:00
2023-10-18 23:59:54 +09:00
2023-10-18 14:34:14 -07:00
2023-10-09 15:03:28 +02:00
2023-11-02 20:53:31 -10:00
2023-10-08 21:16:30 +01:00
2023-08-24 16:20:31 -07:00
2023-09-14 15:35:36 -04:00
2023-10-17 09:10:06 -06:00
2023-08-22 11:10:26 -06:00
2023-10-28 16:52:43 -04:00
2023-10-04 10:41:57 -07:00
2023-10-17 13:28:12 +02:00
2023-10-03 14:35:53 +02:00
2023-10-18 14:34:13 -07:00
2023-10-18 14:34:18 -07:00
2023-10-30 09:24:21 -10:00
2023-11-04 15:58:13 -10:00
2023-09-13 14:59:24 +02:00
2023-10-15 13:19:42 +01:00
2023-10-27 10:35:44 +01:00
2023-11-01 10:02:18 +00:00
2023-11-08 11:06:50 -08:00
2023-10-19 13:01:33 +02:00
2023-09-11 23:59:47 -04:00
2023-11-03 19:15:19 -10:00
2023-10-18 14:43:21 -07:00
2023-10-28 13:29:19 +02:00
2023-09-27 11:19:15 +02:00
2023-11-01 15:28:33 -10:00
2023-11-01 12:10:02 -07:00
2023-10-05 13:42:11 +02:00
2023-11-03 09:16:42 +00:00
2023-12-28 14:20:15 +01:00
2023-10-13 08:49:13 +03:00
2023-09-27 16:58:11 +02:00
2023-10-18 14:43:21 -07:00
2023-09-15 13:48:10 +02:00
2023-09-24 17:24:01 +02:00
2023-11-03 07:41:18 -10:00
2023-10-20 12:16:10 -04:00
2023-11-02 00:16:49 -04:00
2023-10-19 18:11:38 -07:00
2023-08-22 14:58:15 +02:00
2023-08-22 14:58:15 +02:00
2023-10-03 14:31:15 +02:00
2023-09-13 10:18:42 -07:00
2023-09-14 16:16:36 +02:00
2023-10-09 09:35:14 +02:00
2023-10-27 18:04:28 +08:00
2023-10-05 09:35:12 +02:00
2023-10-11 08:46:01 -07:00
2023-10-18 14:34:12 -07:00
2023-11-01 09:20:00 -04:00
2023-09-15 18:29:45 +08:00
2023-08-24 13:27:47 -05:00
2023-10-15 19:59:15 +01:00
2023-11-01 09:31:16 -04:00
2023-09-21 12:34:00 +02:00
2023-09-04 13:44:11 -07:00
2023-10-18 14:34:18 -07:00
2023-10-19 11:02:48 +02:00
2023-10-17 23:49:19 -10:00
2023-09-05 19:01:38 -04:00
4e814173a8