Files
linux/include/linux
Masahiro Yamada 3a176b9460 Revert "kbuild: avoid static_assert for genksyms"
This reverts commit 14dc3983b5.

Macro Elver had sent a fix proper fix earlier, and also pointed out
corner cases:
 "I guess what you propose is simpler, but might still have corner cases
  where we still get warnings. In particular, if some file (for whatever
  reason) does not include build_bug.h and uses a raw _Static_assert(),
  then we still get warnings. E.g. I see 1 user of raw _Static_assert()
  (drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h )."

I believe the raw use of _Static_assert() should be allowed, so this
should be fixed in genksyms.

Even after commit 14dc3983b5 ("kbuild: avoid static_assert for
genksyms"), I confirmed the following test code emits the warning.

  ---------------->8----------------
  #include <linux/export.h>

  _Static_assert((1 ?: 0), "");

  void foo(void) { }
  EXPORT_SYMBOL(foo);
  ---------------->8----------------

  WARNING: modpost: EXPORT symbol "foo" [vmlinux] version generation failed, symbol will not be versioned.

Now that commit 869b91992bce ("genksyms: Ignore module scoped
_Static_assert()") fixed this issue properly, the workaround should
be reverted.

Link: https://lkml.org/lkml/2020/12/10/845
Link: https://lkml.kernel.org/r/20201219183911.181442-1-masahiroy@kernel.org
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Cc: Marco Elver <elver@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-12-29 15:36:49 -08:00
..
2020-12-09 19:26:02 -06:00
2020-12-02 09:46:55 -07:00
2020-11-06 08:08:37 -08:00
2020-12-02 09:46:55 -07:00
2020-12-19 11:18:38 -08:00
2020-10-16 17:21:51 +02:00
2020-12-14 16:24:19 +01:00
2020-12-11 14:02:14 -08:00
2020-12-02 22:00:22 -08:00
2020-12-10 12:42:59 -06:00
2020-11-16 16:31:41 +01:00
2020-11-16 15:20:01 +01:00
2020-11-16 08:14:30 -07:00
2020-12-02 22:10:35 -08:00
2020-11-23 14:16:55 +00:00
2020-12-08 14:14:48 +00:00
2020-11-24 16:47:48 +01:00
2020-12-15 16:19:31 +01:00
2020-12-15 16:19:31 +01:00
2020-12-07 10:29:57 +01:00
2020-12-04 12:23:25 +01:00
2020-12-15 15:11:08 -06:00
2020-12-16 13:08:18 -08:00
2020-10-18 09:27:10 -07:00
2020-12-03 11:20:52 +01:00
2020-12-15 12:13:39 -08:00
2020-12-07 17:12:49 -07:00
2020-11-06 10:05:18 -08:00
2020-12-10 16:17:15 +01:00
2020-12-15 12:13:37 -08:00
2020-11-24 16:47:49 +01:00
2020-12-10 10:45:36 +01:00
2020-12-19 11:18:38 -08:00
2020-10-30 21:57:04 +01:00
2020-11-16 15:20:01 +01:00
2020-12-04 16:54:35 +01:00
2020-11-09 18:39:36 +01:00
2020-12-15 12:13:41 -08:00